From: Andi Kleen <ak@linux.intel.com>
To: Daniel Walker <dwalker@mvista.com>
Cc: linux-acpi@vger.kernel.org, Robert Moore <robert.moore@intel.com>,
Matthew Wilcox <matthew@wil.cx>,
Peter Zijlstra <peterz@infradead.org>,
Zhao Yakui <yakui.zhao@intel.com>,
Dave Chinner <david@fromorbit.com>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 4/5] acpi: remove interpreter lock
Date: Fri, 08 Aug 2008 04:40:45 +0200 [thread overview]
Message-ID: <489BB22D.2040001@linux.intel.com> (raw)
In-Reply-To: <1218121178-13779-5-git-send-email-dwalker@mvista.com>
Daniel Walker wrote:
> Lockdep has identified this lock as a source of potential deadlock in
> acpi. After reviewing the lock it's not clear what it's protecting. I
> invite anyone who might know what the point of the lock is to describe it.
>
> In the mean time I removed the lock completely which, so far, hasn't had
> any ill effects on my test machines.
As Bob pointed out this lock is required by the ACPI specification. So I'm
not going to apply this patch.
However of course we still have to do something about the lockdep warnings
when the lock is dropped/reaquired.
The big question is if deadlocks can happen really or not. AFAIK we didn't
have a clear answer on that yet.
-Andi
prev parent reply other threads:[~2008-08-08 2:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-07 14:59 [PATCH 0/3] acpi: semaphore removal -v2 Daniel Walker
2008-08-07 14:59 ` [PATCH 1/5] add mutex_lock_timeout() Daniel Walker
2008-08-07 14:59 ` [PATCH 2/5] acpi: add real mutex function calls Daniel Walker
2008-08-07 14:59 ` [PATCH 3/5] acpi: add lockdep magic Daniel Walker
2008-08-07 14:59 ` [PATCH 4/5] acpi: remove interpreter lock Daniel Walker
2008-08-07 14:59 ` [PATCH 5/5] acpi: semaphore removal Daniel Walker
2008-08-08 0:34 ` Matthew Wilcox
2008-08-08 1:00 ` Daniel Walker
2008-08-08 1:28 ` Dave Chinner
2008-08-08 2:53 ` Matthew Wilcox
2008-08-08 3:47 ` Daniel Walker
2008-08-08 2:44 ` Andi Kleen
2008-08-08 3:35 ` Daniel Walker
2008-08-07 20:32 ` [PATCH 4/5] acpi: remove interpreter lock Moore, Robert
2008-08-07 21:09 ` Daniel Walker
2008-08-07 21:30 ` Moore, Robert
2008-08-08 0:01 ` Daniel Walker
2008-08-08 2:40 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489BB22D.2040001@linux.intel.com \
--to=ak@linux.intel.com \
--cc=david@fromorbit.com \
--cc=dwalker@mvista.com \
--cc=linux-acpi@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=robert.moore@intel.com \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.