All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@linux.intel.com>
To: Daniel Walker <dwalker@mvista.com>
Cc: linux-acpi@vger.kernel.org, Robert Moore <robert.moore@intel.com>,
	Matthew Wilcox <matthew@wil.cx>,
	Peter Zijlstra <peterz@infradead.org>,
	Zhao Yakui <yakui.zhao@intel.com>,
	Dave Chinner <david@fromorbit.com>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 5/5] acpi: semaphore removal
Date: Fri, 08 Aug 2008 04:44:04 +0200	[thread overview]
Message-ID: <489BB2F4.9010408@linux.intel.com> (raw)
In-Reply-To: <1218121178-13779-6-git-send-email-dwalker@mvista.com>

Daniel Walker wrote:
> The semaphore usage in ACPI is more like completions. The ASL
> functions getting implemented here are signals which follow a
> "wait for", signaled, or reset format.
> 
> This implements the ACPI signaling methods with the Linux
> completion API, instead of using semaphores.
> 
> completion_done() taken from Dave Chinner.

I agree with Matthew's earlier criticism. It doesn't make sense to
reinvent semaphores using completions when we really need semaphores
here for several cases (e.g. the AML locks by themselves)

So I'm not going to apply this patch.

What I'm open for is to convert specific non AML instances
of the ACPICA semaphores to mutexes. Such changes would need
to be coordinated with Bob of course though because it would affect
his codebase. In fact that has been already done for some.

-Andi

  parent reply	other threads:[~2008-08-08  2:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-07 14:59 [PATCH 0/3] acpi: semaphore removal -v2 Daniel Walker
2008-08-07 14:59 ` [PATCH 1/5] add mutex_lock_timeout() Daniel Walker
2008-08-07 14:59   ` [PATCH 2/5] acpi: add real mutex function calls Daniel Walker
2008-08-07 14:59     ` [PATCH 3/5] acpi: add lockdep magic Daniel Walker
2008-08-07 14:59       ` [PATCH 4/5] acpi: remove interpreter lock Daniel Walker
2008-08-07 14:59         ` [PATCH 5/5] acpi: semaphore removal Daniel Walker
2008-08-08  0:34           ` Matthew Wilcox
2008-08-08  1:00             ` Daniel Walker
2008-08-08  1:28             ` Dave Chinner
2008-08-08  2:53               ` Matthew Wilcox
2008-08-08  3:47                 ` Daniel Walker
2008-08-08  2:44           ` Andi Kleen [this message]
2008-08-08  3:35             ` Daniel Walker
2008-08-07 20:32         ` [PATCH 4/5] acpi: remove interpreter lock Moore, Robert
2008-08-07 21:09           ` Daniel Walker
2008-08-07 21:30             ` Moore, Robert
2008-08-08  0:01               ` Daniel Walker
2008-08-08  2:40         ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=489BB2F4.9010408@linux.intel.com \
    --to=ak@linux.intel.com \
    --cc=david@fromorbit.com \
    --cc=dwalker@mvista.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=robert.moore@intel.com \
    --cc=yakui.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.