From: Vlad Yasevich <vladislav.yasevich@hp.com>
To: Brian Haley <brian.haley@hp.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, containers <containers@lists.osdl.org>,
linux-sctp@vger.kernel.org
Subject: Re: [PATCH 2/2] netns: Add network namespace argument in rt6_fill_node() and ipv6_dev_get_saddr()
Date: Thu, 14 Aug 2008 16:04:25 -0400 [thread overview]
Message-ID: <48A48FC9.4020805@hp.com> (raw)
In-Reply-To: <48A48722.3050509@hp.com>
Hi Brian
Brian Haley wrote:
> ---
>
> diff --git a/net/sctp/ipv6.c b/net/sctp/ipv6.c
> index 483a01d..e0945d4 100644
> --- a/net/sctp/ipv6.c
> +++ b/net/sctp/ipv6.c
> @@ -319,7 +319,8 @@ static void sctp_v6_get_saddr(struct sctp_sock *sk,
> __func__, asoc, dst, NIP6(daddr->v6.sin6_addr));
>
> if (!asoc) {
> - ipv6_dev_get_saddr(dst ? ip6_dst_idev(dst)->dev : NULL,
> + ipv6_dev_get_saddr(NULL,
> + dst ? ip6_dst_idev(dst)->dev : NULL,
> &daddr->v6.sin6_addr,
> inet6_sk(&sk->inet.sk)->srcprefs,
> &saddr->v6.sin6_addr);
I think this needs to use sock_net(sctp_opt2s(sk)) instead of NULL.
-vlad
WARNING: multiple messages have this Message-ID (diff)
From: Vlad Yasevich <vladislav.yasevich@hp.com>
To: Brian Haley <brian.haley@hp.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, containers <containers@lists.osdl.org>,
linux-sctp@vger.kernel.org
Subject: Re: [PATCH 2/2] netns: Add network namespace argument in rt6_fill_node()
Date: Thu, 14 Aug 2008 20:04:25 +0000 [thread overview]
Message-ID: <48A48FC9.4020805@hp.com> (raw)
In-Reply-To: <48A48722.3050509@hp.com>
Hi Brian
Brian Haley wrote:
> ---
>
> diff --git a/net/sctp/ipv6.c b/net/sctp/ipv6.c
> index 483a01d..e0945d4 100644
> --- a/net/sctp/ipv6.c
> +++ b/net/sctp/ipv6.c
> @@ -319,7 +319,8 @@ static void sctp_v6_get_saddr(struct sctp_sock *sk,
> __func__, asoc, dst, NIP6(daddr->v6.sin6_addr));
>
> if (!asoc) {
> - ipv6_dev_get_saddr(dst ? ip6_dst_idev(dst)->dev : NULL,
> + ipv6_dev_get_saddr(NULL,
> + dst ? ip6_dst_idev(dst)->dev : NULL,
> &daddr->v6.sin6_addr,
> inet6_sk(&sk->inet.sk)->srcprefs,
> &saddr->v6.sin6_addr);
I think this needs to use sock_net(sctp_opt2s(sk)) instead of NULL.
-vlad
next prev parent reply other threads:[~2008-08-14 20:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-14 19:27 [PATCH 2/2] netns: Add network namespace argument in rt6_fill_node() and ipv6_dev_get_saddr() Brian Haley
2008-08-14 19:27 ` [PATCH 2/2] netns: Add network namespace argument in rt6_fill_node() Brian Haley
2008-08-14 20:04 ` Vlad Yasevich [this message]
2008-08-14 20:04 ` Vlad Yasevich
2008-08-14 20:16 ` [PATCH 2/2] netns: Add network namespace argument in rt6_fill_node() and ipv6_dev_get_saddr() Brian Haley
2008-08-14 20:16 ` [PATCH 2/2] netns: Add network namespace argument in rt6_fill_node() Brian Haley
2008-08-14 20:29 ` [PATCH 2/2] netns: Add network namespace argument in rt6_fill_node() and ipv6_dev_get_saddr() Vlad Yasevich
2008-08-14 20:29 ` [PATCH 2/2] netns: Add network namespace argument in rt6_fill_node() Vlad Yasevich
2008-08-14 20:18 ` [PATCH 2/2] netns: Add network namespace argument in rt6_fill_node() and ipv6_dev_get_saddr() Denis V. Lunev
2008-08-14 20:18 ` [PATCH 2/2] netns: Add network namespace argument in Denis V. Lunev
2008-08-16 22:47 ` [PATCH 2/2] netns: Add network namespace argument in rt6_fill_node() and ipv6_dev_get_saddr() Daniel Lezcano
2008-08-16 22:47 ` [PATCH 2/2] netns: Add network namespace argument in rt6_fill_node() Daniel Lezcano
2008-08-17 22:35 ` [PATCH 2/2] netns: Add network namespace argument in rt6_fill_node() and ipv6_dev_get_saddr() David Miller
2008-08-17 22:35 ` [PATCH 2/2] netns: Add network namespace argument in David Miller
[not found] ` <20080817.153526.109132408.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-08-18 7:21 ` [PATCH 2/2] netns: Add network namespace argument in rt6_fill_node() and ipv6_dev_get_saddr() Daniel Lezcano
2008-08-18 7:21 ` [PATCH 2/2] netns: Add network namespace argument in rt6_fill_node() Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A48FC9.4020805@hp.com \
--to=vladislav.yasevich@hp.com \
--cc=brian.haley@hp.com \
--cc=containers@lists.osdl.org \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.