From: Daniel Lezcano <dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
brian.haley-VXdhtT5mjnY@public.gmane.org
Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sctp-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] netns: Add network namespace argument in rt6_fill_node() and ipv6_dev_get_saddr()
Date: Mon, 18 Aug 2008 09:21:08 +0200 [thread overview]
Message-ID: <48A922E4.1050304@fr.ibm.com> (raw)
In-Reply-To: <20080817.153526.109132408.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
David Miller wrote:
> From: Daniel Lezcano <dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
> Date: Sun, 17 Aug 2008 00:47:12 +0200
>
>> The approach looks correct except with the network namespace passed as
>> parameter, it must never be NULL.
>
> You're reviewing the patches that Brian retracted, we added a different
> version of these fixes in the end.
Yes thanks, I received the emails delayed, so I saw the first version
and no reply to them, neither the V2.
The second version is much better.
Thanks Brian for fixing this :)
-- Daniel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <dlezcano@fr.ibm.com>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
brian.haley-VXdhtT5mjnY@public.gmane.org
Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sctp-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] netns: Add network namespace argument in rt6_fill_node()
Date: Mon, 18 Aug 2008 07:21:08 +0000 [thread overview]
Message-ID: <48A922E4.1050304@fr.ibm.com> (raw)
In-Reply-To: <20080817.153526.109132408.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
David Miller wrote:
> From: Daniel Lezcano <dlezcano@fr.ibm.com>
> Date: Sun, 17 Aug 2008 00:47:12 +0200
>
>> The approach looks correct except with the network namespace passed as
>> parameter, it must never be NULL.
>
> You're reviewing the patches that Brian retracted, we added a different
> version of these fixes in the end.
Yes thanks, I received the emails delayed, so I saw the first version
and no reply to them, neither the V2.
The second version is much better.
Thanks Brian for fixing this :)
-- Daniel
next prev parent reply other threads:[~2008-08-18 7:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-14 19:27 [PATCH 2/2] netns: Add network namespace argument in rt6_fill_node() and ipv6_dev_get_saddr() Brian Haley
2008-08-14 19:27 ` [PATCH 2/2] netns: Add network namespace argument in rt6_fill_node() Brian Haley
2008-08-14 20:04 ` [PATCH 2/2] netns: Add network namespace argument in rt6_fill_node() and ipv6_dev_get_saddr() Vlad Yasevich
2008-08-14 20:04 ` [PATCH 2/2] netns: Add network namespace argument in rt6_fill_node() Vlad Yasevich
2008-08-14 20:16 ` [PATCH 2/2] netns: Add network namespace argument in rt6_fill_node() and ipv6_dev_get_saddr() Brian Haley
2008-08-14 20:16 ` [PATCH 2/2] netns: Add network namespace argument in rt6_fill_node() Brian Haley
2008-08-14 20:29 ` [PATCH 2/2] netns: Add network namespace argument in rt6_fill_node() and ipv6_dev_get_saddr() Vlad Yasevich
2008-08-14 20:29 ` [PATCH 2/2] netns: Add network namespace argument in rt6_fill_node() Vlad Yasevich
2008-08-14 20:18 ` [PATCH 2/2] netns: Add network namespace argument in rt6_fill_node() and ipv6_dev_get_saddr() Denis V. Lunev
2008-08-14 20:18 ` [PATCH 2/2] netns: Add network namespace argument in Denis V. Lunev
2008-08-16 22:47 ` [PATCH 2/2] netns: Add network namespace argument in rt6_fill_node() and ipv6_dev_get_saddr() Daniel Lezcano
2008-08-16 22:47 ` [PATCH 2/2] netns: Add network namespace argument in rt6_fill_node() Daniel Lezcano
2008-08-17 22:35 ` [PATCH 2/2] netns: Add network namespace argument in rt6_fill_node() and ipv6_dev_get_saddr() David Miller
2008-08-17 22:35 ` [PATCH 2/2] netns: Add network namespace argument in David Miller
[not found] ` <20080817.153526.109132408.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-08-18 7:21 ` Daniel Lezcano [this message]
2008-08-18 7:21 ` [PATCH 2/2] netns: Add network namespace argument in rt6_fill_node() Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A922E4.1050304@fr.ibm.com \
--to=dlezcano-nmtc/0zbporqt0dzr+alfa@public.gmane.org \
--cc=brian.haley-VXdhtT5mjnY@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=linux-sctp-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.