From: Phillip Lougher <phillip@lougher.demon.co.uk>
To: Jared Hulbert <jaredeh@gmail.com>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
Linux-kernel@vger.kernel.org, linux-embedded@vger.kernel.org,
linux-mtd <linux-mtd@lists.infradead.org>,
"Jörn Engel" <joern@logfs.org>,
tim.bird@am.sony.com, cotte@de.ibm.com, nickpiggin@yahoo.com.au
Subject: Re: [PATCH 04/10] AXFS: axfs_inode.c
Date: Fri, 22 Aug 2008 04:29:50 +0100 [thread overview]
Message-ID: <48AE32AE.9010901@lougher.demon.co.uk> (raw)
In-Reply-To: <6934efce0808212023x758babf0w500da6801bd66f45@mail.gmail.com>
Jared Hulbert wrote:
>
> The memcpy in question copies a c_node to the page. The len is either
> the max length of a c_node and size of the buffer I'm copying to
> (PAGE_CACHE_SIZE) or it is the difference between the beginning of the
> c_node in the c_block and the end of the c_block, whichever is
> smaller. The confusion is probably because of the fact that this
> copies extra crap to the page for tails.
Ah yes, that's where I got confused :) Glad to see AXFS uses tail packing.
Phillip
WARNING: multiple messages have this Message-ID (diff)
From: Phillip Lougher <phillip@lougher.demon.co.uk>
To: Jared Hulbert <jaredeh@gmail.com>
Cc: cotte@de.ibm.com, "Arnd Bergmann" <arnd@arndb.de>,
linux-embedded@vger.kernel.org, nickpiggin@yahoo.com.au,
"Jörn Engel" <joern@logfs.org>,
Linux-kernel@vger.kernel.org,
linux-mtd <linux-mtd@lists.infradead.org>,
tim.bird@am.sony.com
Subject: Re: [PATCH 04/10] AXFS: axfs_inode.c
Date: Fri, 22 Aug 2008 04:29:50 +0100 [thread overview]
Message-ID: <48AE32AE.9010901@lougher.demon.co.uk> (raw)
In-Reply-To: <6934efce0808212023x758babf0w500da6801bd66f45@mail.gmail.com>
Jared Hulbert wrote:
>
> The memcpy in question copies a c_node to the page. The len is either
> the max length of a c_node and size of the buffer I'm copying to
> (PAGE_CACHE_SIZE) or it is the difference between the beginning of the
> c_node in the c_block and the end of the c_block, whichever is
> smaller. The confusion is probably because of the fact that this
> copies extra crap to the page for tails.
Ah yes, that's where I got confused :) Glad to see AXFS uses tail packing.
Phillip
next prev parent reply other threads:[~2008-08-22 3:29 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 5:45 [PATCH 04/10] AXFS: axfs_inode.c Jared Hulbert
2008-08-21 5:45 ` Jared Hulbert
2008-08-21 8:35 ` Carsten Otte
2008-08-21 8:35 ` Carsten Otte
2008-08-21 11:35 ` Arnd Bergmann
2008-08-21 11:35 ` Arnd Bergmann
2008-08-21 12:17 ` Arnd Bergmann
2008-08-21 12:17 ` Arnd Bergmann
2008-08-21 12:17 ` Arnd Bergmann
2008-08-21 15:06 ` Jared Hulbert
2008-08-21 15:06 ` Jared Hulbert
2008-08-21 15:12 ` Arnd Bergmann
2008-08-21 15:12 ` Arnd Bergmann
2008-08-21 15:12 ` Arnd Bergmann
2008-08-22 2:22 ` Phillip Lougher
2008-08-22 2:22 ` Phillip Lougher
2008-08-22 3:23 ` Jared Hulbert
2008-08-22 3:23 ` Jared Hulbert
2008-08-22 3:29 ` Phillip Lougher [this message]
2008-08-22 3:29 ` Phillip Lougher
2008-08-22 10:00 ` Arnd Bergmann
2008-08-22 10:00 ` Arnd Bergmann
2008-08-22 17:08 ` Phillip Lougher
2008-08-22 17:08 ` Phillip Lougher
2008-08-22 17:19 ` Jörn Engel
2008-08-22 17:19 ` Jörn Engel
2008-08-22 17:19 ` Jörn Engel
2008-08-22 18:04 ` Jared Hulbert
2008-08-22 18:04 ` Jared Hulbert
2008-08-22 0:21 ` Phillip Lougher
2008-08-22 0:21 ` Phillip Lougher
2008-08-22 0:21 ` Phillip Lougher
2008-08-22 3:27 ` Jared Hulbert
2008-08-22 3:27 ` Jared Hulbert
2008-08-22 3:46 ` Phillip Lougher
2008-08-22 3:46 ` Phillip Lougher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48AE32AE.9010901@lougher.demon.co.uk \
--to=phillip@lougher.demon.co.uk \
--cc=Linux-kernel@vger.kernel.org \
--cc=arnd@arndb.de \
--cc=cotte@de.ibm.com \
--cc=jaredeh@gmail.com \
--cc=joern@logfs.org \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nickpiggin@yahoo.com.au \
--cc=tim.bird@am.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.