* [Qemu-devel] [PATCH 3/3] [x86] SYSENTER/SYSEXIT IA-32e implementation v3
@ 2008-08-22 13:39 Alexander Graf
2008-08-22 17:24 ` Anthony Liguori
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Graf @ 2008-08-22 13:39 UTC (permalink / raw)
To: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 251 bytes --]
On Intel CPUs, sysenter and sysexit are valid in 64-bit mode. This patch
makes both 64-bit aware and enables them for Intel CPUs.
Changes since v1: Add cpu save/load for 64-bit wide sysenter variables
Signed-off-by: Alexander Graf <agraf@suse.de>
[-- Attachment #2: se03-ia32e-sysenter.patch --]
[-- Type: text/x-patch, Size: 8082 bytes --]
Index: qemu/target-i386/cpu.h
===================================================================
--- qemu.orig/target-i386/cpu.h
+++ qemu/target-i386/cpu.h
@@ -549,8 +549,8 @@ typedef struct CPUX86State {
/* sysenter registers */
uint32_t sysenter_cs;
- uint32_t sysenter_esp;
- uint32_t sysenter_eip;
+ target_ulong sysenter_esp;
+ target_ulong sysenter_eip;
uint64_t efer;
uint64_t star;
@@ -737,7 +737,7 @@ static inline int cpu_get_time_fast(void
#define cpu_signal_handler cpu_x86_signal_handler
#define cpu_list x86_cpu_list
-#define CPU_SAVE_VERSION 6
+#define CPU_SAVE_VERSION 7
/* MMU modes definitions */
#define MMU_MODE0_SUFFIX _kernel
Index: qemu/target-i386/helper.h
===================================================================
--- qemu.orig/target-i386/helper.h
+++ qemu/target-i386/helper.h
@@ -55,7 +55,7 @@ DEF_HELPER(void, helper_enter_level, (in
DEF_HELPER(void, helper_enter64_level, (int level, int data64, target_ulong t1))
#endif
DEF_HELPER(void, helper_sysenter, (void))
-DEF_HELPER(void, helper_sysexit, (void))
+DEF_HELPER(void, helper_sysexit, (int dflag))
#ifdef TARGET_X86_64
DEF_HELPER(void, helper_syscall, (int next_eip_addend))
DEF_HELPER(void, helper_sysret, (int dflag))
Index: qemu/target-i386/op_helper.c
===================================================================
--- qemu.orig/target-i386/op_helper.c
+++ qemu/target-i386/op_helper.c
@@ -2915,11 +2915,23 @@ void helper_sysenter(void)
}
env->eflags &= ~(VM_MASK | IF_MASK | RF_MASK);
cpu_x86_set_cpl(env, 0);
- cpu_x86_load_seg_cache(env, R_CS, env->sysenter_cs & 0xfffc,
- 0, 0xffffffff,
- DESC_G_MASK | DESC_B_MASK | DESC_P_MASK |
- DESC_S_MASK |
- DESC_CS_MASK | DESC_R_MASK | DESC_A_MASK);
+
+#ifdef TARGET_X86_64
+ if (env->hflags & HF_LMA_MASK) {
+ cpu_x86_load_seg_cache(env, R_CS, env->sysenter_cs & 0xfffc,
+ 0, 0xffffffff,
+ DESC_G_MASK | DESC_B_MASK | DESC_P_MASK |
+ DESC_S_MASK |
+ DESC_CS_MASK | DESC_R_MASK | DESC_A_MASK | DESC_L_MASK);
+ } else
+#endif
+ {
+ cpu_x86_load_seg_cache(env, R_CS, env->sysenter_cs & 0xfffc,
+ 0, 0xffffffff,
+ DESC_G_MASK | DESC_B_MASK | DESC_P_MASK |
+ DESC_S_MASK |
+ DESC_CS_MASK | DESC_R_MASK | DESC_A_MASK);
+ }
cpu_x86_load_seg_cache(env, R_SS, (env->sysenter_cs + 8) & 0xfffc,
0, 0xffffffff,
DESC_G_MASK | DESC_B_MASK | DESC_P_MASK |
@@ -2929,7 +2941,7 @@ void helper_sysenter(void)
EIP = env->sysenter_eip;
}
-void helper_sysexit(void)
+void helper_sysexit(int dflag)
{
int cpl;
@@ -2938,16 +2950,32 @@ void helper_sysexit(void)
raise_exception_err(EXCP0D_GPF, 0);
}
cpu_x86_set_cpl(env, 3);
- cpu_x86_load_seg_cache(env, R_CS, ((env->sysenter_cs + 16) & 0xfffc) | 3,
- 0, 0xffffffff,
- DESC_G_MASK | DESC_B_MASK | DESC_P_MASK |
- DESC_S_MASK | (3 << DESC_DPL_SHIFT) |
- DESC_CS_MASK | DESC_R_MASK | DESC_A_MASK);
- cpu_x86_load_seg_cache(env, R_SS, ((env->sysenter_cs + 24) & 0xfffc) | 3,
- 0, 0xffffffff,
- DESC_G_MASK | DESC_B_MASK | DESC_P_MASK |
- DESC_S_MASK | (3 << DESC_DPL_SHIFT) |
- DESC_W_MASK | DESC_A_MASK);
+#ifdef TARGET_X86_64
+ if (dflag == 2) {
+ cpu_x86_load_seg_cache(env, R_CS, ((env->sysenter_cs + 32) & 0xfffc) | 3,
+ 0, 0xffffffff,
+ DESC_G_MASK | DESC_B_MASK | DESC_P_MASK |
+ DESC_S_MASK | (3 << DESC_DPL_SHIFT) |
+ DESC_CS_MASK | DESC_R_MASK | DESC_A_MASK | DESC_L_MASK);
+ cpu_x86_load_seg_cache(env, R_SS, ((env->sysenter_cs + 40) & 0xfffc) | 3,
+ 0, 0xffffffff,
+ DESC_G_MASK | DESC_B_MASK | DESC_P_MASK |
+ DESC_S_MASK | (3 << DESC_DPL_SHIFT) |
+ DESC_W_MASK | DESC_A_MASK);
+ } else
+#endif
+ {
+ cpu_x86_load_seg_cache(env, R_CS, ((env->sysenter_cs + 16) & 0xfffc) | 3,
+ 0, 0xffffffff,
+ DESC_G_MASK | DESC_B_MASK | DESC_P_MASK |
+ DESC_S_MASK | (3 << DESC_DPL_SHIFT) |
+ DESC_CS_MASK | DESC_R_MASK | DESC_A_MASK);
+ cpu_x86_load_seg_cache(env, R_SS, ((env->sysenter_cs + 24) & 0xfffc) | 3,
+ 0, 0xffffffff,
+ DESC_G_MASK | DESC_B_MASK | DESC_P_MASK |
+ DESC_S_MASK | (3 << DESC_DPL_SHIFT) |
+ DESC_W_MASK | DESC_A_MASK);
+ }
ESP = ECX;
EIP = EDX;
#ifdef USE_KQEMU
Index: qemu/target-i386/translate.c
===================================================================
--- qemu.orig/target-i386/translate.c
+++ qemu/target-i386/translate.c
@@ -6401,7 +6401,8 @@ static target_ulong disas_insn(DisasCont
tcg_gen_helper_0_0(helper_rdpmc);
break;
case 0x134: /* sysenter */
- if (CODE64(s))
+ /* For Intel SYSENTER is valid on 64-bit */
+ if (CODE64(s) && cpu_single_env->cpuid_vendor1 != CPUID_VENDOR_INTEL_1)
goto illegal_op;
if (!s->pe) {
gen_exception(s, EXCP0D_GPF, pc_start - s->cs_base);
@@ -6416,7 +6417,8 @@ static target_ulong disas_insn(DisasCont
}
break;
case 0x135: /* sysexit */
- if (CODE64(s))
+ /* For Intel SYSEXIT is valid on 64-bit */
+ if (CODE64(s) && cpu_single_env->cpuid_vendor1 != CPUID_VENDOR_INTEL_1)
goto illegal_op;
if (!s->pe) {
gen_exception(s, EXCP0D_GPF, pc_start - s->cs_base);
@@ -6426,7 +6428,7 @@ static target_ulong disas_insn(DisasCont
s->cc_op = CC_OP_DYNAMIC;
}
gen_jmp_im(pc_start - s->cs_base);
- tcg_gen_helper_0_0(helper_sysexit);
+ tcg_gen_helper_0_1(helper_sysexit, tcg_const_i32(dflag));
gen_eob(s);
}
break;
Index: qemu/target-i386/machine.c
===================================================================
--- qemu.orig/target-i386/machine.c
+++ qemu/target-i386/machine.c
@@ -88,9 +88,9 @@ void cpu_save(QEMUFile *f, void *opaque)
cpu_put_seg(f, &env->gdt);
cpu_put_seg(f, &env->idt);
- qemu_put_be32s(f, &env->sysenter_cs);
- qemu_put_be32s(f, &env->sysenter_esp);
- qemu_put_be32s(f, &env->sysenter_eip);
+ qemu_put_bels(f, &env->sysenter_cs);
+ qemu_put_bels(f, &env->sysenter_esp);
+ qemu_put_bels(f, &env->sysenter_eip);
qemu_put_betls(f, &env->cr[0]);
qemu_put_betls(f, &env->cr[2]);
@@ -169,7 +169,7 @@ int cpu_load(QEMUFile *f, void *opaque,
int32_t a20_mask;
if (version_id != 3 && version_id != 4 && version_id != 5
- && version_id != 6)
+ && version_id != 6 && version_id != 7)
return -EINVAL;
for(i = 0; i < CPU_NB_REGS; i++)
qemu_get_betls(f, &env->regs[i]);
@@ -244,8 +244,13 @@ int cpu_load(QEMUFile *f, void *opaque,
cpu_get_seg(f, &env->idt);
qemu_get_be32s(f, &env->sysenter_cs);
- qemu_get_be32s(f, &env->sysenter_esp);
- qemu_get_be32s(f, &env->sysenter_eip);
+ if (version_id >= 7) {
+ qemu_get_bels(f, &env->sysenter_esp);
+ qemu_get_bels(f, &env->sysenter_eip);
+ } else {
+ qemu_get_be32s(f, &env->sysenter_esp);
+ qemu_get_be32s(f, &env->sysenter_eip);
+ }
qemu_get_betls(f, &env->cr[0]);
qemu_get_betls(f, &env->cr[2]);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH 3/3] [x86] SYSENTER/SYSEXIT IA-32e implementation v3
2008-08-22 13:39 [Qemu-devel] [PATCH 3/3] [x86] SYSENTER/SYSEXIT IA-32e implementation v3 Alexander Graf
@ 2008-08-22 17:24 ` Anthony Liguori
2008-08-22 17:33 ` Alexander Graf
0 siblings, 1 reply; 3+ messages in thread
From: Anthony Liguori @ 2008-08-22 17:24 UTC (permalink / raw)
To: qemu-devel
Alexander Graf wrote:
> On Intel CPUs, sysenter and sysexit are valid in 64-bit mode. This patch
> makes both 64-bit aware and enables them for Intel CPUs.
>
> Changes since v1: Add cpu save/load for 64-bit wide sysenter variables
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
>
>
> Index: qemu/target-i386/machine.c
> ===================================================================
> --- qemu.orig/target-i386/machine.c
> +++ qemu/target-i386/machine.c
> @@ -88,9 +88,9 @@ void cpu_save(QEMUFile *f, void *opaque)
> cpu_put_seg(f, &env->gdt);
> cpu_put_seg(f, &env->idt);
>
> - qemu_put_be32s(f, &env->sysenter_cs);
> - qemu_put_be32s(f, &env->sysenter_esp);
> - qemu_put_be32s(f, &env->sysenter_eip);
> + qemu_put_bels(f, &env->sysenter_cs);
> + qemu_put_bels(f, &env->sysenter_esp);
> + qemu_put_bels(f, &env->sysenter_eip);
What exactly is be1s? Don't you mean be64s?
>
> qemu_put_betls(f, &env->cr[0]);
> qemu_put_betls(f, &env->cr[2]);
> @@ -169,7 +169,7 @@ int cpu_load(QEMUFile *f, void *opaque,
> int32_t a20_mask;
>
> if (version_id != 3 && version_id != 4 && version_id != 5
> - && version_id != 6)
> + && version_id != 6 && version_id != 7)
> return -EINVAL;
> for(i = 0; i < CPU_NB_REGS; i++)
> qemu_get_betls(f, &env->regs[i]);
> @@ -244,8 +244,13 @@ int cpu_load(QEMUFile *f, void *opaque,
> cpu_get_seg(f, &env->idt);
>
> qemu_get_be32s(f, &env->sysenter_cs);
> - qemu_get_be32s(f, &env->sysenter_esp);
> - qemu_get_be32s(f, &env->sysenter_eip);
> + if (version_id >= 7) {
> + qemu_get_bels(f, &env->sysenter_esp);
> + qemu_get_bels(f, &env->sysenter_eip);
>
Same here. This doesn't compile, does it?
> + } else {
> + qemu_get_be32s(f, &env->sysenter_esp);
> + qemu_get_be32s(f, &env->sysenter_eip);
> + }
>
> qemu_get_betls(f, &env->cr[0]);
> qemu_get_betls(f, &env->cr[2]);
Regards,
Anthony Liguori
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH 3/3] [x86] SYSENTER/SYSEXIT IA-32e implementation v3
2008-08-22 17:24 ` Anthony Liguori
@ 2008-08-22 17:33 ` Alexander Graf
0 siblings, 0 replies; 3+ messages in thread
From: Alexander Graf @ 2008-08-22 17:33 UTC (permalink / raw)
To: qemu-devel
On Aug 22, 2008, at 7:24 PM, Anthony Liguori wrote:
> Alexander Graf wrote:
>> On Intel CPUs, sysenter and sysexit are valid in 64-bit mode. This
>> patch
>> makes both 64-bit aware and enables them for Intel CPUs.
>>
>> Changes since v1: Add cpu save/load for 64-bit wide sysenter
>> variables
>>
>> Signed-off-by: Alexander Graf <agraf@suse.de>
>>
>>
>> Index: qemu/target-i386/machine.c
>> ===================================================================
>> --- qemu.orig/target-i386/machine.c
>> +++ qemu/target-i386/machine.c
>> @@ -88,9 +88,9 @@ void cpu_save(QEMUFile *f, void *opaque)
>> cpu_put_seg(f, &env->gdt);
>> cpu_put_seg(f, &env->idt);
>> - qemu_put_be32s(f, &env->sysenter_cs);
>> - qemu_put_be32s(f, &env->sysenter_esp);
>> - qemu_put_be32s(f, &env->sysenter_eip);
>> + qemu_put_bels(f, &env->sysenter_cs);
>> + qemu_put_bels(f, &env->sysenter_esp);
>> + qemu_put_bels(f, &env->sysenter_eip);
>
> What exactly is be1s? Don't you mean be64s?
Oh my god you are so right. Now that's embarrassing. Of course I meant
betls.
>> qemu_put_betls(f, &env->cr[0]);
>> qemu_put_betls(f, &env->cr[2]);
>> @@ -169,7 +169,7 @@ int cpu_load(QEMUFile *f, void *opaque,
>> int32_t a20_mask;
>> if (version_id != 3 && version_id != 4 && version_id != 5
>> - && version_id != 6)
>> + && version_id != 6 && version_id != 7)
>> return -EINVAL;
>> for(i = 0; i < CPU_NB_REGS; i++)
>> qemu_get_betls(f, &env->regs[i]);
>> @@ -244,8 +244,13 @@ int cpu_load(QEMUFile *f, void *opaque,
>> cpu_get_seg(f, &env->idt);
>> qemu_get_be32s(f, &env->sysenter_cs);
>> - qemu_get_be32s(f, &env->sysenter_esp);
>> - qemu_get_be32s(f, &env->sysenter_eip);
>> + if (version_id >= 7) {
>> + qemu_get_bels(f, &env->sysenter_esp);
>> + qemu_get_bels(f, &env->sysenter_eip);
>>
>
> Same here. This doesn't compile, does it?
No, it doesn't. I'm really sorry about that. I'll send a new series
right away.
Alex
>
>
>> + } else {
>> + qemu_get_be32s(f, &env->sysenter_esp);
>> + qemu_get_be32s(f, &env->sysenter_eip);
>> + }
>> qemu_get_betls(f, &env->cr[0]);
>> qemu_get_betls(f, &env->cr[2]);
>
> Regards,
>
> Anthony Liguori
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-08-22 17:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-22 13:39 [Qemu-devel] [PATCH 3/3] [x86] SYSENTER/SYSEXIT IA-32e implementation v3 Alexander Graf
2008-08-22 17:24 ` Anthony Liguori
2008-08-22 17:33 ` Alexander Graf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.