All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Hofman <pavel.hofman@insite.cz>
To: Takashi Iwai <tiwai@suse.de>
Cc: Peer Chen <pchen@nvidia.com>, Wei Ni <wni@nvidia.com>,
	alsa-devel <alsa-devel@alsa-project.org>,
	akpm <akpm@linux-foundation.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] add the nvidia HDMI codec driver for	MCP77/79
Date: Wed, 03 Sep 2008 14:11:16 +0200	[thread overview]
Message-ID: <48BE7EE4.8020800@insite.cz> (raw)
In-Reply-To: <s5h4p4xph6x.wl%tiwai@suse.de>


>> ......
>> According to these codes, It only can get the realtek codec and can not
>> get hdmi codec, if just change azx_max_codecs[AZX_DRIVER_NVIDIA] to 4
>> I think if remove "if (!audio_codecs)", it will be better, and I only
>> need to chang azx_max_codecs[AZX_DRIVER_NVIDIA] to 4
> 
> Well, the check is there for a good reason.
> 
> There are many machines with broken BIOS reporting the 4th slot
> available although it isn't actually.  It's a workaround to skip such
> a bogus information.  So, it cannot be changed so easily.
> 
> We need to sort out this in a better way...  Oh well.


Please, please, put the above information as a comment to the respective 
place. These "hacks" should be commented :)

Thanks a lot,

Pavel.

WARNING: multiple messages have this Message-ID (diff)
From: Pavel Hofman <pavel.hofman@insite.cz>
To: Takashi Iwai <tiwai@suse.de>
Cc: Wei Ni <wni@nvidia.com>, Peer Chen <pchen@nvidia.com>,
	alsa-devel <alsa-devel@alsa-project.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	akpm <akpm@linux-foundation.org>
Subject: Re: [alsa-devel] [PATCH] add the nvidia HDMI codec driver for	MCP77/79
Date: Wed, 03 Sep 2008 14:11:16 +0200	[thread overview]
Message-ID: <48BE7EE4.8020800@insite.cz> (raw)
In-Reply-To: <s5h4p4xph6x.wl%tiwai@suse.de>


>> ......
>> According to these codes, It only can get the realtek codec and can not
>> get hdmi codec, if just change azx_max_codecs[AZX_DRIVER_NVIDIA] to 4
>> I think if remove "if (!audio_codecs)", it will be better, and I only
>> need to chang azx_max_codecs[AZX_DRIVER_NVIDIA] to 4
> 
> Well, the check is there for a good reason.
> 
> There are many machines with broken BIOS reporting the 4th slot
> available although it isn't actually.  It's a workaround to skip such
> a bogus information.  So, it cannot be changed so easily.
> 
> We need to sort out this in a better way...  Oh well.


Please, please, put the above information as a comment to the respective 
place. These "hacks" should be commented :)

Thanks a lot,

Pavel.


  reply	other threads:[~2008-09-04  6:32 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-03  7:58 [alsa-devel][PATCH] add the nvidia HDMI codec driver for MCP77/79 peerchen
2008-09-03  8:51 ` [PATCH] " Takashi Iwai
2008-09-03  8:51   ` [alsa-devel][PATCH] " Takashi Iwai
2008-09-03 11:05   ` Wei Ni
2008-09-03 12:06     ` [PATCH] " Takashi Iwai
2008-09-03 12:06       ` [alsa-devel][PATCH] " Takashi Iwai
2008-09-03 12:11       ` Pavel Hofman [this message]
2008-09-03 12:11         ` [alsa-devel] [PATCH] " Pavel Hofman
2008-09-04  7:04         ` Takashi Iwai
2008-09-05  8:28           ` Wei Ni
2008-09-17  9:00             ` Re: [alsa-devel] [PATCH] add the nvidia HDMI codec driverfor MCP77/79 peerchen
2008-09-17 14:04               ` Takashi Iwai
2008-09-17 14:04                 ` [alsa-devel] " Takashi Iwai
2008-09-19  4:42                 ` Wei Ni
2008-09-19  4:42                   ` [alsa-devel] " Wei Ni
2008-09-22  6:33                 ` Wei Ni
2008-09-22  6:33                   ` [alsa-devel] " Wei Ni
2008-09-22  9:58                   ` Takashi Iwai
2008-09-22  9:58                     ` [alsa-devel] " Takashi Iwai
2008-09-25  7:14                     ` Wei Ni
2008-09-25  7:14                       ` [alsa-devel] " Wei Ni
2008-09-25  9:55                       ` Takashi Iwai
2008-09-25  9:55                         ` [alsa-devel] " Takashi Iwai
2008-09-25 11:29                         ` Wei Ni
2008-09-25 11:29                           ` [alsa-devel] " Wei Ni
2008-09-26 10:22                           ` Pawel Krzesniak
2008-09-26 10:30                             ` Takashi Iwai
2008-09-26  6:19                         ` Wei Ni
2008-09-26  6:19                           ` [alsa-devel] " Wei Ni
2008-09-26  8:40                           ` Takashi Iwai
2008-09-26  8:40                             ` [alsa-devel] " Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48BE7EE4.8020800@insite.cz \
    --to=pavel.hofman@insite.cz \
    --cc=akpm@linux-foundation.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pchen@nvidia.com \
    --cc=tiwai@suse.de \
    --cc=wni@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.