* [lm-sensors] [patch 2.6.27-rc6 2/6] hwmon/pc87360 separate sysfs
@ 2008-09-10 9:33 Jim Cromie
2008-09-10 9:47 ` [lm-sensors] [patch 2.6.27-rc6 2/6] hwmon/pc87360 separate Jim Cromie
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Jim Cromie @ 2008-09-10 9:33 UTC (permalink / raw)
To: lm-sensors
inlined & attached
From 92e4abc519b51ed3c80ec69854bdb6fc35c41e4b Mon Sep 17 00:00:00 2001
From: Jim Cromie <jim.cromie@gmail.com>
Date: Sat, 28 Jun 2008 12:25:52 -0600
Subject: [PATCH] hwmon/pc87360 separate alarm files - add in-min/max-alarms
Adds vin-min/max-alarm callbacks, sensor-device-attribute
declarations, and refs to those new decls in the macro used to
initialize the vin_group (of sysfs files)
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
drivers/hwmon/pc87360.c | 52
++++++++++++++++++++++++++++++++++++++++++++++-
1 files changed, 51 insertions(+), 1 deletions(-)
diff --git a/drivers/hwmon/pc87360.c b/drivers/hwmon/pc87360.c
index 1043b11..3b6ea7b 100644
--- a/drivers/hwmon/pc87360.c
+++ b/drivers/hwmon/pc87360.c
@@ -494,11 +494,61 @@ static struct sensor_device_attribute in_max[] = {
#define CHAN_ALM_MAX 0x04 /* max limit exceeded */
#define TEMP_ALM_CRIT 0x08 /* temp crit exceeded (temp only) */
+/* show_in_min/max_alarm() reads data from the per-channel status
+ register (sec 11.5.12), not the vin event status registers (sec
+ 11.5.2) that (legacy) show_in_alarm() resds (via data->in_alarms) */
+
+static ssize_t show_in_min_alarm(struct device *dev, struct
device_attribute
+ *devattr, char *buf)
+{
+ struct pc87360_data *data = pc87360_update_device(dev);
+ unsigned nr = to_sensor_dev_attr(devattr)->index;
+
+ return sprintf(buf, "%u\n", !!(data->in_status[nr] & CHAN_ALM_MIN));
+}
+static ssize_t show_in_max_alarm(struct device *dev, struct
device_attribute
+ *devattr, char *buf)
+{
+ struct pc87360_data *data = pc87360_update_device(dev);
+ unsigned nr = to_sensor_dev_attr(devattr)->index;
+
+ return sprintf(buf, "%u\n", !!(data->in_status[nr] & CHAN_ALM_MAX));
+}
+
+static struct sensor_device_attribute in_min_alarm[] = {
+ SENSOR_ATTR(in0_min_alarm, S_IRUGO, show_in_min_alarm, NULL, 0),
+ SENSOR_ATTR(in1_min_alarm, S_IRUGO, show_in_min_alarm, NULL, 1),
+ SENSOR_ATTR(in2_min_alarm, S_IRUGO, show_in_min_alarm, NULL, 2),
+ SENSOR_ATTR(in3_min_alarm, S_IRUGO, show_in_min_alarm, NULL, 3),
+ SENSOR_ATTR(in4_min_alarm, S_IRUGO, show_in_min_alarm, NULL, 4),
+ SENSOR_ATTR(in5_min_alarm, S_IRUGO, show_in_min_alarm, NULL, 5),
+ SENSOR_ATTR(in6_min_alarm, S_IRUGO, show_in_min_alarm, NULL, 6),
+ SENSOR_ATTR(in7_min_alarm, S_IRUGO, show_in_min_alarm, NULL, 7),
+ SENSOR_ATTR(in8_min_alarm, S_IRUGO, show_in_min_alarm, NULL, 8),
+ SENSOR_ATTR(in9_min_alarm, S_IRUGO, show_in_min_alarm, NULL, 9),
+ SENSOR_ATTR(in10_min_alarm, S_IRUGO, show_in_min_alarm, NULL, 10),
+};
+static struct sensor_device_attribute in_max_alarm[] = {
+ SENSOR_ATTR(in0_max_alarm, S_IRUGO, show_in_max_alarm, NULL, 0),
+ SENSOR_ATTR(in1_max_alarm, S_IRUGO, show_in_max_alarm, NULL, 1),
+ SENSOR_ATTR(in2_max_alarm, S_IRUGO, show_in_max_alarm, NULL, 2),
+ SENSOR_ATTR(in3_max_alarm, S_IRUGO, show_in_max_alarm, NULL, 3),
+ SENSOR_ATTR(in4_max_alarm, S_IRUGO, show_in_max_alarm, NULL, 4),
+ SENSOR_ATTR(in5_max_alarm, S_IRUGO, show_in_max_alarm, NULL, 5),
+ SENSOR_ATTR(in6_max_alarm, S_IRUGO, show_in_max_alarm, NULL, 6),
+ SENSOR_ATTR(in7_max_alarm, S_IRUGO, show_in_max_alarm, NULL, 7),
+ SENSOR_ATTR(in8_max_alarm, S_IRUGO, show_in_max_alarm, NULL, 8),
+ SENSOR_ATTR(in9_max_alarm, S_IRUGO, show_in_max_alarm, NULL, 9),
+ SENSOR_ATTR(in10_max_alarm, S_IRUGO, show_in_max_alarm, NULL, 10),
+};
+
#define VIN_UNIT_ATTRS(X) \
&in_input[X].dev_attr.attr, \
&in_status[X].dev_attr.attr, \
&in_min[X].dev_attr.attr, \
- &in_max[X].dev_attr.attr
+ &in_max[X].dev_attr.attr, \
+ &in_min_alarm[X].dev_attr.attr, \
+ &in_max_alarm[X].dev_attr.attr
static ssize_t show_vid(struct device *dev, struct device_attribute
*attr, char *buf)
{
--
1.5.5.1
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [lm-sensors] [patch 2.6.27-rc6 2/6] hwmon/pc87360 separate
2008-09-10 9:33 [lm-sensors] [patch 2.6.27-rc6 2/6] hwmon/pc87360 separate sysfs Jim Cromie
@ 2008-09-10 9:47 ` Jim Cromie
2008-09-11 0:03 ` Andrew Morton
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Jim Cromie @ 2008-09-10 9:47 UTC (permalink / raw)
To: lm-sensors
[-- Attachment #1: Type: text/plain, Size: 4049 bytes --]
Jim Cromie wrote:
>
> inlined & attached
>
now attached. sorry.
> From 92e4abc519b51ed3c80ec69854bdb6fc35c41e4b Mon Sep 17 00:00:00 2001
> From: Jim Cromie <jim.cromie@gmail.com>
> Date: Sat, 28 Jun 2008 12:25:52 -0600
> Subject: [PATCH] hwmon/pc87360 separate alarm files - add
> in-min/max-alarms
>
> Adds vin-min/max-alarm callbacks, sensor-device-attribute
> declarations, and refs to those new decls in the macro used to
> initialize the vin_group (of sysfs files)
>
> Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
> ---
> drivers/hwmon/pc87360.c | 52
> ++++++++++++++++++++++++++++++++++++++++++++++-
> 1 files changed, 51 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hwmon/pc87360.c b/drivers/hwmon/pc87360.c
> index 1043b11..3b6ea7b 100644
> --- a/drivers/hwmon/pc87360.c
> +++ b/drivers/hwmon/pc87360.c
> @@ -494,11 +494,61 @@ static struct sensor_device_attribute in_max[] = {
> #define CHAN_ALM_MAX 0x04 /* max limit exceeded */
> #define TEMP_ALM_CRIT 0x08 /* temp crit exceeded (temp only) */
>
> +/* show_in_min/max_alarm() reads data from the per-channel status
> + register (sec 11.5.12), not the vin event status registers (sec
> + 11.5.2) that (legacy) show_in_alarm() resds (via data->in_alarms) */
> +
> +static ssize_t show_in_min_alarm(struct device *dev, struct
> device_attribute
> + *devattr, char *buf)
> +{
> + struct pc87360_data *data = pc87360_update_device(dev);
> + unsigned nr = to_sensor_dev_attr(devattr)->index;
> +
> + return sprintf(buf, "%u\n", !!(data->in_status[nr] & CHAN_ALM_MIN));
> +}
> +static ssize_t show_in_max_alarm(struct device *dev, struct
> device_attribute
> + *devattr, char *buf)
> +{
> + struct pc87360_data *data = pc87360_update_device(dev);
> + unsigned nr = to_sensor_dev_attr(devattr)->index;
> +
> + return sprintf(buf, "%u\n", !!(data->in_status[nr] & CHAN_ALM_MAX));
> +}
> +
> +static struct sensor_device_attribute in_min_alarm[] = {
> + SENSOR_ATTR(in0_min_alarm, S_IRUGO, show_in_min_alarm, NULL, 0),
> + SENSOR_ATTR(in1_min_alarm, S_IRUGO, show_in_min_alarm, NULL, 1),
> + SENSOR_ATTR(in2_min_alarm, S_IRUGO, show_in_min_alarm, NULL, 2),
> + SENSOR_ATTR(in3_min_alarm, S_IRUGO, show_in_min_alarm, NULL, 3),
> + SENSOR_ATTR(in4_min_alarm, S_IRUGO, show_in_min_alarm, NULL, 4),
> + SENSOR_ATTR(in5_min_alarm, S_IRUGO, show_in_min_alarm, NULL, 5),
> + SENSOR_ATTR(in6_min_alarm, S_IRUGO, show_in_min_alarm, NULL, 6),
> + SENSOR_ATTR(in7_min_alarm, S_IRUGO, show_in_min_alarm, NULL, 7),
> + SENSOR_ATTR(in8_min_alarm, S_IRUGO, show_in_min_alarm, NULL, 8),
> + SENSOR_ATTR(in9_min_alarm, S_IRUGO, show_in_min_alarm, NULL, 9),
> + SENSOR_ATTR(in10_min_alarm, S_IRUGO, show_in_min_alarm, NULL, 10),
> +};
> +static struct sensor_device_attribute in_max_alarm[] = {
> + SENSOR_ATTR(in0_max_alarm, S_IRUGO, show_in_max_alarm, NULL, 0),
> + SENSOR_ATTR(in1_max_alarm, S_IRUGO, show_in_max_alarm, NULL, 1),
> + SENSOR_ATTR(in2_max_alarm, S_IRUGO, show_in_max_alarm, NULL, 2),
> + SENSOR_ATTR(in3_max_alarm, S_IRUGO, show_in_max_alarm, NULL, 3),
> + SENSOR_ATTR(in4_max_alarm, S_IRUGO, show_in_max_alarm, NULL, 4),
> + SENSOR_ATTR(in5_max_alarm, S_IRUGO, show_in_max_alarm, NULL, 5),
> + SENSOR_ATTR(in6_max_alarm, S_IRUGO, show_in_max_alarm, NULL, 6),
> + SENSOR_ATTR(in7_max_alarm, S_IRUGO, show_in_max_alarm, NULL, 7),
> + SENSOR_ATTR(in8_max_alarm, S_IRUGO, show_in_max_alarm, NULL, 8),
> + SENSOR_ATTR(in9_max_alarm, S_IRUGO, show_in_max_alarm, NULL, 9),
> + SENSOR_ATTR(in10_max_alarm, S_IRUGO, show_in_max_alarm, NULL, 10),
> +};
> +
> #define VIN_UNIT_ATTRS(X) \
> &in_input[X].dev_attr.attr, \
> &in_status[X].dev_attr.attr, \
> &in_min[X].dev_attr.attr, \
> - &in_max[X].dev_attr.attr
> + &in_max[X].dev_attr.attr, \
> + &in_min_alarm[X].dev_attr.attr, \
> + &in_max_alarm[X].dev_attr.attr
>
> static ssize_t show_vid(struct device *dev, struct device_attribute
> *attr, char *buf)
> {
[-- Attachment #2: 0002-hwmon-pc87360-separate-alarm-files-add-in-min-max.patch --]
[-- Type: text/x-patch, Size: 3685 bytes --]
From 92e4abc519b51ed3c80ec69854bdb6fc35c41e4b Mon Sep 17 00:00:00 2001
From: Jim Cromie <jim.cromie@gmail.com>
Date: Sat, 28 Jun 2008 12:25:52 -0600
Subject: [PATCH] hwmon/pc87360 separate alarm files - add in-min/max-alarms
Adds vin-min/max-alarm callbacks, sensor-device-attribute
declarations, and refs to those new decls in the macro used to
initialize the vin_group (of sysfs files)
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
drivers/hwmon/pc87360.c | 52 ++++++++++++++++++++++++++++++++++++++++++++++-
1 files changed, 51 insertions(+), 1 deletions(-)
diff --git a/drivers/hwmon/pc87360.c b/drivers/hwmon/pc87360.c
index 1043b11..3b6ea7b 100644
--- a/drivers/hwmon/pc87360.c
+++ b/drivers/hwmon/pc87360.c
@@ -494,11 +494,61 @@ static struct sensor_device_attribute in_max[] = {
#define CHAN_ALM_MAX 0x04 /* max limit exceeded */
#define TEMP_ALM_CRIT 0x08 /* temp crit exceeded (temp only) */
+/* show_in_min/max_alarm() reads data from the per-channel status
+ register (sec 11.5.12), not the vin event status registers (sec
+ 11.5.2) that (legacy) show_in_alarm() resds (via data->in_alarms) */
+
+static ssize_t show_in_min_alarm(struct device *dev, struct device_attribute
+ *devattr, char *buf)
+{
+ struct pc87360_data *data = pc87360_update_device(dev);
+ unsigned nr = to_sensor_dev_attr(devattr)->index;
+
+ return sprintf(buf, "%u\n", !!(data->in_status[nr] & CHAN_ALM_MIN));
+}
+static ssize_t show_in_max_alarm(struct device *dev, struct device_attribute
+ *devattr, char *buf)
+{
+ struct pc87360_data *data = pc87360_update_device(dev);
+ unsigned nr = to_sensor_dev_attr(devattr)->index;
+
+ return sprintf(buf, "%u\n", !!(data->in_status[nr] & CHAN_ALM_MAX));
+}
+
+static struct sensor_device_attribute in_min_alarm[] = {
+ SENSOR_ATTR(in0_min_alarm, S_IRUGO, show_in_min_alarm, NULL, 0),
+ SENSOR_ATTR(in1_min_alarm, S_IRUGO, show_in_min_alarm, NULL, 1),
+ SENSOR_ATTR(in2_min_alarm, S_IRUGO, show_in_min_alarm, NULL, 2),
+ SENSOR_ATTR(in3_min_alarm, S_IRUGO, show_in_min_alarm, NULL, 3),
+ SENSOR_ATTR(in4_min_alarm, S_IRUGO, show_in_min_alarm, NULL, 4),
+ SENSOR_ATTR(in5_min_alarm, S_IRUGO, show_in_min_alarm, NULL, 5),
+ SENSOR_ATTR(in6_min_alarm, S_IRUGO, show_in_min_alarm, NULL, 6),
+ SENSOR_ATTR(in7_min_alarm, S_IRUGO, show_in_min_alarm, NULL, 7),
+ SENSOR_ATTR(in8_min_alarm, S_IRUGO, show_in_min_alarm, NULL, 8),
+ SENSOR_ATTR(in9_min_alarm, S_IRUGO, show_in_min_alarm, NULL, 9),
+ SENSOR_ATTR(in10_min_alarm, S_IRUGO, show_in_min_alarm, NULL, 10),
+};
+static struct sensor_device_attribute in_max_alarm[] = {
+ SENSOR_ATTR(in0_max_alarm, S_IRUGO, show_in_max_alarm, NULL, 0),
+ SENSOR_ATTR(in1_max_alarm, S_IRUGO, show_in_max_alarm, NULL, 1),
+ SENSOR_ATTR(in2_max_alarm, S_IRUGO, show_in_max_alarm, NULL, 2),
+ SENSOR_ATTR(in3_max_alarm, S_IRUGO, show_in_max_alarm, NULL, 3),
+ SENSOR_ATTR(in4_max_alarm, S_IRUGO, show_in_max_alarm, NULL, 4),
+ SENSOR_ATTR(in5_max_alarm, S_IRUGO, show_in_max_alarm, NULL, 5),
+ SENSOR_ATTR(in6_max_alarm, S_IRUGO, show_in_max_alarm, NULL, 6),
+ SENSOR_ATTR(in7_max_alarm, S_IRUGO, show_in_max_alarm, NULL, 7),
+ SENSOR_ATTR(in8_max_alarm, S_IRUGO, show_in_max_alarm, NULL, 8),
+ SENSOR_ATTR(in9_max_alarm, S_IRUGO, show_in_max_alarm, NULL, 9),
+ SENSOR_ATTR(in10_max_alarm, S_IRUGO, show_in_max_alarm, NULL, 10),
+};
+
#define VIN_UNIT_ATTRS(X) \
&in_input[X].dev_attr.attr, \
&in_status[X].dev_attr.attr, \
&in_min[X].dev_attr.attr, \
- &in_max[X].dev_attr.attr
+ &in_max[X].dev_attr.attr, \
+ &in_min_alarm[X].dev_attr.attr, \
+ &in_max_alarm[X].dev_attr.attr
static ssize_t show_vid(struct device *dev, struct device_attribute *attr, char *buf)
{
--
1.5.5.1
[-- Attachment #3: Type: text/plain, Size: 153 bytes --]
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [lm-sensors] [patch 2.6.27-rc6 2/6] hwmon/pc87360 separate
2008-09-10 9:33 [lm-sensors] [patch 2.6.27-rc6 2/6] hwmon/pc87360 separate sysfs Jim Cromie
2008-09-10 9:47 ` [lm-sensors] [patch 2.6.27-rc6 2/6] hwmon/pc87360 separate Jim Cromie
@ 2008-09-11 0:03 ` Andrew Morton
2008-09-11 2:16 ` Jim Cromie
2008-09-11 2:23 ` Andrew Morton
3 siblings, 0 replies; 5+ messages in thread
From: Andrew Morton @ 2008-09-11 0:03 UTC (permalink / raw)
To: lm-sensors
On Wed, 10 Sep 2008 03:47:32 -0600
Jim Cromie <jim.cromie@gmail.com> wrote:
> +static ssize_t show_in_min_alarm(struct device *dev, struct device_attribute
> + *devattr, char *buf)
> +{
> + struct pc87360_data *data = pc87360_update_device(dev);
> + unsigned nr = to_sensor_dev_attr(devattr)->index;
> +
> + return sprintf(buf, "%u\n", !!(data->in_status[nr] & CHAN_ALM_MIN));
> +}
> +static ssize_t show_in_max_alarm(struct device *dev, struct device_attribute
> + *devattr, char *buf)
coding-style nit: it is highly unusual to put a newline between the
argument's type and its identifier.
This:
--- a/drivers/hwmon/pc87360.c~hwmon-pc87360-separate-alarm-files-add-in-min-max-alarms-cleanup
+++ a/drivers/hwmon/pc87360.c
@@ -498,16 +498,16 @@ static struct sensor_device_attribute in
register (sec 11.5.12), not the vin event status registers (sec
11.5.2) that (legacy) show_in_alarm() resds (via data->in_alarms) */
-static ssize_t show_in_min_alarm(struct device *dev, struct device_attribute
- *devattr, char *buf)
+static ssize_t show_in_min_alarm(struct device *dev,
+ struct device_attribute *devattr, char *buf)
{
struct pc87360_data *data = pc87360_update_device(dev);
unsigned nr = to_sensor_dev_attr(devattr)->index;
return sprintf(buf, "%u\n", !!(data->in_status[nr] & CHAN_ALM_MIN));
}
-static ssize_t show_in_max_alarm(struct device *dev, struct device_attribute
- *devattr, char *buf)
+static ssize_t show_in_max_alarm(struct device *dev,
+ struct device_attribute *devattr, char *buf)
{
struct pc87360_data *data = pc87360_update_device(dev);
unsigned nr = to_sensor_dev_attr(devattr)->index;
_
is not really any better-looking, but it's more conventional.
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [lm-sensors] [patch 2.6.27-rc6 2/6] hwmon/pc87360 separate
2008-09-10 9:33 [lm-sensors] [patch 2.6.27-rc6 2/6] hwmon/pc87360 separate sysfs Jim Cromie
2008-09-10 9:47 ` [lm-sensors] [patch 2.6.27-rc6 2/6] hwmon/pc87360 separate Jim Cromie
2008-09-11 0:03 ` Andrew Morton
@ 2008-09-11 2:16 ` Jim Cromie
2008-09-11 2:23 ` Andrew Morton
3 siblings, 0 replies; 5+ messages in thread
From: Jim Cromie @ 2008-09-11 2:16 UTC (permalink / raw)
To: lm-sensors
Andrew Morton wrote:
> On Wed, 10 Sep 2008 03:47:32 -0600
> Jim Cromie <jim.cromie@gmail.com> wrote:
>
>
>> +static ssize_t show_in_min_alarm(struct device *dev, struct device_attribute
>> + *devattr, char *buf)
>> +{
>> + struct pc87360_data *data = pc87360_update_device(dev);
>> + unsigned nr = to_sensor_dev_attr(devattr)->index;
>> +
>> + return sprintf(buf, "%u\n", !!(data->in_status[nr] & CHAN_ALM_MIN));
>> +}
>> +static ssize_t show_in_max_alarm(struct device *dev, struct device_attribute
>> + *devattr, char *buf)
>>
>
> coding-style nit: it is highly unusual to put a newline between the
> argument's type and its identifier.
>
>
Ack.
I chose to put as much as possible on 1 line, based upon the notion that
greps for 'struct device_attribute' would report as much useful context
as possible.
(namely that its an arg to this function, arg name is unneede in this case)
Having said that, it strikes me that 'static ssize_t' should be on a
separate line,
since C has no overloaded functions returning different types, so it
should have
said:
static ssize_t
show_in_max_alarm(struct device *dev, struct device_attribute *devattr, char *buf)
This style is already used in some hwmon drivers.
(but I could see it other ways too)
> This:
>
> --- a/drivers/hwmon/pc87360.c~hwmon-pc87360-separate-alarm-files-add-in-min-max-alarms-cleanup
> +++ a/drivers/hwmon/pc87360.c
> @@ -498,16 +498,16 @@ static struct sensor_device_attribute in
> register (sec 11.5.12), not the vin event status registers (sec
> 11.5.2) that (legacy) show_in_alarm() resds (via data->in_alarms) */
>
> -static ssize_t show_in_min_alarm(struct device *dev, struct device_attribute
> - *devattr, char *buf)
> +static ssize_t show_in_min_alarm(struct device *dev,
> + struct device_attribute *devattr, char *buf)
> {
> struct pc87360_data *data = pc87360_update_device(dev);
> unsigned nr = to_sensor_dev_attr(devattr)->index;
>
> return sprintf(buf, "%u\n", !!(data->in_status[nr] & CHAN_ALM_MIN));
> }
> -static ssize_t show_in_max_alarm(struct device *dev, struct device_attribute
> - *devattr, char *buf)
> +static ssize_t show_in_max_alarm(struct device *dev,
> + struct device_attribute *devattr, char *buf)
> {
> struct pc87360_data *data = pc87360_update_device(dev);
> unsigned nr = to_sensor_dev_attr(devattr)->index;
> _
>
> is not really any better-looking, but it's more conventional.
>
>
SO...
Im completely fine with your implied (very diplomatically) preference.
Given that youve patched this nit already, Id add it to the patchset
instead of reworking patch 2/6.
If you want to go this way, pls consider this my
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
If not, I'll reroll them.
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [lm-sensors] [patch 2.6.27-rc6 2/6] hwmon/pc87360 separate
2008-09-10 9:33 [lm-sensors] [patch 2.6.27-rc6 2/6] hwmon/pc87360 separate sysfs Jim Cromie
` (2 preceding siblings ...)
2008-09-11 2:16 ` Jim Cromie
@ 2008-09-11 2:23 ` Andrew Morton
3 siblings, 0 replies; 5+ messages in thread
From: Andrew Morton @ 2008-09-11 2:23 UTC (permalink / raw)
To: lm-sensors
On Wed, 10 Sep 2008 20:16:43 -0600 Jim Cromie <jim.cromie@gmail.com> wrote:
>
> static ssize_t
> show_in_max_alarm(struct device *dev, struct device_attribute *devattr, char *buf)
yes, that's a fairly common way of fixing a slightly-exceeds-80-cols problem.
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-09-11 2:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-10 9:33 [lm-sensors] [patch 2.6.27-rc6 2/6] hwmon/pc87360 separate sysfs Jim Cromie
2008-09-10 9:47 ` [lm-sensors] [patch 2.6.27-rc6 2/6] hwmon/pc87360 separate Jim Cromie
2008-09-11 0:03 ` Andrew Morton
2008-09-11 2:16 ` Jim Cromie
2008-09-11 2:23 ` Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.