All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: netdev@vger.kernel.org, eric.miao@marvell.com,
	luca.santini@spesonline.com, nico@cam.org,
	linux-sh@vger.kernel.org
Subject: Re: [PATCH] smc91x: SMC_IO_SHIFT platform data support for default
Date: Sat, 13 Sep 2008 19:13:04 +0000	[thread overview]
Message-ID: <48CC10C0.6040607@garzik.org> (raw)
In-Reply-To: <20080908050234.11554.10123.sendpatchset@rx1.opensource.se>

Magnus Damm wrote:
> From: Magnus Damm <damm@igel.co.jp>
> 
> Commit 159198862adad7109bb347bb30a620f67beac45f added SMC_IO_SHIFT
> platform data support. After that ARM board support was added.
> 
> The default case is still missing though, so on SuperH SMC_IO_SHIFT
> is constantly zero regardless of what you pass as platform data.
> 
> Signed-off-by: Magnus Damm <damm@igel.co.jp>
> Test-by: Luca Santini <luca.santini@spesonline.com>
> ---
> 
>  drivers/net/smc91x.h |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- 0001/drivers/net/smc91x.h
> +++ work/drivers/net/smc91x.h	2008-08-28 20:43:03.000000000 +0900
> @@ -446,6 +446,8 @@ static inline void LPD7_SMC_outsw (unsig
>  #define SMC_CAN_USE_32BIT	1
>  #define SMC_NOWAIT		1
>  
> +#define SMC_IO_SHIFT		(lp->io_shift)
> +
>  #define SMC_inb(a, r)		readb((a) + (r))
>  #define SMC_inw(a, r)		readw((a) + (r))
>  #define SMC_inl(a, r)		readl((a) + (r))

applied



WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jeff@garzik.org>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: netdev@vger.kernel.org, eric.miao@marvell.com,
	luca.santini@spesonline.com, nico@cam.org,
	linux-sh@vger.kernel.org
Subject: Re: [PATCH] smc91x: SMC_IO_SHIFT platform data support for default case
Date: Sat, 13 Sep 2008 15:13:04 -0400	[thread overview]
Message-ID: <48CC10C0.6040607@garzik.org> (raw)
In-Reply-To: <20080908050234.11554.10123.sendpatchset@rx1.opensource.se>

Magnus Damm wrote:
> From: Magnus Damm <damm@igel.co.jp>
> 
> Commit 159198862adad7109bb347bb30a620f67beac45f added SMC_IO_SHIFT
> platform data support. After that ARM board support was added.
> 
> The default case is still missing though, so on SuperH SMC_IO_SHIFT
> is constantly zero regardless of what you pass as platform data.
> 
> Signed-off-by: Magnus Damm <damm@igel.co.jp>
> Test-by: Luca Santini <luca.santini@spesonline.com>
> ---
> 
>  drivers/net/smc91x.h |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- 0001/drivers/net/smc91x.h
> +++ work/drivers/net/smc91x.h	2008-08-28 20:43:03.000000000 +0900
> @@ -446,6 +446,8 @@ static inline void LPD7_SMC_outsw (unsig
>  #define SMC_CAN_USE_32BIT	1
>  #define SMC_NOWAIT		1
>  
> +#define SMC_IO_SHIFT		(lp->io_shift)
> +
>  #define SMC_inb(a, r)		readb((a) + (r))
>  #define SMC_inw(a, r)		readw((a) + (r))
>  #define SMC_inl(a, r)		readl((a) + (r))

applied



  parent reply	other threads:[~2008-09-13 19:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-08  5:02 [PATCH] smc91x: SMC_IO_SHIFT platform data support for default case Magnus Damm
2008-09-08  5:02 ` Magnus Damm
2008-09-08 11:19 ` [PATCH] smc91x: SMC_IO_SHIFT platform data support for default Simon Horman
2008-09-08 11:19   ` [PATCH] smc91x: SMC_IO_SHIFT platform data support for default case Simon Horman
2008-09-10  7:44   ` Magnus Damm
2008-09-10  7:44     ` Magnus Damm
2008-09-13 19:13 ` Jeff Garzik [this message]
2008-09-13 19:13   ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48CC10C0.6040607@garzik.org \
    --to=jeff@garzik.org \
    --cc=eric.miao@marvell.com \
    --cc=linux-sh@vger.kernel.org \
    --cc=luca.santini@spesonline.com \
    --cc=magnus.damm@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nico@cam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.