* [PATCH] smc91x: SMC_IO_SHIFT platform data support for default case
@ 2008-09-08 5:02 ` Magnus Damm
0 siblings, 0 replies; 8+ messages in thread
From: Magnus Damm @ 2008-09-08 5:02 UTC (permalink / raw)
To: netdev; +Cc: eric.miao, Magnus Damm, luca.santini, nico, linux-sh
From: Magnus Damm <damm@igel.co.jp>
Commit 159198862adad7109bb347bb30a620f67beac45f added SMC_IO_SHIFT
platform data support. After that ARM board support was added.
The default case is still missing though, so on SuperH SMC_IO_SHIFT
is constantly zero regardless of what you pass as platform data.
Signed-off-by: Magnus Damm <damm@igel.co.jp>
Test-by: Luca Santini <luca.santini@spesonline.com>
---
drivers/net/smc91x.h | 2 ++
1 file changed, 2 insertions(+)
--- 0001/drivers/net/smc91x.h
+++ work/drivers/net/smc91x.h 2008-08-28 20:43:03.000000000 +0900
@@ -446,6 +446,8 @@ static inline void LPD7_SMC_outsw (unsig
#define SMC_CAN_USE_32BIT 1
#define SMC_NOWAIT 1
+#define SMC_IO_SHIFT (lp->io_shift)
+
#define SMC_inb(a, r) readb((a) + (r))
#define SMC_inw(a, r) readw((a) + (r))
#define SMC_inl(a, r) readl((a) + (r))
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] smc91x: SMC_IO_SHIFT platform data support for default case
@ 2008-09-08 5:02 ` Magnus Damm
0 siblings, 0 replies; 8+ messages in thread
From: Magnus Damm @ 2008-09-08 5:02 UTC (permalink / raw)
To: netdev; +Cc: eric.miao, Magnus Damm, luca.santini, nico, linux-sh
From: Magnus Damm <damm@igel.co.jp>
Commit 159198862adad7109bb347bb30a620f67beac45f added SMC_IO_SHIFT
platform data support. After that ARM board support was added.
The default case is still missing though, so on SuperH SMC_IO_SHIFT
is constantly zero regardless of what you pass as platform data.
Signed-off-by: Magnus Damm <damm@igel.co.jp>
Test-by: Luca Santini <luca.santini@spesonline.com>
---
drivers/net/smc91x.h | 2 ++
1 file changed, 2 insertions(+)
--- 0001/drivers/net/smc91x.h
+++ work/drivers/net/smc91x.h 2008-08-28 20:43:03.000000000 +0900
@@ -446,6 +446,8 @@ static inline void LPD7_SMC_outsw (unsig
#define SMC_CAN_USE_32BIT 1
#define SMC_NOWAIT 1
+#define SMC_IO_SHIFT (lp->io_shift)
+
#define SMC_inb(a, r) readb((a) + (r))
#define SMC_inw(a, r) readw((a) + (r))
#define SMC_inl(a, r) readl((a) + (r))
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] smc91x: SMC_IO_SHIFT platform data support for default
2008-09-08 5:02 ` Magnus Damm
@ 2008-09-08 11:19 ` Simon Horman
-1 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2008-09-08 11:19 UTC (permalink / raw)
To: Magnus Damm; +Cc: netdev, eric.miao, luca.santini, nico, linux-sh
On Mon, Sep 08, 2008 at 02:02:34PM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm@igel.co.jp>
>
> Commit 159198862adad7109bb347bb30a620f67beac45f added SMC_IO_SHIFT
> platform data support. After that ARM board support was added.
>
> The default case is still missing though, so on SuperH SMC_IO_SHIFT
> is constantly zero regardless of what you pass as platform data.
Hi Magnus,
I beleive that its now common practice to include the subject
of a commit along with its id, as the latter can change as
it moves from tree to tree.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] smc91x: SMC_IO_SHIFT platform data support for default case
@ 2008-09-08 11:19 ` Simon Horman
0 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2008-09-08 11:19 UTC (permalink / raw)
To: Magnus Damm; +Cc: netdev, eric.miao, luca.santini, nico, linux-sh
On Mon, Sep 08, 2008 at 02:02:34PM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm@igel.co.jp>
>
> Commit 159198862adad7109bb347bb30a620f67beac45f added SMC_IO_SHIFT
> platform data support. After that ARM board support was added.
>
> The default case is still missing though, so on SuperH SMC_IO_SHIFT
> is constantly zero regardless of what you pass as platform data.
Hi Magnus,
I beleive that its now common practice to include the subject
of a commit along with its id, as the latter can change as
it moves from tree to tree.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] smc91x: SMC_IO_SHIFT platform data support for default case
2008-09-08 11:19 ` [PATCH] smc91x: SMC_IO_SHIFT platform data support for default case Simon Horman
@ 2008-09-10 7:44 ` Magnus Damm
-1 siblings, 0 replies; 8+ messages in thread
From: Magnus Damm @ 2008-09-10 7:44 UTC (permalink / raw)
To: Simon Horman; +Cc: netdev, eric.miao, luca.santini, nico, linux-sh
Hi Simon!
On Mon, Sep 8, 2008 at 8:19 PM, Simon Horman <horms@verge.net.au> wrote:
> On Mon, Sep 08, 2008 at 02:02:34PM +0900, Magnus Damm wrote:
>> From: Magnus Damm <damm@igel.co.jp>
>>
>> Commit 159198862adad7109bb347bb30a620f67beac45f added SMC_IO_SHIFT
>> platform data support. After that ARM board support was added.
>>
>> The default case is still missing though, so on SuperH SMC_IO_SHIFT
>> is constantly zero regardless of what you pass as platform data.
>
> I beleive that its now common practice to include the subject
> of a commit along with its id, as the latter can change as
> it moves from tree to tree.
Oh, thanks for pointing that out. I should really do that next time.
In this case the commit id is from the linux-2.6 git, so shouldn't it
be stable enough? Isn't it the final destination? =)
Thanks!
/ magnus
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] smc91x: SMC_IO_SHIFT platform data support for default case
@ 2008-09-10 7:44 ` Magnus Damm
0 siblings, 0 replies; 8+ messages in thread
From: Magnus Damm @ 2008-09-10 7:44 UTC (permalink / raw)
To: Simon Horman; +Cc: netdev, eric.miao, luca.santini, nico, linux-sh
Hi Simon!
On Mon, Sep 8, 2008 at 8:19 PM, Simon Horman <horms@verge.net.au> wrote:
> On Mon, Sep 08, 2008 at 02:02:34PM +0900, Magnus Damm wrote:
>> From: Magnus Damm <damm@igel.co.jp>
>>
>> Commit 159198862adad7109bb347bb30a620f67beac45f added SMC_IO_SHIFT
>> platform data support. After that ARM board support was added.
>>
>> The default case is still missing though, so on SuperH SMC_IO_SHIFT
>> is constantly zero regardless of what you pass as platform data.
>
> I beleive that its now common practice to include the subject
> of a commit along with its id, as the latter can change as
> it moves from tree to tree.
Oh, thanks for pointing that out. I should really do that next time.
In this case the commit id is from the linux-2.6 git, so shouldn't it
be stable enough? Isn't it the final destination? =)
Thanks!
/ magnus
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] smc91x: SMC_IO_SHIFT platform data support for default
2008-09-08 5:02 ` Magnus Damm
@ 2008-09-13 19:13 ` Jeff Garzik
-1 siblings, 0 replies; 8+ messages in thread
From: Jeff Garzik @ 2008-09-13 19:13 UTC (permalink / raw)
To: Magnus Damm; +Cc: netdev, eric.miao, luca.santini, nico, linux-sh
Magnus Damm wrote:
> From: Magnus Damm <damm@igel.co.jp>
>
> Commit 159198862adad7109bb347bb30a620f67beac45f added SMC_IO_SHIFT
> platform data support. After that ARM board support was added.
>
> The default case is still missing though, so on SuperH SMC_IO_SHIFT
> is constantly zero regardless of what you pass as platform data.
>
> Signed-off-by: Magnus Damm <damm@igel.co.jp>
> Test-by: Luca Santini <luca.santini@spesonline.com>
> ---
>
> drivers/net/smc91x.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- 0001/drivers/net/smc91x.h
> +++ work/drivers/net/smc91x.h 2008-08-28 20:43:03.000000000 +0900
> @@ -446,6 +446,8 @@ static inline void LPD7_SMC_outsw (unsig
> #define SMC_CAN_USE_32BIT 1
> #define SMC_NOWAIT 1
>
> +#define SMC_IO_SHIFT (lp->io_shift)
> +
> #define SMC_inb(a, r) readb((a) + (r))
> #define SMC_inw(a, r) readw((a) + (r))
> #define SMC_inl(a, r) readl((a) + (r))
applied
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] smc91x: SMC_IO_SHIFT platform data support for default case
@ 2008-09-13 19:13 ` Jeff Garzik
0 siblings, 0 replies; 8+ messages in thread
From: Jeff Garzik @ 2008-09-13 19:13 UTC (permalink / raw)
To: Magnus Damm; +Cc: netdev, eric.miao, luca.santini, nico, linux-sh
Magnus Damm wrote:
> From: Magnus Damm <damm@igel.co.jp>
>
> Commit 159198862adad7109bb347bb30a620f67beac45f added SMC_IO_SHIFT
> platform data support. After that ARM board support was added.
>
> The default case is still missing though, so on SuperH SMC_IO_SHIFT
> is constantly zero regardless of what you pass as platform data.
>
> Signed-off-by: Magnus Damm <damm@igel.co.jp>
> Test-by: Luca Santini <luca.santini@spesonline.com>
> ---
>
> drivers/net/smc91x.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- 0001/drivers/net/smc91x.h
> +++ work/drivers/net/smc91x.h 2008-08-28 20:43:03.000000000 +0900
> @@ -446,6 +446,8 @@ static inline void LPD7_SMC_outsw (unsig
> #define SMC_CAN_USE_32BIT 1
> #define SMC_NOWAIT 1
>
> +#define SMC_IO_SHIFT (lp->io_shift)
> +
> #define SMC_inb(a, r) readb((a) + (r))
> #define SMC_inw(a, r) readw((a) + (r))
> #define SMC_inl(a, r) readl((a) + (r))
applied
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2008-09-13 19:13 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-08 5:02 [PATCH] smc91x: SMC_IO_SHIFT platform data support for default case Magnus Damm
2008-09-08 5:02 ` Magnus Damm
2008-09-08 11:19 ` [PATCH] smc91x: SMC_IO_SHIFT platform data support for default Simon Horman
2008-09-08 11:19 ` [PATCH] smc91x: SMC_IO_SHIFT platform data support for default case Simon Horman
2008-09-10 7:44 ` Magnus Damm
2008-09-10 7:44 ` Magnus Damm
2008-09-13 19:13 ` [PATCH] smc91x: SMC_IO_SHIFT platform data support for default Jeff Garzik
2008-09-13 19:13 ` [PATCH] smc91x: SMC_IO_SHIFT platform data support for default case Jeff Garzik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.