From: Jes Sorensen <jes@sgi.com>
To: kvm-ia64@vger.kernel.org
Subject: [patch] do not allocate code_gen buffer on ia64
Date: Wed, 24 Sep 2008 11:28:37 +0000 [thread overview]
Message-ID: <48DA2465.1040709@sgi.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 260 bytes --]
Avi Kivity wrote:
> Jes Sorensen wrote:
>> Hi,
>>
>> This one limits the code_gen_buffer_size on ia64, phys_mem_size/4
>> really gets out of hand when you boot say a 64GB guest.
>
> ia64 doesn't codegen; why not set it to zero?
How about this one then?
Jes
[-- Attachment #2: 1200-ia64-code-gen-buffer.patch --]
[-- Type: text/plain, Size: 626 bytes --]
Do not allocate a code_gen buffer on ia64 given it doesn't support
code generation.
Signed-off-by: Jes Sorensen <jes@sgi.com>
---
qemu/exec.c | 4 ++++
1 file changed, 4 insertions(+)
Index: kvm-userspace.git/qemu/exec.c
===================================================================
--- kvm-userspace.git.orig/qemu/exec.c
+++ kvm-userspace.git/qemu/exec.c
@@ -407,6 +407,10 @@
static void code_gen_alloc(unsigned long tb_size)
{
+#ifdef TARGET_IA64
+ return;
+#endif
+
#ifdef USE_STATIC_CODE_GEN_BUFFER
code_gen_buffer = static_code_gen_buffer;
code_gen_buffer_size = DEFAULT_CODE_GEN_BUFFER_SIZE;
WARNING: multiple messages have this Message-ID (diff)
From: Jes Sorensen <jes@sgi.com>
To: Avi Kivity <avi@redhat.com>
Cc: kvm@vger.kernel.org, kvm-ia64@vger.kernel.org
Subject: [patch] do not allocate code_gen buffer on ia64
Date: Wed, 24 Sep 2008 13:28:37 +0200 [thread overview]
Message-ID: <48DA2465.1040709@sgi.com> (raw)
In-Reply-To: <48DA1D49.80108@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 260 bytes --]
Avi Kivity wrote:
> Jes Sorensen wrote:
>> Hi,
>>
>> This one limits the code_gen_buffer_size on ia64, phys_mem_size/4
>> really gets out of hand when you boot say a 64GB guest.
>
> ia64 doesn't codegen; why not set it to zero?
How about this one then?
Jes
[-- Attachment #2: 1200-ia64-code-gen-buffer.patch --]
[-- Type: text/plain, Size: 626 bytes --]
Do not allocate a code_gen buffer on ia64 given it doesn't support
code generation.
Signed-off-by: Jes Sorensen <jes@sgi.com>
---
qemu/exec.c | 4 ++++
1 file changed, 4 insertions(+)
Index: kvm-userspace.git/qemu/exec.c
===================================================================
--- kvm-userspace.git.orig/qemu/exec.c
+++ kvm-userspace.git/qemu/exec.c
@@ -407,6 +407,10 @@
static void code_gen_alloc(unsigned long tb_size)
{
+#ifdef TARGET_IA64
+ return;
+#endif
+
#ifdef USE_STATIC_CODE_GEN_BUFFER
code_gen_buffer = static_code_gen_buffer;
code_gen_buffer_size = DEFAULT_CODE_GEN_BUFFER_SIZE;
next reply other threads:[~2008-09-24 11:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-24 11:28 Jes Sorensen [this message]
2008-09-24 11:28 ` [patch] do not allocate code_gen buffer on ia64 Jes Sorensen
2008-09-24 11:39 ` Avi Kivity
2008-09-24 11:39 ` Avi Kivity
2008-09-24 11:42 ` Jes Sorensen
2008-09-24 11:42 ` Jes Sorensen
2008-09-24 12:09 ` Avi Kivity
2008-09-24 12:09 ` Avi Kivity
2008-09-24 12:52 ` Jes Sorensen
2008-09-24 12:52 ` Jes Sorensen
2008-09-24 13:09 ` Avi Kivity
2008-09-24 13:09 ` Avi Kivity
2008-09-24 15:33 ` Anthony Liguori
2008-09-24 15:33 ` Anthony Liguori
2008-09-24 15:40 ` Avi Kivity
2008-09-24 15:40 ` Avi Kivity
-- strict thread matches above, loose matches on Subject: below --
2008-09-24 9:19 [patch] cap code_gen_buffer_size " Jes Sorensen
2008-09-24 9:19 ` Jes Sorensen
2008-09-24 10:58 ` Avi Kivity
2008-09-24 10:58 ` Avi Kivity
2008-09-24 11:00 ` Jes Sorensen
2008-09-24 11:00 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48DA2465.1040709@sgi.com \
--to=jes@sgi.com \
--cc=kvm-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.