* [PATCH -tip] cpuset doesn't seem to be so const
@ 2008-10-03 10:10 Frederic Weisbecker
2008-10-03 11:39 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Frederic Weisbecker @ 2008-10-03 10:10 UTC (permalink / raw)
To: Ingo Molnar; +Cc: linux-kernel
This fixes a warning on last -tip:
kernel/cpuset.c: Dans la fonction «scan_for_empty_cpusets» :
kernel/cpuset.c:1932: attention : passing argument 1 of «list_add_tail» discards qualifiers from pointer target type
Actually the struct cpuset *root passed in parameter to scan_for_empty_cpusets
is not supposed to be const since an entry is added on the tail of its list.
Just correct the qualifier.
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---
kernel/cpuset.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index 827cd9a..eab7bd6 100644
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -1921,7 +1921,7 @@ static void remove_tasks_in_empty_cpuset(struct cpuset *cs)
* that has tasks along with an empty 'mems'. But if we did see such
* a cpuset, we'd handle it just like we do if its 'cpus' was empty.
*/
-static void scan_for_empty_cpusets(const struct cpuset *root)
+static void scan_for_empty_cpusets(struct cpuset *root)
{
LIST_HEAD(queue);
struct cpuset *cp; /* scans cpusets being updated */
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -tip] cpuset doesn't seem to be so const
2008-10-03 10:10 [PATCH -tip] cpuset doesn't seem to be so const Frederic Weisbecker
@ 2008-10-03 11:39 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-10-03 11:39 UTC (permalink / raw)
To: Frederic Weisbecker; +Cc: linux-kernel
* Frederic Weisbecker <fweisbec@gmail.com> wrote:
> This fixes a warning on last -tip:
>
> kernel/cpuset.c: Dans la fonction «scan_for_empty_cpusets» :
> kernel/cpuset.c:1932: attention : passing argument 1 of «list_add_tail» discards qualifiers from pointer target type
>
> Actually the struct cpuset *root passed in parameter to scan_for_empty_cpusets
> is not supposed to be const since an entry is added on the tail of its list.
> Just correct the qualifier.
>
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
applied to tip/sched/cpusets, thanks Frederic!
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-03 11:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-03 10:10 [PATCH -tip] cpuset doesn't seem to be so const Frederic Weisbecker
2008-10-03 11:39 ` Ingo Molnar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.