All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Lameter <cl@linux-foundation.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	rusty@rustcorp.com.au, jeremy@goop.org, ebiederm@xmission.com,
	travis@sgi.com, herbert@gondor.apana.org.au, xemul@openvz.org
Subject: Re: [patch 3/4] cpu alloc: The allocator
Date: Fri, 03 Oct 2008 09:15:34 -0500	[thread overview]
Message-ID: <48E62906.3030506@linux-foundation.org> (raw)
In-Reply-To: <20081003012003.f1f84937.akpm@linux-foundation.org>

Andrew Morton wrote:
>
> umm, yeah, the whole bitmap interface is busted from that POV.


Yup cannot find equivalent bitmap operations for cpu_alloc.

Also the search operations already use find_next_zero_bit() and
find_next_bit(). So this should be okay.

We could define new bitops:

bitmap_set_range(dst, start, end)
bitmap_clear_range(dst, start, end)

int find_zero_bits(dst, start, end, nr_of_zero_bits)

but then there are additional alignment requirements that such a generic
function would not be able to check for.



WARNING: multiple messages have this Message-ID (diff)
From: Christoph Lameter <cl@linux-foundation.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	rusty@rustcorp.com.au, jeremy@goop.org, ebiederm@xmission.com,
	travis@sgi.com, herbert@gondor.apana.org.au, xemul@openvz.org
Subject: Re: [patch 3/4] cpu alloc: The allocator
Date: Fri, 03 Oct 2008 09:15:34 -0500	[thread overview]
Message-ID: <48E62906.3030506@linux-foundation.org> (raw)
In-Reply-To: <20081003012003.f1f84937.akpm@linux-foundation.org>

Andrew Morton wrote:
>
> umm, yeah, the whole bitmap interface is busted from that POV.


Yup cannot find equivalent bitmap operations for cpu_alloc.

Also the search operations already use find_next_zero_bit() and
find_next_bit(). So this should be okay.

We could define new bitops:

bitmap_set_range(dst, start, end)
bitmap_clear_range(dst, start, end)

int find_zero_bits(dst, start, end, nr_of_zero_bits)

but then there are additional alignment requirements that such a generic
function would not be able to check for.


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-10-03 14:16 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-29 19:35 [patch 0/4] Cpu alloc V6: Replace percpu allocator in modules.c Christoph Lameter
2008-09-29 19:35 ` Christoph Lameter
2008-09-29 19:35 ` [patch 1/4] Make the per cpu reserve configurable Christoph Lameter
2008-09-29 19:35   ` Christoph Lameter
2008-09-29 19:35 ` [patch 2/4] percpu: Rename variables PERCPU_ENOUGH_ROOM -> PERCPU_AREA_SIZE Christoph Lameter
2008-09-29 19:35   ` Christoph Lameter
2008-09-29 19:35 ` [patch 3/4] cpu alloc: The allocator Christoph Lameter
2008-09-29 19:35   ` Christoph Lameter
2008-09-30  6:35   ` Pekka Enberg
2008-09-30  6:35     ` Pekka Enberg
2008-09-30 11:38     ` Christoph Lameter
2008-09-30 11:38       ` Christoph Lameter
2008-09-30 11:48       ` Pekka Enberg
2008-09-30 11:48         ` Pekka Enberg
2008-09-30 12:12         ` Christoph Lameter
2008-09-30 12:12           ` Christoph Lameter
2008-10-03  7:33   ` Andrew Morton
2008-10-03  7:33     ` Andrew Morton
2008-10-03  7:43     ` Pekka Enberg
2008-10-03  7:43       ` Pekka Enberg
2008-10-03  8:20       ` Andrew Morton
2008-10-03  8:20         ` Andrew Morton
2008-10-03 14:15         ` Christoph Lameter [this message]
2008-10-03 14:15           ` Christoph Lameter
2008-10-03 12:48     ` Christoph Lameter
2008-10-03 12:48       ` Christoph Lameter
2008-10-05 21:10       ` Rusty Russell
2008-10-05 21:10         ` Rusty Russell
2008-10-07 13:27         ` Christoph Lameter
2008-10-07 13:27           ` Christoph Lameter
2008-09-29 19:35 ` [patch 4/4] cpu alloc: Use cpu allocator instead of the builtin modules per cpu allocator Christoph Lameter
2008-09-29 19:35   ` Christoph Lameter
2008-09-30 22:28   ` Rusty Russell
2008-09-30 22:28     ` Rusty Russell
2008-09-30 22:27 ` [patch 0/4] Cpu alloc V6: Replace percpu allocator in modules.c Rusty Russell
2008-09-30 22:27   ` Rusty Russell
2008-10-07 23:34 ` Andrew Morton
2008-10-07 23:34   ` Andrew Morton
2008-10-08 15:10   ` Christoph Lameter
2008-10-08 15:10     ` Christoph Lameter
  -- strict thread matches above, loose matches on Subject: below --
2008-09-19 14:58 [patch 0/4] Cpu alloc V5: " Christoph Lameter
2008-09-19 14:59 ` [patch 3/4] cpu alloc: The allocator Christoph Lameter
2008-09-19 14:59   ` Christoph Lameter
2008-09-19 15:23   ` KOSAKI Motohiro
2008-09-19 15:23     ` KOSAKI Motohiro
2008-09-19 16:27   ` Eric Dumazet
2008-09-19 16:27     ` Eric Dumazet
2008-09-19 16:49     ` Christoph Lameter
2008-09-19 16:49       ` Christoph Lameter
2008-09-19 17:00       ` Christoph Lameter
2008-09-19 17:00         ` Christoph Lameter
2008-09-19 20:32   ` Christoph Lameter
2008-09-19 20:32     ` Christoph Lameter
2008-09-18 23:36 [patch 0/4] Cpu alloc V4: Replace percpu allocator in modules.c Christoph Lameter
2008-09-18 23:36 ` [patch 3/4] cpu alloc: The allocator Christoph Lameter
2008-09-19  7:58   ` Pekka Enberg
2008-09-19 13:11     ` Christoph Lameter
2008-09-19 14:12       ` Pekka Enberg
2008-09-19 14:27         ` Christoph Lameter
2008-09-19 14:35           ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48E62906.3030506@linux-foundation.org \
    --to=cl@linux-foundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=penberg@cs.helsinki.fi \
    --cc=rusty@rustcorp.com.au \
    --cc=travis@sgi.com \
    --cc=xemul@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.