All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pata_of_platform: fix no irq handling
Date: Mon, 13 Oct 2008 22:53:34 +0900	[thread overview]
Message-ID: <48F352DE.8060001@kernel.org> (raw)
In-Reply-To: <48F34CB9.3020000@pobox.com>

Jeff Garzik wrote:
> Tejun Heo wrote:
>> Anton Vorontsov wrote:
>>> When no irq specified the pata_of_platform fills the irq_res with -1,
>>> which is wrong to do for two reasons:
>>>
>>> 1. By definition, 'no irq' should be IRQ 0, not some negative integer;
>>> 2. pata_platform checks for irq_res.start > 0, but since irq_res.start
>>>    is unsigned type, the check will be true for `-1'.
>>>
>>> Reported-by: Steven A. Falco <sfalco@harris.com>
>>> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
>>
>> applied to #tj-upstream (will soon be sent upstream)
> 
> I have returned!  muhahahahahaha....

Ah.. great.  Hope you enjoyed the vacation.  Can you please pull from
#tj-upstream?

 git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata-dev.git tj-upstream
 http://git.kernel.org/?p=linux/kernel/git/tj/libata-dev.git;a=shortlog;h=tj-upstream

Nothing much.  Rafael's skip-spin-off patchset + Elias's small fix +
ATA_HORKAGE_ATAPI_MOD16_DMA + pata_of_platform irq fix.

Gwendal posted patches to enable FIS based switching when NCQ is
disabled on sata_mv but I think this should be put into separate
branch and stay in linux-next till Mark Lord comes back and reviews it
as I don't know much about the driver and don't know of anyone other
than Gwendal and Mark who do.

sata_nv detection problem is still not resolved.  I figured out
generic and ck804 but nf2/3 is still malfunctioning.  I asked for more
tests and am waiting for results.

Eh... I guess that's about it.  Enjoy your INBOX.  :-P

-- 
tejun

  reply	other threads:[~2008-10-13 13:59 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-06 17:26 [PATCH] pata_of_platform: fix no irq handling Anton Vorontsov
2008-10-06 17:26 ` Anton Vorontsov
2008-10-06 20:41 ` Matt Sealey
2008-10-06 20:41   ` Matt Sealey
2008-10-06 21:32   ` Anton Vorontsov
2008-10-06 21:32     ` Anton Vorontsov
2008-10-07  1:30     ` Tejun Heo
2008-10-07  1:30       ` Tejun Heo
2008-10-07  9:18       ` Wang Jian
2008-10-07  9:18         ` Wang Jian
2008-10-07  9:26       ` Anton Vorontsov
2008-10-07  9:26         ` Anton Vorontsov
2008-10-07 10:04         ` Benjamin Herrenschmidt
2008-10-07 10:04           ` Benjamin Herrenschmidt
2008-10-07  9:37       ` Alan Cox
2008-10-07  9:37         ` Alan Cox
2008-10-08  8:40         ` David Woodhouse
2008-10-08  8:40           ` David Woodhouse
2008-10-08  9:00           ` Alan Cox
2008-10-08  9:00             ` Alan Cox
2008-10-08  9:59             ` Geert Uytterhoeven
2008-10-08  9:59               ` Geert Uytterhoeven
2008-10-08 10:27               ` Alan Cox
2008-10-08 10:27                 ` Alan Cox
2008-10-10 17:55               ` Paul Mundt
2008-10-10 17:55                 ` Paul Mundt
2008-10-13  6:56 ` Tejun Heo
2008-10-13  6:56   ` Tejun Heo
2008-10-13 13:27   ` Jeff Garzik
2008-10-13 13:53     ` Tejun Heo [this message]
2008-10-13 14:02     ` I have returned! Alan Cox
2008-10-16  9:40       ` Jeff Garzik
2008-10-13 14:04     ` [PATCH] fusion: remove dead mpt lan code Alan Cox
2008-10-13 14:05     ` [PATCH] mptsas: remove pointless null check Alan Cox
2008-10-13 14:22       ` James Bottomley
2008-10-13 14:37         ` Alan Cox
2008-10-13 23:27   ` [PATCH] pata_of_platform: fix no irq handling Benjamin Herrenschmidt
2008-10-13 23:27     ` Benjamin Herrenschmidt
  -- strict thread matches above, loose matches on Subject: below --
2008-09-25  8:36 [PATCH] pata_platform struct resource signness fix Wang Jian
2008-09-25  8:54 ` Wang Jian
2008-09-25 10:40   ` Li Yang
2008-09-25 10:48     ` Anton Vorontsov
2008-09-29  4:19       ` Jeff Garzik
2008-09-29 13:32         ` [PATCH] pata_of_platform: fix no irq handling Anton Vorontsov
2008-09-29 13:32           ` Anton Vorontsov
2008-08-11 14:48 Possible bug in IRQ handling in pata_of_platform / pata_platform Steven A. Falco
2008-08-11 15:19 ` [PATCH] pata_of_platform: fix no irq handling Anton Vorontsov
2008-08-11 16:23   ` Steven A. Falco
2008-08-11 16:23     ` Steven A. Falco
2008-08-11 17:07     ` Anton Vorontsov
2008-08-11 17:07       ` Anton Vorontsov
2008-08-11 22:00       ` Benjamin Herrenschmidt
2008-08-12 14:00         ` Steven A. Falco
2008-08-12 14:00           ` Steven A. Falco
2008-08-12 14:04           ` Anton Vorontsov
2008-08-12 14:04             ` Anton Vorontsov
2008-08-12 14:18             ` Stefan Roese
2008-08-12 14:18               ` Stefan Roese
2008-08-12 14:18             ` Sergei Shtylyov
2008-08-12 14:18               ` Sergei Shtylyov
2008-08-12 14:31               ` Anton Vorontsov
2008-08-12 14:31                 ` Anton Vorontsov
2008-08-13 21:25                 ` Steven A. Falco
2008-08-13 21:25                   ` Steven A. Falco
2008-08-11 16:29   ` Alan Cox
2008-08-11 16:36   ` Ben Dooks
2008-08-11 16:36     ` Ben Dooks
2008-08-11 16:26     ` Alan Cox
2008-08-11 16:42     ` Steven A. Falco
2008-08-11 16:42       ` Steven A. Falco
2008-08-11 22:02     ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48F352DE.8060001@kernel.org \
    --to=tj@kernel.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.