All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: avorontsov@ru.mvista.com
Cc: Matt Sealey <matt@genesi-usa.com>,
	Jeff Garzik <jgarzik@pobox.com>,
	linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
	linux-ide@vger.kernel.org, Li Yang <leoli@freescale.com>,
	Wang Jian <lark@linux.net.cn>
Subject: Re: [PATCH] pata_of_platform: fix no irq handling
Date: Tue, 07 Oct 2008 10:30:59 +0900	[thread overview]
Message-ID: <48EABBD3.1010401@kernel.org> (raw)
In-Reply-To: <20081006213209.GA13072@oksana.dev.rtsoft.ru>

Anton Vorontsov wrote:
> On Mon, Oct 06, 2008 at 03:41:19PM -0500, Matt Sealey wrote:
>> There is a simple problem with the patch which is that an "IRQ 0" can and does
>> actually exist on a bunch of platforms, at least to the best of my knowledge.
>>
>> Checking for -1 (which means for definite, no irq at all, because it is
>> totally unambiguous, as a -1 IRQ numbering is "impossible") is more correct.
> 
> This was discussed years ago.
> 
> http://lkml.org/lkml/2005/11/22/159
> http://lkml.org/lkml/2005/11/22/227
> 

Would this break any existing platforms?  If so, can those be fixed
together or does it become a much bigger problem that way?

Thanks.

-- 
tejun

WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: avorontsov@ru.mvista.com
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
	linux-ide@vger.kernel.org, Li Yang <leoli@freescale.com>,
	Jeff Garzik <jgarzik@pobox.com>, Wang Jian <lark@linux.net.cn>
Subject: Re: [PATCH] pata_of_platform: fix no irq handling
Date: Tue, 07 Oct 2008 10:30:59 +0900	[thread overview]
Message-ID: <48EABBD3.1010401@kernel.org> (raw)
In-Reply-To: <20081006213209.GA13072@oksana.dev.rtsoft.ru>

Anton Vorontsov wrote:
> On Mon, Oct 06, 2008 at 03:41:19PM -0500, Matt Sealey wrote:
>> There is a simple problem with the patch which is that an "IRQ 0" can and does
>> actually exist on a bunch of platforms, at least to the best of my knowledge.
>>
>> Checking for -1 (which means for definite, no irq at all, because it is
>> totally unambiguous, as a -1 IRQ numbering is "impossible") is more correct.
> 
> This was discussed years ago.
> 
> http://lkml.org/lkml/2005/11/22/159
> http://lkml.org/lkml/2005/11/22/227
> 

Would this break any existing platforms?  If so, can those be fixed
together or does it become a much bigger problem that way?

Thanks.

-- 
tejun

  reply	other threads:[~2008-10-07  1:33 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-06 17:26 [PATCH] pata_of_platform: fix no irq handling Anton Vorontsov
2008-10-06 17:26 ` Anton Vorontsov
2008-10-06 20:41 ` Matt Sealey
2008-10-06 20:41   ` Matt Sealey
2008-10-06 21:32   ` Anton Vorontsov
2008-10-06 21:32     ` Anton Vorontsov
2008-10-07  1:30     ` Tejun Heo [this message]
2008-10-07  1:30       ` Tejun Heo
2008-10-07  9:18       ` Wang Jian
2008-10-07  9:18         ` Wang Jian
2008-10-07  9:26       ` Anton Vorontsov
2008-10-07  9:26         ` Anton Vorontsov
2008-10-07 10:04         ` Benjamin Herrenschmidt
2008-10-07 10:04           ` Benjamin Herrenschmidt
2008-10-07  9:37       ` Alan Cox
2008-10-07  9:37         ` Alan Cox
2008-10-08  8:40         ` David Woodhouse
2008-10-08  8:40           ` David Woodhouse
2008-10-08  9:00           ` Alan Cox
2008-10-08  9:00             ` Alan Cox
2008-10-08  9:59             ` Geert Uytterhoeven
2008-10-08  9:59               ` Geert Uytterhoeven
2008-10-08 10:27               ` Alan Cox
2008-10-08 10:27                 ` Alan Cox
2008-10-10 17:55               ` Paul Mundt
2008-10-10 17:55                 ` Paul Mundt
2008-10-13  6:56 ` Tejun Heo
2008-10-13  6:56   ` Tejun Heo
2008-10-13 13:27   ` Jeff Garzik
2008-10-13 13:53     ` Tejun Heo
2008-10-13 14:02     ` I have returned! Alan Cox
2008-10-16  9:40       ` Jeff Garzik
2008-10-13 14:04     ` [PATCH] fusion: remove dead mpt lan code Alan Cox
2008-10-13 14:05     ` [PATCH] mptsas: remove pointless null check Alan Cox
2008-10-13 14:22       ` James Bottomley
2008-10-13 14:37         ` Alan Cox
2008-10-13 23:27   ` [PATCH] pata_of_platform: fix no irq handling Benjamin Herrenschmidt
2008-10-13 23:27     ` Benjamin Herrenschmidt
  -- strict thread matches above, loose matches on Subject: below --
2008-09-25  8:36 [PATCH] pata_platform struct resource signness fix Wang Jian
2008-09-25  8:54 ` Wang Jian
2008-09-25 10:40   ` Li Yang
2008-09-25 10:48     ` Anton Vorontsov
2008-09-29  4:19       ` Jeff Garzik
2008-09-29 13:32         ` [PATCH] pata_of_platform: fix no irq handling Anton Vorontsov
2008-09-29 13:32           ` Anton Vorontsov
2008-08-11 14:48 Possible bug in IRQ handling in pata_of_platform / pata_platform Steven A. Falco
2008-08-11 15:19 ` [PATCH] pata_of_platform: fix no irq handling Anton Vorontsov
2008-08-11 16:23   ` Steven A. Falco
2008-08-11 16:23     ` Steven A. Falco
2008-08-11 17:07     ` Anton Vorontsov
2008-08-11 17:07       ` Anton Vorontsov
2008-08-11 22:00       ` Benjamin Herrenschmidt
2008-08-12 14:00         ` Steven A. Falco
2008-08-12 14:00           ` Steven A. Falco
2008-08-12 14:04           ` Anton Vorontsov
2008-08-12 14:04             ` Anton Vorontsov
2008-08-12 14:18             ` Stefan Roese
2008-08-12 14:18               ` Stefan Roese
2008-08-12 14:18             ` Sergei Shtylyov
2008-08-12 14:18               ` Sergei Shtylyov
2008-08-12 14:31               ` Anton Vorontsov
2008-08-12 14:31                 ` Anton Vorontsov
2008-08-13 21:25                 ` Steven A. Falco
2008-08-13 21:25                   ` Steven A. Falco
2008-08-11 16:29   ` Alan Cox
2008-08-11 16:36   ` Ben Dooks
2008-08-11 16:36     ` Ben Dooks
2008-08-11 16:26     ` Alan Cox
2008-08-11 16:42     ` Steven A. Falco
2008-08-11 16:42       ` Steven A. Falco
2008-08-11 22:02     ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48EABBD3.1010401@kernel.org \
    --to=tj@kernel.org \
    --cc=avorontsov@ru.mvista.com \
    --cc=jgarzik@pobox.com \
    --cc=lark@linux.net.cn \
    --cc=leoli@freescale.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=matt@genesi-usa.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.