From: Avi Kivity <avi@redhat.com>
To: "Zhang, Xiantao" <xiantao.zhang@intel.com>
Cc: Amit Shah <amit.shah@redhat.com>,
Sheng Yang <sheng@linux.intel.com>,
kvm@vger.kernel.org
Subject: Re: [v2] Shared guest irq support
Date: Thu, 16 Oct 2008 10:21:38 +0200 [thread overview]
Message-ID: <48F6F992.3020203@redhat.com> (raw)
In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC01B47EAC@pdsmsx415.ccr.corp.intel.com>
Zhang, Xiantao wrote:
> Forget to modify the from item generated automatically by git. Modified
> to Sheng Yang <sheng@linux.intel.com> :)
> Xiantao
>
> From c0d1ad6327c01ba0584922022bef48c971bbf18a Mon Sep 17 00:00:00 2001
> From: Sheng Yang <sheng@linux.intel.com>
> Date: Wed, 15 Oct 2008 20:15:06 +0800
> Subject: [PATCH] KVM: Fix guest shared interrupt with in-kernel irqchip
>
> Every call of kvm_set_irq() should offer an irq_source_id, which is
> allocated by kvm_request_irq_source_id(). Based on irq_source_id, we
> identify the irq source and implement logical OR for shared level
> interrupts.
>
> The allocated irq_source_id can be freed by kvm_free_irq_source_id().
>
> Currently, we support at most sizeof(unsigned long) different irq
> sources.
>
>
>
> +#define KVM_USERSPACE_IRQ_SOURCE_ID 1 << 0
> +
>
This is dangerous, if used in an expression together with a higher
precedence operator. I fixed it and applied. Thanks to all involved.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-10-16 8:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-14 8:45 [v2] Shared guest irq support Zhang, Xiantao
2008-10-15 2:36 ` Sheng Yang
2008-10-15 7:03 ` Amit Shah
2008-10-15 7:11 ` Sheng Yang
2008-10-15 10:03 ` Amit Shah
2008-10-15 10:11 ` Zhang, Xiantao
2008-10-15 13:44 ` Zhang, Xiantao
2008-10-15 13:56 ` Zhang, Xiantao
2008-10-16 8:21 ` Avi Kivity [this message]
2008-10-16 8:28 ` Sheng Yang
2008-10-16 8:45 ` Avi Kivity
2008-10-16 8:31 ` Amit Shah
2008-10-16 8:47 ` Avi Kivity
2008-10-15 7:19 ` Amit Shah
[not found] <305032847.30081223883050196.JavaMail.root@zmail02.collab.prod.int.phx2.redhat.com>
2008-10-13 7:31 ` Amit Shah
2008-10-13 7:33 ` Zhang, Xiantao
2008-10-13 7:41 ` Amit Shah
2008-10-13 7:44 ` Zhang, Xiantao
2008-10-13 7:36 ` Sheng Yang
2008-10-14 8:00 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48F6F992.3020203@redhat.com \
--to=avi@redhat.com \
--cc=amit.shah@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=sheng@linux.intel.com \
--cc=xiantao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.