From: Avi Kivity <avi@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: "Zhang, Xiantao" <xiantao.zhang@intel.com>,
Sheng Yang <sheng@linux.intel.com>,
kvm@vger.kernel.org
Subject: Re: [v2] Shared guest irq support
Date: Thu, 16 Oct 2008 10:47:23 +0200 [thread overview]
Message-ID: <48F6FF9B.9040707@redhat.com> (raw)
In-Reply-To: <200810161401.56729.amit.shah@redhat.com>
Amit Shah wrote:
>>>
>>>
>>> +#define KVM_USERSPACE_IRQ_SOURCE_ID 1 << 0
>>> +
>>>
>> This is dangerous, if used in an expression together with a higher
>> precedence operator. I fixed it and applied. Thanks to all involved.
>>
>
> Thanks; however, Sheng suggested we should use set_bit to set the
> corresponding bit since we're operating on bitfields in a bitmap.
>
We are actually using set_bit, so the value should be zero.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-10-16 8:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-14 8:45 [v2] Shared guest irq support Zhang, Xiantao
2008-10-15 2:36 ` Sheng Yang
2008-10-15 7:03 ` Amit Shah
2008-10-15 7:11 ` Sheng Yang
2008-10-15 10:03 ` Amit Shah
2008-10-15 10:11 ` Zhang, Xiantao
2008-10-15 13:44 ` Zhang, Xiantao
2008-10-15 13:56 ` Zhang, Xiantao
2008-10-16 8:21 ` Avi Kivity
2008-10-16 8:28 ` Sheng Yang
2008-10-16 8:45 ` Avi Kivity
2008-10-16 8:31 ` Amit Shah
2008-10-16 8:47 ` Avi Kivity [this message]
2008-10-15 7:19 ` Amit Shah
[not found] <305032847.30081223883050196.JavaMail.root@zmail02.collab.prod.int.phx2.redhat.com>
2008-10-13 7:31 ` Amit Shah
2008-10-13 7:33 ` Zhang, Xiantao
2008-10-13 7:41 ` Amit Shah
2008-10-13 7:44 ` Zhang, Xiantao
2008-10-13 7:36 ` Sheng Yang
2008-10-14 8:00 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48F6FF9B.9040707@redhat.com \
--to=avi@redhat.com \
--cc=amit.shah@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=sheng@linux.intel.com \
--cc=xiantao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.