Re: [PATCH] conditionalize PCI reassign code

["Zhao, Yu" <yu.zhao@intel.com>]

Jan Beulich wrote:
>>>> "Zhao, Yu" <yu.zhao@intel.com> 17.10.08 04:43 >>>
>> There is build error (c/s 701) with this patch, please take a look.
> 
> This is why I always include
> 
>>> As usual, written and tested on 2.6.27 and made apply to the 2.6.18
>>> tree without further testing.
> 
> I'm making a best effort attempt at getting things in proper state for that
> tree, but time-wise can't afford full validation. But I always assumed that
> if this appears in the real (not the staging) tree, it at least survived
> building in Citrix' trees - is that not correct, Keir?
> 
> As you observed the build error - why don't you provide at least the
> error the compiler generated? That might make it possible to provide a
> fix quickly.

+#ifdef CONFIG_PCI_REASSIGN
  extern int reassign_resources;
  extern int is_reassigndev(struct pci_dev *dev);
  extern void pci_update_bridge(struct pci_dev *dev, int resno);
+#else
+#define reassign_resources 0
+#define is_reassigndev(dev) 0
+#endif

When the CONFIG_PCI_REASSIGN is not set, e.g., a domU kernel, the 
following line fails to be compiled (drivers/pci/quirks.c):

int reassign_resources = 0;

> 
> Jan
>