All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Zhao, Yu" <yu.zhao@intel.com>
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] conditionalize PCI reassign code
Date: Fri, 17 Oct 2008 15:38:36 +0800	[thread overview]
Message-ID: <48F840FC.9030507@intel.com> (raw)
In-Reply-To: <C51DFE90.1E466%keir.fraser@eu.citrix.com>

Keir Fraser wrote:
> 
> 
> On 17/10/08 08:27, "Zhao, Yu" <yu.zhao@intel.com> wrote:
> 
>>> As you observed the build error - why don't you provide at least the
>>> error the compiler generated? That might make it possible to provide a
>>> fix quickly.
>> +#ifdef CONFIG_PCI_REASSIGN
>>   extern int reassign_resources;
>>   extern int is_reassigndev(struct pci_dev *dev);
>>   extern void pci_update_bridge(struct pci_dev *dev, int resno);
>> +#else
>> +#define reassign_resources 0
>> +#define is_reassigndev(dev) 0
>> +#endif
>>
>> When the CONFIG_PCI_REASSIGN is not set, e.g., a domU kernel, the
>> following line fails to be compiled (drivers/pci/quirks.c):
>>
>> int reassign_resources = 0;
> 
> Ah, the automated tests only build the -xen config.
> 
>  -- Keir
> 
> 

Actually I happened to get it by misusing a native kernel config ...

  reply	other threads:[~2008-10-17  7:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-14 13:39 [PATCH] conditionalize PCI reassign code Jan Beulich
2008-10-15  7:56 ` Yuji Shimada
2008-10-15 15:14   ` Yu Zhao
2008-10-17  2:43 ` Zhao, Yu
2008-10-17  7:17   ` Jan Beulich
2008-10-17  7:22     ` Keir Fraser
2008-10-17  7:27       ` Jan Beulich
2008-10-17  7:27     ` Zhao, Yu
2008-10-17  7:34       ` Keir Fraser
2008-10-17  7:38         ` Zhao, Yu [this message]
2008-10-17  8:46       ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48F840FC.9030507@intel.com \
    --to=yu.zhao@intel.com \
    --cc=keir.fraser@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.