All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Lars Michael Jogback <lm@jogback.se>
Cc: linux-ide@vger.kernel.org
Subject: Re: Problem w/ hotplug on sata_sil24 w/ PMP (sil3726)
Date: Mon, 27 Oct 2008 16:38:18 +0900	[thread overview]
Message-ID: <49056FEA.4070405@kernel.org> (raw)
In-Reply-To: <49056F2C.20101@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 106 bytes --]

Oh.. one more thing.  Can you please try the attached patch and post the
failing log?

Thanks.

-- 
tejun

[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 744 bytes --]

diff --git a/drivers/ata/sata_sil24.c b/drivers/ata/sata_sil24.c
index 4621807..f8b9898 100644
--- a/drivers/ata/sata_sil24.c
+++ b/drivers/ata/sata_sil24.c
@@ -978,6 +978,8 @@ static void sil24_error_intr(struct ata_port *ap)
 	ehi = &link->eh_info;
 	ata_ehi_clear_desc(ehi);
 
+	ata_port_printk(ap, KERN_INFO,
+			"XXX error_intr irq_stat=0x%x\n", irq_stat);
 	ata_ehi_push_desc(ehi, "irq_stat 0x%08x", irq_stat);
 
 	if (irq_stat & PORT_IRQ_SDB_NOTIFY) {
@@ -1045,6 +1047,8 @@ static void sil24_error_intr(struct ata_port *ap)
 
 		/* analyze CMD_ERR */
 		cerr = readl(port + PORT_CMD_ERR);
+		ata_port_printk(ap, KERN_INFO,
+				"XXX error_intr cerr=%u\n", cerr);
 		if (cerr < ARRAY_SIZE(sil24_cerr_db))
 			ci = &sil24_cerr_db[cerr];
 

  reply	other threads:[~2008-10-27  7:38 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-11 14:27 Problem w/ hotplug on sata_sil24 w/ PMP (sil3726) Lars Michael Jogback
2008-10-14  5:51 ` Tejun Heo
2008-10-14 20:19   ` Lars Michael Jogback
2008-10-15  7:03     ` Tejun Heo
2008-10-18 16:52       ` Lars Michael Jogback
2008-10-23 18:14         ` Lars Michael Jogback
2008-10-27  7:35           ` Tejun Heo
2008-10-27  7:38             ` Tejun Heo [this message]
2008-10-27  8:47               ` Lars Michael Jogback
2008-10-27 19:40               ` Lars Michael Jogback
2008-11-10  6:47                 ` Tejun Heo
2008-11-10 18:26                   ` Lars Michael Jogback
2008-11-11  2:56                     ` Tejun Heo
     [not found] <359604ECF8F440408B9634E6146249B42923805F@mail.scl.local>
     [not found] ` <20110628095723.GC3386@htj.dyndns.org>
2011-06-30 17:53   ` Derry Bryson
2011-07-12 15:01     ` tj
2011-07-12 19:21       ` Derry Bryson
2011-07-13 13:34         ` tj
2011-07-13 14:39           ` tj
2011-07-13 16:23             ` Derry Bryson
2011-07-14  7:14               ` tj
2011-07-14 17:37                 ` Derry Bryson
2011-07-21  9:00                   ` tj
2011-07-21 16:22                     ` Derry Bryson
2011-07-22  9:50                       ` tj
2011-07-22 17:29                         ` Derry Bryson
2011-07-22 19:34                         ` Derry Bryson
2011-07-30 12:54                           ` tj
2011-09-30 21:54                             ` Mike I
2011-10-06  5:48                               ` Gwendal Grignou
     [not found]                                 ` <CAMHSBOV8rSW3jumpx8URZrgo8w1He9zruP7yAOw7uhQOaAj3Xg@mail.gmail.com>
2011-10-06  6:07                                   ` Gwendal Grignou
2011-10-08 18:25                                 ` Michael Ihrcke
2011-10-12  2:06                                   ` Michael Ihrcke
2011-10-13  2:09                                     ` Mike I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49056FEA.4070405@kernel.org \
    --to=tj@kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=lm@jogback.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.