Re: Problem w/ hotplug on sata_sil24 w/ PMP (sil3726)

[Tejun Heo <tj@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 642 bytes --]

Lars Michael Jogback wrote:
> * Tejun Heo <tj@kernel.org> [2008-10-27 16:38:18]:
> 
>> Oh.. one more thing.  Can you please try the attached patch and post the
>> failing log?
> 
> Yank the drive:
> [  423.185630] ata7: XXX error_intr irq_stat=0x8040800
> [  423.200853] ata7.02: exception Emask 0x10 SAct 0x0 SErr 0x4050000 action 0xf
> [  423.200930] ata7: SError: { PHYRdyChg CommWake DevExch }

I bought harddrive of the same generation but of lower capacity and
tested it with two 3726s but can't reproduce the problem you're
seeing.  :-(

Can you please try the attached patch and see whether anything is
different?

Thanks.

-- 
tejun

[-- Attachment #2: add-delay-after-hrst.patch --]
[-- Type: text/x-patch, Size: 392 bytes --]

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 0cd3ad4..e0dca54 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -3805,6 +3805,7 @@ int sata_std_hardreset(struct ata_link *link, unsigned int *class,
 
 	/* do hardreset */
 	rc = sata_link_hardreset(link, timing, deadline, &online, NULL);
+	msleep(500);
 	return online ? -EAGAIN : rc;
 }