All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: A patch for autotools.bbclas which correct .la file
       [not found] <20081030101903.GA8716@walkingice>
@ 2008-10-30 10:40 ` Otavio Salvador
  2008-10-30 10:57 ` Kalev Lember
  1 sibling, 0 replies; 5+ messages in thread
From: Otavio Salvador @ 2008-10-30 10:40 UTC (permalink / raw)
  To: openembedded-devel

Julian Chu <julian_chu@openmoko.com> writes:

>         The attachment is a patch which works for me. Hopes it help.

Please fix indentation; it doesn't follow the code style.

-- 
        O T A V I O    S A L V A D O R
---------------------------------------------
 E-mail: otavio@debian.org      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
 you the whole house."



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: A patch for autotools.bbclas which correct .la file
       [not found] <20081030101903.GA8716@walkingice>
  2008-10-30 10:40 ` A patch for autotools.bbclas which correct .la file Otavio Salvador
@ 2008-10-30 10:57 ` Kalev Lember
  2008-10-30 11:39   ` Holger Freyther
  1 sibling, 1 reply; 5+ messages in thread
From: Kalev Lember @ 2008-10-30 10:57 UTC (permalink / raw)
  To: openembedded-devel

Julian Chu wrote:
>         It supposed to be replaced by autotools.bbclass. However, it
>         doesn't work when a recipe inherit autotools and overwrite do_install.
>   

Hello,

I think it might not be a good idea to do it in do_install_append(),
because lots of recipes which inherit autotools bbclass also define
do_install_append(). So the current approach would fix some, but break a
set of other packages.


-- 
Kalev



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: A patch for autotools.bbclas which correct .la file
  2008-10-30 10:57 ` Kalev Lember
@ 2008-10-30 11:39   ` Holger Freyther
  2008-10-30 13:40     ` Kalev Lember
  0 siblings, 1 reply; 5+ messages in thread
From: Holger Freyther @ 2008-10-30 11:39 UTC (permalink / raw)
  To: openembedded-devel

On Thursday 30 October 2008 11:57:24 Kalev Lember wrote:

> I think it might not be a good idea to do it in do_install_append(),
> because lots of recipes which inherit autotools bbclass also define
> do_install_append(). So the current approach would fix some, but break a
> set of other packages.

why? got an example?

z.



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: A patch for autotools.bbclas which correct .la file
  2008-10-30 11:39   ` Holger Freyther
@ 2008-10-30 13:40     ` Kalev Lember
  2008-10-30 13:58       ` Rodrigo Vivi
  0 siblings, 1 reply; 5+ messages in thread
From: Kalev Lember @ 2008-10-30 13:40 UTC (permalink / raw)
  To: openembedded-devel

Holger Freyther wrote:
> On Thursday 30 October 2008 11:57:24 Kalev Lember wrote:
>   
>> I think it might not be a good idea to do it in do_install_append(),
>> because lots of recipes which inherit autotools bbclass also define
>> do_install_append(). So the current approach would fix some, but break a
>> set of other packages.
>>     
>
> why? got an example?
>   

Seems I was wrong about how _append is exactly handled. Please disregard
 my earlier mail.

Sorry for the noise.

-- 
Kalev



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: A patch for autotools.bbclas which correct .la file
  2008-10-30 13:40     ` Kalev Lember
@ 2008-10-30 13:58       ` Rodrigo Vivi
  0 siblings, 0 replies; 5+ messages in thread
From: Rodrigo Vivi @ 2008-10-30 13:58 UTC (permalink / raw)
  To: openembedded-devel

+1

We have a similar patch on mamona tree, but this one seems more complete.

On Thu, Oct 30, 2008 at 10:40 AM, Kalev Lember <kalev@smartlink.ee> wrote:
> Holger Freyther wrote:
>> On Thursday 30 October 2008 11:57:24 Kalev Lember wrote:
>>
>>> I think it might not be a good idea to do it in do_install_append(),
>>> because lots of recipes which inherit autotools bbclass also define
>>> do_install_append(). So the current approach would fix some, but break a
>>> set of other packages.
>>>
>>
>> why? got an example?
>>
>
> Seems I was wrong about how _append is exactly handled. Please disregard
>  my earlier mail.
>
> Sorry for the noise.
>
> --
> Kalev
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>



-- 
Rodrigo Vivi
INdT - Instituto Nokia de Tecnologia
Blog: http://blog.vivi.eng.br
GPG: 0x905BE242 @ wwwkeys.pgp.net



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2008-10-30 13:59 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20081030101903.GA8716@walkingice>
2008-10-30 10:40 ` A patch for autotools.bbclas which correct .la file Otavio Salvador
2008-10-30 10:57 ` Kalev Lember
2008-10-30 11:39   ` Holger Freyther
2008-10-30 13:40     ` Kalev Lember
2008-10-30 13:58       ` Rodrigo Vivi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.