All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>,
	"jens.axboe@oracle.com" <jens.axboe@oracle.com>,
	"paulmck@linux.vnet.ibm.com" <paulmck@linux.vnet.ibm.com>,
	"nickpiggin@yahoo.com.au" <nickpiggin@yahoo.com.au>,
	"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Mallick, Asit K" <asit.k.mallick@intel.com>
Subject: Re: [patch] generic-ipi: fix the smp_mb() placement
Date: Fri, 31 Oct 2008 22:12:32 +1100	[thread overview]
Message-ID: <490AE820.1010301@goop.org> (raw)
In-Reply-To: <20081031093924.GG30317@elte.hu>

Ingo Molnar wrote:
> * Jeremy Fitzhardinge <jeremy@goop.org> wrote:
>
>   
>> Suresh Siddha wrote:
>>     
>>> We didn't see the lockup in our tests but Xen folks reported similar failures
>>> with their smp call function code.
>>>   
>>>       
>> ...really?  I don't remember anything like that, but perhaps I'm 
>> forgetting something.  In Xen the IPI is sent with a hypercall, 
>> which is definitely a solid enough barrier for these purposes.
>>     
>
> i think Suresh might be referring to some of the fragilities Xen had 
> with generic-ipi. But those AFAICT were due to the on-stack lifetime 
> bug that Nick fixed via the kmalloc? v2.6.26-ish issue.

Right, that's all I could think of.

    J

  reply	other threads:[~2008-10-31 11:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-29 22:42 [patch] generic-ipi: fix the smp_mb() placement Suresh Siddha
2008-10-30  7:20 ` Jens Axboe
2008-10-30 16:30   ` Suresh Siddha
2008-10-30 17:25     ` Jens Axboe
2008-10-30 18:53 ` Ingo Molnar
2008-10-30 20:23   ` Suresh Siddha
2008-10-31  5:10     ` Jeremy Fitzhardinge
2008-10-31  9:39       ` Ingo Molnar
2008-10-31 11:12         ` Jeremy Fitzhardinge [this message]
2008-10-31 16:53           ` Suresh Siddha
2008-10-31 20:30             ` Jeremy Fitzhardinge
2008-11-03 10:17               ` Ingo Molnar
2008-11-03 23:48                 ` Jeremy Fitzhardinge
2008-11-04  9:19                   ` Ingo Molnar
2008-11-04 22:25                     ` Suresh Siddha
2008-11-05  9:20                       ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=490AE820.1010301@goop.org \
    --to=jeremy@goop.org \
    --cc=asit.k.mallick@intel.com \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=nickpiggin@yahoo.com.au \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=suresh.b.siddha@intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.