From: Paolo Abeni <pabeni@redhat.com>
To: Matthieu Baerts <matttbe@kernel.org>
Cc: Mat Martineau <martineau@kernel.org>,
Geliang Tang <geliang@kernel.org>,
David Carlier <devnexen@gmail.com>,
mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next v3 1/3] mptcp: propagate RECVERR sockopts to subflows
Date: Wed, 22 Apr 2026 15:53:37 +0200 [thread overview]
Message-ID: <490cecd3-9488-40af-9963-0c138a9fd960@redhat.com> (raw)
In-Reply-To: <0d414fe6-1775-4181-b6a7-9649c11c87ad@kernel.org>
On 4/22/26 10:50 AM, Matthieu Baerts wrote:
> On 22/04/2026 10:48, Paolo Abeni wrote:
>> AFAICS for mptcp_setsockopt_all_sf() the msk lock is acquired by the
>> caller. Same for __mptcp_setsockopt_set_val().
>>
>> Side note; AFAICS a few other paths apparently lack the setsockopt_seq;
>> that is minor problem/not a real issue: worst case it will cause a
>> redundant mptcp_sockopt_sync_locked() call at finish_join time.
>>
>> The missing sockopt_seq_inc() instead looks really bogus, as it will
>> caused missing synchronization for later subflows.
>
> Good point! Do you want me to send a patch, or do you already have one?
> (or do you plan to look at it)
Please go ahead, I'm lagging behind by far, sorry.
/P
next prev parent reply other threads:[~2026-04-22 13:53 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 22:33 [PATCH mptcp-next v3 0/3] mptcp: MSG_ERRQUEUE support on the parent socket David Carlier
2026-04-21 22:33 ` [PATCH mptcp-next v3 1/3] mptcp: propagate RECVERR sockopts to subflows David Carlier
2026-04-22 8:05 ` Paolo Abeni
2026-04-22 8:32 ` Matthieu Baerts
2026-04-22 8:35 ` Matthieu Baerts
2026-04-22 8:36 ` Matthieu Baerts
2026-04-22 8:48 ` Paolo Abeni
2026-04-22 8:50 ` Matthieu Baerts
2026-04-22 13:53 ` Paolo Abeni [this message]
2026-04-22 21:51 ` David CARLIER
2026-04-27 17:07 ` Matthieu Baerts
2026-04-21 22:33 ` [PATCH mptcp-next v3 2/3] mptcp: support MSG_ERRQUEUE on the parent socket David Carlier
2026-04-22 8:28 ` Paolo Abeni
2026-04-22 21:54 ` David CARLIER
2026-04-21 22:33 ` [PATCH mptcp-next v3 3/3] selftests: mptcp: cover IP_RECVERR sockopt propagation David Carlier
2026-04-21 23:38 ` [PATCH mptcp-next v3 0/3] mptcp: MSG_ERRQUEUE support on the parent socket MPTCP CI
2026-04-22 8:22 ` Matthieu Baerts
2026-04-22 8:56 ` David CARLIER
2026-04-27 21:10 ` [PATCH mptcp-next v4 0/4] " David Carlier
2026-04-27 21:10 ` [PATCH mptcp-next v4 1/4] mptcp: sockopt: factor inet_flags propagation into a mask David Carlier
2026-04-27 21:10 ` [PATCH mptcp-next v4 2/4] mptcp: propagate RECVERR sockopts to subflows David Carlier
2026-05-01 15:56 ` Matthieu Baerts
2026-04-27 21:10 ` [PATCH mptcp-next v4 3/4] mptcp: support MSG_ERRQUEUE on the parent socket David Carlier
2026-04-27 21:10 ` [PATCH mptcp-next v4 4/4] selftests: mptcp: cover IP_RECVERR sockopt propagation David Carlier
2026-04-28 18:48 ` [PATCH mptcp-next v4 0/4] mptcp: MSG_ERRQUEUE support on the parent socket Matthieu Baerts
2026-04-28 18:56 ` Matthieu Baerts
2026-04-28 19:15 ` David CARLIER
2026-05-01 14:49 ` Matthieu Baerts
2026-05-01 15:28 ` David CARLIER
2026-05-01 15:56 ` Matthieu Baerts
2026-04-28 19:48 ` MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490cecd3-9488-40af-9963-0c138a9fd960@redhat.com \
--to=pabeni@redhat.com \
--cc=devnexen@gmail.com \
--cc=geliang@kernel.org \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.