Re: [PATCH mptcp-next v4 0/4] mptcp: MSG_ERRQUEUE support on the parent socket

[Matthieu Baerts <matttbe@kernel.org>]

On 28/04/2026 20:48, Matthieu Baerts wrote:
> Hi David,
> 
> Thank you for the new version.
> 
> On 27/04/2026 23:10, David Carlier wrote:
>> MPTCP already advertises IP_RECVERR/IPV6_RECVERR as supported, but the
>> parent socket does not currently provide usable MSG_ERRQUEUE handling.
>>
>> This series wires the MPTCP socket up to the IPv4/IPv6 error queue
>> paths. It propagates RECVERR-related sockopts to existing and future
>> subflows, makes poll() report pending errqueue activity through the
>> parent socket, and lets recvmsg(MSG_ERRQUEUE) on the MPTCP socket
>> consume queued errors with the parent socket ABI.
>>
>> A new prerequisite patch factors the per-flag inet_flags propagation
>> in sync_socket_options() into a single masked word copy, so further
>> inet_flags propagated by MPTCP can be added by extending the mask
>> rather than touching the call site.
>>
>> Patch 2 then leverages the existing mptcp_setsockopt_all_sf() helper
>> for the setsockopt path and extends MPTCP_INET_FLAGS_MASK with the
>> four RECVERR bits, dropping the family-specific helpers from v3.
>>
>> Based-on: <20260424-mptcp-pm-sockopt-set-all-sf-v1-1-38e7023822f8@kernel.org>
> 
> I didn't review it, but I notice that the CI cannot apply your series,
> because it looks like it is not based on the one you mentioned here.
> 
> Can you either remove this line, or rebase your series on top of this
> other patch?
> 
> Also, please don't send your series as a reply to a previous posting,
> please use a new thread. That's what is usually done, clearer, plus some
> tools don't support replies.

Note: I just manually resolved the conflicts and sent the series to the
CI, not to have to resend a series just to retrigger the CI.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.