All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Eder <hannes@hanneseder.net>
To: "David S. Miller" <davem@davemloft.net>
Subject: [PATCH] pkt_sched: fix sparse warning
Date: Thu, 27 Nov 2008 19:33:17 +0000	[thread overview]
Message-ID: <492fbbfd.190c660a.1db3.fffffcc3@mx.google.com> (raw)

Impact: make global function static

Fix the following sparse warning:

  net/sched/sch_api.c:192:14: warning: symbol 'qdisc_match_from_root' was not declared. Should it be static?

Signed-off-by: Hannes Eder <hannes@hanneseder.net>
---
 net/sched/sch_api.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
index f859dd5..6bc29e8 100644
--- a/net/sched/sch_api.c
+++ b/net/sched/sch_api.c
@@ -189,7 +189,7 @@ EXPORT_SYMBOL(unregister_qdisc);
    (root qdisc, all its children, children of children etc.)
  */
 
-struct Qdisc *qdisc_match_from_root(struct Qdisc *root, u32 handle)
+static struct Qdisc *qdisc_match_from_root(struct Qdisc *root, u32 handle)
 {
 	struct Qdisc *q;
 
-- 
1.5.6.3


WARNING: multiple messages have this Message-ID (diff)
From: Hannes Eder <hannes@hanneseder.net>
To: "David S. Miller" <davem@davemloft.net>
To: netdev@vger.kernel.org
To: linux-kernel@vger.kernel.org
To: kernel-janitors@vger.kernel.org
Subject: [PATCH] pkt_sched: fix sparse warning
Date: Thu, 27 Nov 2008 20:33:17 +0100	[thread overview]
Message-ID: <492fbbfd.190c660a.1db3.fffffcc3@mx.google.com> (raw)

Impact: make global function static

Fix the following sparse warning:

  net/sched/sch_api.c:192:14: warning: symbol 'qdisc_match_from_root' was not declared. Should it be static?

Signed-off-by: Hannes Eder <hannes@hanneseder.net>
---
 net/sched/sch_api.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
index f859dd5..6bc29e8 100644
--- a/net/sched/sch_api.c
+++ b/net/sched/sch_api.c
@@ -189,7 +189,7 @@ EXPORT_SYMBOL(unregister_qdisc);
    (root qdisc, all its children, children of children etc.)
  */
 
-struct Qdisc *qdisc_match_from_root(struct Qdisc *root, u32 handle)
+static struct Qdisc *qdisc_match_from_root(struct Qdisc *root, u32 handle)
 {
 	struct Qdisc *q;
 
-- 
1.5.6.3


             reply	other threads:[~2008-11-27 19:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-27 19:33 Hannes Eder [this message]
2008-11-27 19:33 ` [PATCH] pkt_sched: fix sparse warning Hannes Eder
2008-11-28 11:07 ` David Miller
2008-11-28 11:07   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=492fbbfd.190c660a.1db3.fffffcc3@mx.google.com \
    --to=hannes@hanneseder.net \
    --cc=davem@davemloft.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.