* [PATCH] pkt_sched: fix sparse warning
@ 2008-11-27 19:33 ` Hannes Eder
0 siblings, 0 replies; 4+ messages in thread
From: Hannes Eder @ 2008-11-27 19:33 UTC (permalink / raw)
To: David S. Miller
Impact: make global function static
Fix the following sparse warning:
net/sched/sch_api.c:192:14: warning: symbol 'qdisc_match_from_root' was not declared. Should it be static?
Signed-off-by: Hannes Eder <hannes@hanneseder.net>
---
net/sched/sch_api.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
index f859dd5..6bc29e8 100644
--- a/net/sched/sch_api.c
+++ b/net/sched/sch_api.c
@@ -189,7 +189,7 @@ EXPORT_SYMBOL(unregister_qdisc);
(root qdisc, all its children, children of children etc.)
*/
-struct Qdisc *qdisc_match_from_root(struct Qdisc *root, u32 handle)
+static struct Qdisc *qdisc_match_from_root(struct Qdisc *root, u32 handle)
{
struct Qdisc *q;
--
1.5.6.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] pkt_sched: fix sparse warning
@ 2008-11-27 19:33 ` Hannes Eder
0 siblings, 0 replies; 4+ messages in thread
From: Hannes Eder @ 2008-11-27 19:33 UTC (permalink / raw)
To: David S. Miller, netdev, linux-kernel, kernel-janitors
Impact: make global function static
Fix the following sparse warning:
net/sched/sch_api.c:192:14: warning: symbol 'qdisc_match_from_root' was not declared. Should it be static?
Signed-off-by: Hannes Eder <hannes@hanneseder.net>
---
net/sched/sch_api.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
index f859dd5..6bc29e8 100644
--- a/net/sched/sch_api.c
+++ b/net/sched/sch_api.c
@@ -189,7 +189,7 @@ EXPORT_SYMBOL(unregister_qdisc);
(root qdisc, all its children, children of children etc.)
*/
-struct Qdisc *qdisc_match_from_root(struct Qdisc *root, u32 handle)
+static struct Qdisc *qdisc_match_from_root(struct Qdisc *root, u32 handle)
{
struct Qdisc *q;
--
1.5.6.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] pkt_sched: fix sparse warning
2008-11-27 19:33 ` Hannes Eder
@ 2008-11-28 11:07 ` David Miller
-1 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2008-11-28 11:07 UTC (permalink / raw)
To: hannes; +Cc: netdev, linux-kernel, kernel-janitors
From: Hannes Eder <hannes@hanneseder.net>
Date: Thu, 27 Nov 2008 20:33:17 +0100
> Impact: make global function static
>
> Fix the following sparse warning:
>
> net/sched/sch_api.c:192:14: warning: symbol 'qdisc_match_from_root' was not declared. Should it be static?
>
> Signed-off-by: Hannes Eder <hannes@hanneseder.net>
Applied, thanks Hannes.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pkt_sched: fix sparse warning
@ 2008-11-28 11:07 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2008-11-28 11:07 UTC (permalink / raw)
To: hannes; +Cc: netdev, linux-kernel, kernel-janitors
From: Hannes Eder <hannes@hanneseder.net>
Date: Thu, 27 Nov 2008 20:33:17 +0100
> Impact: make global function static
>
> Fix the following sparse warning:
>
> net/sched/sch_api.c:192:14: warning: symbol 'qdisc_match_from_root' was not declared. Should it be static?
>
> Signed-off-by: Hannes Eder <hannes@hanneseder.net>
Applied, thanks Hannes.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-11-28 11:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-27 19:33 [PATCH] pkt_sched: fix sparse warning Hannes Eder
2008-11-27 19:33 ` Hannes Eder
2008-11-28 11:07 ` David Miller
2008-11-28 11:07 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.