Help with Creative's X-Fi drivers

Help with Creative's X-Fi drivers

[James Pearson]

I know the ALSA team don't support Creative's X-Fi drivers, but maybe 
someone could help with this issue:

I've managed to 'backport' Creative's recently GPL'd drivers to run on a 
CentOS4 kernel with ALSA 1.0.15 - the changes to the code were minor, 
but one thing I'm not sure about is, in ctpcm.c it has:

static int ct_pcm_timer_stop(struct ct_atc_pcm *apcm)
{
         unsigned long flags;

         CTDPF("%s is called\n", __func__);

         spin_lock_irqsave(&apcm->timer_lock, flags);
         apcm->stop_timer = 1;
         del_timer(&apcm->timer);
         spin_unlock_irqrestore(&apcm->timer_lock, flags);

         try_to_del_timer_sync(&apcm->timer);

         return 0;
}


The CentOS4/RHEL4 2.6.9 kernel doesn't have try_to_del_timer_sync() - 
so, should I replace it with del_timer() or del_timer_sync() ?

I'm currently using del_timer_sync() - and the driver works (I get sound 
out the head phone jack) - is this OK?

Thanks

James Pearson

Re: Help with Creative's X-Fi drivers

[The Source]

James Pearson пишет:
> I know the ALSA team don't support Creative's X-Fi drivers, but maybe 
> someone could help with this issue:
>
> I've managed to 'backport' Creative's recently GPL'd drivers to run on a 
> CentOS4 kernel with ALSA 1.0.15 - the changes to the code were minor, 
> but one thing I'm not sure about is, in ctpcm.c it has:
>
> static int ct_pcm_timer_stop(struct ct_atc_pcm *apcm)
> {
>          unsigned long flags;
>
>          CTDPF("%s is called\n", __func__);
>
>          spin_lock_irqsave(&apcm->timer_lock, flags);
>          apcm->stop_timer = 1;
>          del_timer(&apcm->timer);
>          spin_unlock_irqrestore(&apcm->timer_lock, flags);
>
>          try_to_del_timer_sync(&apcm->timer);
>
>          return 0;
> }
>
>
> The CentOS4/RHEL4 2.6.9 kernel doesn't have try_to_del_timer_sync() - 
> so, should I replace it with del_timer() or del_timer_sync() ?
>
> I'm currently using del_timer_sync() - and the driver works (I get sound 
> out the head phone jack) - is this OK?
>
> Thanks
>
> James Pearson
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
>   
It should be ok, my friend used the similar change to complile driver 
for his kernel and it works so far.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: Help with Creative's X-Fi drivers

[William Pitcock]

[-- Attachment #1.1: Type: text/plain, Size: 194 bytes --]

On Fri, 2008-11-28 at 17:17 +0000, James Pearson wrote:
> I'm currently using del_timer_sync() - and the driver works (I get
> sound out the head phone jack) - is this OK?

Yes.

William

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: Help with Creative's X-Fi drivers

[James Pearson]

William Pitcock wrote:
> On Fri, 2008-11-28 at 17:17 +0000, James Pearson wrote:
> 
>>I'm currently using del_timer_sync() - and the driver works (I get
>>sound out the head phone jack) - is this OK?
> 
> 
> Yes.

Thanks

James Pearson