From: roel kluin <roel.kluin@gmail.com>
To: Andreas Schwab <schwab@suse.de>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: powerpc: hv{cs, si}_close() both unsigned hp->count and hvcsd->open_count cannot be negative
Date: Sat, 29 Nov 2008 08:27:16 -0500 [thread overview]
Message-ID: <49314334.6060609@gmail.com> (raw)
In-Reply-To: <jey6z24rqw.fsf@sykes.suse.de>
Andreas Schwab wrote:
> roel kluin <roel.kluin@gmail.com> writes:
>
>> - if (--hvcsd->open_count == 0) {
>> + if (hvcsd->open_count == 1) {
>> + hvcsd->open_count--;
>
> This is not the same.
I think you're missing that I also decrement if (hvcsd->open_count > 1)
If not, please elaborate.
>
>> - if (--hp->count == 0) {
>> + if (hp->count == 1) {
>> + hp->count--;
>
> Likewise.
Same here.
Roel
WARNING: multiple messages have this Message-ID (diff)
From: roel kluin <roel.kluin@gmail.com>
To: Andreas Schwab <schwab@suse.de>
Cc: benh@kernel.crashing.org, linuxppc-dev@ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: powerpc: hv{cs,si}_close() both unsigned hp->count and hvcsd->open_count cannot be negative
Date: Sat, 29 Nov 2008 08:27:16 -0500 [thread overview]
Message-ID: <49314334.6060609@gmail.com> (raw)
In-Reply-To: <jey6z24rqw.fsf@sykes.suse.de>
Andreas Schwab wrote:
> roel kluin <roel.kluin@gmail.com> writes:
>
>> - if (--hvcsd->open_count == 0) {
>> + if (hvcsd->open_count == 1) {
>> + hvcsd->open_count--;
>
> This is not the same.
I think you're missing that I also decrement if (hvcsd->open_count > 1)
If not, please elaborate.
>
>> - if (--hp->count == 0) {
>> + if (hp->count == 1) {
>> + hp->count--;
>
> Likewise.
Same here.
Roel
next prev parent reply other threads:[~2008-11-29 13:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-29 10:57 powerpc: hv{cs, si}_close() both unsigned hp->count and hvcsd->open_count cannot be negative roel kluin
2008-11-29 10:57 ` powerpc: hv{cs,si}_close() " roel kluin
2008-11-29 12:54 ` powerpc: hv{cs, si}_close() " Andreas Schwab
2008-11-29 12:54 ` powerpc: hv{cs,si}_close() " Andreas Schwab
2008-11-29 13:27 ` roel kluin [this message]
2008-11-29 13:27 ` roel kluin
2008-11-29 15:01 ` powerpc: hv{cs, si}_close() " Andreas Schwab
2008-11-29 15:01 ` powerpc: hv{cs,si}_close() " Andreas Schwab
2008-11-29 23:20 ` powerpc: hv{cs, si}_close() " Paul Mackerras
2008-11-29 23:20 ` Paul Mackerras
2008-11-30 11:16 ` Alan Cox
2008-11-30 11:16 ` Alan Cox
2008-11-30 21:23 ` Paul Mackerras
2008-11-30 21:23 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49314334.6060609@gmail.com \
--to=roel.kluin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.