From: Andreas Schwab <schwab@suse.de>
To: roel kluin <roel.kluin@gmail.com>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: powerpc: hv{cs, si}_close() both unsigned hp->count and hvcsd->open_count cannot be negative
Date: Sat, 29 Nov 2008 16:01:47 +0100 [thread overview]
Message-ID: <jetz9q4lus.fsf@sykes.suse.de> (raw)
In-Reply-To: <49314334.6060609@gmail.com> (roel kluin's message of "Sat, 29 Nov 2008 08:27:16 -0500")
roel kluin <roel.kluin@gmail.com> writes:
> Andreas Schwab wrote:
>> roel kluin <roel.kluin@gmail.com> writes:
>>
>>> - if (--hvcsd->open_count == 0) {
>>> + if (hvcsd->open_count == 1) {
>>> + hvcsd->open_count--;
>>
>> This is not the same.
>
> I think you're missing that I also decrement if (hvcsd->open_count > 1)
Yes, sorry, I missed that.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
WARNING: multiple messages have this Message-ID (diff)
From: Andreas Schwab <schwab@suse.de>
To: roel kluin <roel.kluin@gmail.com>
Cc: benh@kernel.crashing.org, linuxppc-dev@ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: powerpc: hv{cs,si}_close() both unsigned hp->count and hvcsd->open_count cannot be negative
Date: Sat, 29 Nov 2008 16:01:47 +0100 [thread overview]
Message-ID: <jetz9q4lus.fsf@sykes.suse.de> (raw)
In-Reply-To: <49314334.6060609@gmail.com> (roel kluin's message of "Sat, 29 Nov 2008 08:27:16 -0500")
roel kluin <roel.kluin@gmail.com> writes:
> Andreas Schwab wrote:
>> roel kluin <roel.kluin@gmail.com> writes:
>>
>>> - if (--hvcsd->open_count == 0) {
>>> + if (hvcsd->open_count == 1) {
>>> + hvcsd->open_count--;
>>
>> This is not the same.
>
> I think you're missing that I also decrement if (hvcsd->open_count > 1)
Yes, sorry, I missed that.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2008-11-29 15:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-29 10:57 powerpc: hv{cs, si}_close() both unsigned hp->count and hvcsd->open_count cannot be negative roel kluin
2008-11-29 10:57 ` powerpc: hv{cs,si}_close() " roel kluin
2008-11-29 12:54 ` powerpc: hv{cs, si}_close() " Andreas Schwab
2008-11-29 12:54 ` powerpc: hv{cs,si}_close() " Andreas Schwab
2008-11-29 13:27 ` powerpc: hv{cs, si}_close() " roel kluin
2008-11-29 13:27 ` powerpc: hv{cs,si}_close() " roel kluin
2008-11-29 15:01 ` Andreas Schwab [this message]
2008-11-29 15:01 ` Andreas Schwab
2008-11-29 23:20 ` powerpc: hv{cs, si}_close() " Paul Mackerras
2008-11-29 23:20 ` Paul Mackerras
2008-11-30 11:16 ` Alan Cox
2008-11-30 11:16 ` Alan Cox
2008-11-30 21:23 ` Paul Mackerras
2008-11-30 21:23 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jetz9q4lus.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.