From: Anthony Liguori <anthony@codemonkey.ws>
To: Glauber Costa <glommer@redhat.com>
Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] extboot: properly set int 0x13 return value
Date: Mon, 01 Dec 2008 14:20:43 -0600 [thread overview]
Message-ID: <4934471B.30606@codemonkey.ws> (raw)
In-Reply-To: <1228160470-11764-1-git-send-email-glommer@redhat.com>
Glauber Costa wrote:
> Callers of int 0x13 usually rely on the carry flag being
> clear/set to indicate the status of the interrupt execution.
>
> However, our current code clear or set the flags register,
> which is totally useless. Whichever value it has, will
> be overwritten by the flags value _before_ the interrupt, due to
> the iret instruction.
>
> This fixes a bug that prevents slackware (and possibly win2k, untested)
> to boot.
>
Good catch!
> Signed-off-by: Glauber Costa <glommer@redhat.com>
>
>
Acked-by: Anthony Liguori <aliguori@us.ibm.com>
Regards,
Anthony Liguori
WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <anthony@codemonkey.ws>
To: Glauber Costa <glommer@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: [Qemu-devel] Re: [PATCH] extboot: properly set int 0x13 return value
Date: Mon, 01 Dec 2008 14:20:43 -0600 [thread overview]
Message-ID: <4934471B.30606@codemonkey.ws> (raw)
In-Reply-To: <1228160470-11764-1-git-send-email-glommer@redhat.com>
Glauber Costa wrote:
> Callers of int 0x13 usually rely on the carry flag being
> clear/set to indicate the status of the interrupt execution.
>
> However, our current code clear or set the flags register,
> which is totally useless. Whichever value it has, will
> be overwritten by the flags value _before_ the interrupt, due to
> the iret instruction.
>
> This fixes a bug that prevents slackware (and possibly win2k, untested)
> to boot.
>
Good catch!
> Signed-off-by: Glauber Costa <glommer@redhat.com>
>
>
Acked-by: Anthony Liguori <aliguori@us.ibm.com>
Regards,
Anthony Liguori
next prev parent reply other threads:[~2008-12-01 20:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-01 19:41 [PATCH] extboot: properly set int 0x13 return value Glauber Costa
2008-12-01 19:41 ` [Qemu-devel] " Glauber Costa
2008-12-01 20:20 ` Anthony Liguori [this message]
2008-12-01 20:20 ` [Qemu-devel] " Anthony Liguori
-- strict thread matches above, loose matches on Subject: below --
2008-12-01 20:01 Glauber Costa
2008-12-02 12:12 ` Avi Kivity
2008-12-02 14:20 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4934471B.30606@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.