All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@us.ibm.com>
To: Avi Kivity <avi@redhat.com>
Cc: Glauber Costa <glommer@redhat.com>,
	kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] extboot: properly set int 0x13 return value
Date: Tue, 02 Dec 2008 08:20:35 -0600	[thread overview]
Message-ID: <49354433.7060706@us.ibm.com> (raw)
In-Reply-To: <4935264A.4050006@redhat.com>

Avi Kivity wrote:
> Applied, thanks.
>
>>  
>> -.macro clc
>> -    push %ax
>> -    pushf
>> -    pop %ax
>> -    and $(~FLAGS_CF), %ax
>> -    push %ax
>> -    popf
>> -    pop %ax
>>   
>
> Anthony, any reason you did not use the 'clc' instruction instead of a 
> macro?

Propensity for pain?

I have no idea.  I assume I had a reason at the time.  Probably debug 
related.

Regards,

Anthony Liguori


WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <aliguori@us.ibm.com>
To: Avi Kivity <avi@redhat.com>
Cc: Glauber Costa <glommer@redhat.com>,
	qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: [Qemu-devel] Re: [PATCH] extboot: properly set int 0x13 return value
Date: Tue, 02 Dec 2008 08:20:35 -0600	[thread overview]
Message-ID: <49354433.7060706@us.ibm.com> (raw)
In-Reply-To: <4935264A.4050006@redhat.com>

Avi Kivity wrote:
> Applied, thanks.
>
>>  
>> -.macro clc
>> -    push %ax
>> -    pushf
>> -    pop %ax
>> -    and $(~FLAGS_CF), %ax
>> -    push %ax
>> -    popf
>> -    pop %ax
>>   
>
> Anthony, any reason you did not use the 'clc' instruction instead of a 
> macro?

Propensity for pain?

I have no idea.  I assume I had a reason at the time.  Probably debug 
related.

Regards,

Anthony Liguori

  reply	other threads:[~2008-12-02 14:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-01 20:01 [PATCH] extboot: properly set int 0x13 return value Glauber Costa
2008-12-01 20:01 ` [Qemu-devel] " Glauber Costa
2008-12-02 12:12 ` Avi Kivity
2008-12-02 12:12   ` [Qemu-devel] " Avi Kivity
2008-12-02 14:20   ` Anthony Liguori [this message]
2008-12-02 14:20     ` Anthony Liguori
  -- strict thread matches above, loose matches on Subject: below --
2008-12-01 19:41 Glauber Costa
2008-12-01 20:20 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49354433.7060706@us.ibm.com \
    --to=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=glommer@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.