Re: [Qemu-devel] [PATCH 2/2] Virtio block device support

[Anthony Liguori <aliguori@us.ibm.com>]

Hollis Blanchard wrote:
> On Tue, 2008-11-25 at 15:57 -0600, Anthony Liguori wrote:
>   
>> diff --git a/hw/pc.h b/hw/pc.h
>> index f156b9e..bbfa2d6 100644
>> --- a/hw/pc.h
>> +++ b/hw/pc.h
>> @@ -152,4 +152,8 @@ void pci_piix4_ide_init(PCIBus *bus,
>> BlockDriverState **hd_table, int devfn,
>>
>>  void isa_ne2000_init(int base, qemu_irq irq, NICInfo *nd);
>>
>> +/* virtio-blk.c */
>> +void *virtio_blk_init(PCIBus *bus, uint16_t vendor, uint16_t device,
>> +                      BlockDriverState *bs);
>> +
>>  #endif
>>     
>
> This shouldn't be in pc.h.

I don't disagree.

>  I don't know if you'd consider virtio.h to be
> a layering violation, but the virtio layers are already being compressed
> in these patches...
>   

Yeah, I think the virtio stuff could use some love but I'd like to avoid 
that until we have something in tree and merged against kvm-userspace.

Regards,

Anthony Liguori