From: Anthony Liguori <aliguori@us.ibm.com>
To: Hollis Blanchard <hollisb@us.ibm.com>
Cc: qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH] [v2] Remove TARGET_PAGE_SIZE from virtio interface
Date: Thu, 04 Dec 2008 13:58:58 -0600 [thread overview]
Message-ID: <49383682.10309@us.ibm.com> (raw)
In-Reply-To: <1228155570-9913-1-git-send-email-hollisb@us.ibm.com>
Hollis Blanchard wrote:
> TARGET_PAGE_SIZE should only be used internal to qemu, not in guest/host
> interfaces. The virtio frontend code in Linux uses two constants (PFN shift
> and vring alignment) for the interface, so update qemu to match.
>
> I've tested this with PowerPC KVM and confirmed that it fixes virtio problems
> when using non-TARGET_PAGE_SIZE pages in the guest.
>
Applied. Thanks.
Regards,
Anthony Liguori
WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <aliguori@us.ibm.com>
To: Hollis Blanchard <hollisb@us.ibm.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>
Subject: [Qemu-devel] Re: [PATCH] [v2] Remove TARGET_PAGE_SIZE from virtio interface
Date: Thu, 04 Dec 2008 13:58:58 -0600 [thread overview]
Message-ID: <49383682.10309@us.ibm.com> (raw)
In-Reply-To: <1228155570-9913-1-git-send-email-hollisb@us.ibm.com>
Hollis Blanchard wrote:
> TARGET_PAGE_SIZE should only be used internal to qemu, not in guest/host
> interfaces. The virtio frontend code in Linux uses two constants (PFN shift
> and vring alignment) for the interface, so update qemu to match.
>
> I've tested this with PowerPC KVM and confirmed that it fixes virtio problems
> when using non-TARGET_PAGE_SIZE pages in the guest.
>
Applied. Thanks.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2008-12-04 19:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-25 21:57 [PATCH 1/2] Virtio core support Anthony Liguori
2008-11-25 21:57 ` [Qemu-devel] " Anthony Liguori
2008-11-25 21:57 ` [PATCH 2/2] Virtio block device support Anthony Liguori
2008-11-25 21:57 ` [Qemu-devel] " Anthony Liguori
2008-11-26 18:24 ` Hollis Blanchard
2008-12-01 20:20 ` Hollis Blanchard
2008-12-01 20:22 ` Anthony Liguori
2008-12-01 20:22 ` Anthony Liguori
2008-11-26 18:11 ` [PATCH 1/1] " Hollis Blanchard
2008-11-26 18:11 ` [Qemu-devel] " Hollis Blanchard
2008-11-26 18:17 ` Hollis Blanchard
2008-11-26 18:17 ` Hollis Blanchard
2008-11-26 18:22 ` [PATCH] Remove TARGET_PAGE_SIZE from virtio interface Hollis Blanchard
2008-11-26 18:22 ` [Qemu-devel] " Hollis Blanchard
2008-11-26 18:29 ` Hollis Blanchard
2008-11-26 18:29 ` [Qemu-devel] " Hollis Blanchard
2008-12-01 18:19 ` [PATCH] [v2] " Hollis Blanchard
2008-12-01 18:19 ` [Qemu-devel] " Hollis Blanchard
2008-12-04 19:58 ` Anthony Liguori [this message]
2008-12-04 19:58 ` [Qemu-devel] " Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49383682.10309@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=hollisb@us.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.