* [lm-sensors] [PATCH] hwmon: Fix various typos
@ 2008-12-09 15:37 Jean Delvare
2008-12-09 19:00 ` Hans de Goede
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jean Delvare @ 2008-12-09 15:37 UTC (permalink / raw)
To: lm-sensors
Signed-off-by: Jean Delvare <khali@linux-fr.org>
---
Documentation/hwmon/lm85 | 2 +-
drivers/hwmon/it87.c | 2 +-
drivers/hwmon/w83627ehf.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
--- linux-2.6.28-rc7.orig/drivers/hwmon/w83627ehf.c 2008-12-05 23:58:15.000000000 +0100
+++ linux-2.6.28-rc7/drivers/hwmon/w83627ehf.c 2008-12-08 10:48:34.000000000 +0100
@@ -503,7 +503,7 @@ static struct w83627ehf_data *w83627ehf_
}
for (i = 0; i < 4; i++) {
- /* pwmcfg, tolarance mapped for i=0, i=1 to same reg */
+ /* pwmcfg, tolerance mapped for i=0, i=1 to same reg */
if (i != 1) {
pwmcfg = w83627ehf_read_value(data,
W83627EHF_REG_PWM_ENABLE[i]);
--- linux-2.6.28-rc7.orig/Documentation/hwmon/lm85 2008-10-24 09:27:31.000000000 +0200
+++ linux-2.6.28-rc7/Documentation/hwmon/lm85 2008-12-08 10:48:34.000000000 +0100
@@ -164,7 +164,7 @@ configured individually according to the
temperature. (PWM value from 0 to 255)
* pwm#_auto_pwm_minctl - this flags selects for temp#_auto_temp_off temperature
- the bahaviour of fans. Write 1 to let fans spinning at
+ the behaviour of fans. Write 1 to let fans spinning at
pwm#_auto_pwm_min or write 0 to let them off.
NOTE: It has been reported that there is a bug in the LM85 that causes the flag
--- linux-2.6.28-rc7.orig/drivers/hwmon/it87.c 2008-12-05 23:58:15.000000000 +0100
+++ linux-2.6.28-rc7/drivers/hwmon/it87.c 2008-12-08 10:48:49.000000000 +0100
@@ -1386,7 +1386,7 @@ static void __devinit it87_init_device(s
it87_write_value(data, IT87_REG_TEMP_HIGH(i), 127);
}
- /* Check if temperature channnels are reset manually or by some reason */
+ /* Check if temperature channels are reset manually or by some reason */
tmp = it87_read_value(data, IT87_REG_TEMP_ENABLE);
if ((tmp & 0x3f) = 0) {
/* Temp1,Temp3=thermistor; Temp2=thermal diode */
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [lm-sensors] [PATCH] hwmon: Fix various typos
2008-12-09 15:37 [lm-sensors] [PATCH] hwmon: Fix various typos Jean Delvare
@ 2008-12-09 19:00 ` Hans de Goede
2008-12-09 20:01 ` David Hubbard
2008-12-09 20:33 ` Jean Delvare
2 siblings, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2008-12-09 19:00 UTC (permalink / raw)
To: lm-sensors
Jean Delvare wrote:
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> ---
> Documentation/hwmon/lm85 | 2 +-
> drivers/hwmon/it87.c | 2 +-
> drivers/hwmon/w83627ehf.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
Looks good to me :)
Regards,
Hans
> --- linux-2.6.28-rc7.orig/drivers/hwmon/w83627ehf.c 2008-12-05 23:58:15.000000000 +0100
> +++ linux-2.6.28-rc7/drivers/hwmon/w83627ehf.c 2008-12-08 10:48:34.000000000 +0100
> @@ -503,7 +503,7 @@ static struct w83627ehf_data *w83627ehf_
> }
>
> for (i = 0; i < 4; i++) {
> - /* pwmcfg, tolarance mapped for i=0, i=1 to same reg */
> + /* pwmcfg, tolerance mapped for i=0, i=1 to same reg */
> if (i != 1) {
> pwmcfg = w83627ehf_read_value(data,
> W83627EHF_REG_PWM_ENABLE[i]);
> --- linux-2.6.28-rc7.orig/Documentation/hwmon/lm85 2008-10-24 09:27:31.000000000 +0200
> +++ linux-2.6.28-rc7/Documentation/hwmon/lm85 2008-12-08 10:48:34.000000000 +0100
> @@ -164,7 +164,7 @@ configured individually according to the
> temperature. (PWM value from 0 to 255)
>
> * pwm#_auto_pwm_minctl - this flags selects for temp#_auto_temp_off temperature
> - the bahaviour of fans. Write 1 to let fans spinning at
> + the behaviour of fans. Write 1 to let fans spinning at
> pwm#_auto_pwm_min or write 0 to let them off.
>
> NOTE: It has been reported that there is a bug in the LM85 that causes the flag
> --- linux-2.6.28-rc7.orig/drivers/hwmon/it87.c 2008-12-05 23:58:15.000000000 +0100
> +++ linux-2.6.28-rc7/drivers/hwmon/it87.c 2008-12-08 10:48:49.000000000 +0100
> @@ -1386,7 +1386,7 @@ static void __devinit it87_init_device(s
> it87_write_value(data, IT87_REG_TEMP_HIGH(i), 127);
> }
>
> - /* Check if temperature channnels are reset manually or by some reason */
> + /* Check if temperature channels are reset manually or by some reason */
> tmp = it87_read_value(data, IT87_REG_TEMP_ENABLE);
> if ((tmp & 0x3f) = 0) {
> /* Temp1,Temp3=thermistor; Temp2=thermal diode */
>
>
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [lm-sensors] [PATCH] hwmon: Fix various typos
2008-12-09 15:37 [lm-sensors] [PATCH] hwmon: Fix various typos Jean Delvare
2008-12-09 19:00 ` Hans de Goede
@ 2008-12-09 20:01 ` David Hubbard
2008-12-09 20:33 ` Jean Delvare
2 siblings, 0 replies; 4+ messages in thread
From: David Hubbard @ 2008-12-09 20:01 UTC (permalink / raw)
To: lm-sensors
ack both patches (ACPI resources and typo fixes)
Signed-off-by: David Hubbard <david.c.hubbard@gmail.com>
P.S. I have found a bug in the way the init code in w83627ehf puts the
base address into the data structure, so it ends up accessing the
device at 0x290 when it should be 0x295. I'll send out a patch in a
few days.
On Tue, Dec 9, 2008 at 12:00 PM, Hans de Goede <j.w.r.degoede@hhs.nl> wrote:
> Jean Delvare wrote:
>> Signed-off-by: Jean Delvare <khali@linux-fr.org>
>> ---
>> Documentation/hwmon/lm85 | 2 +-
>> drivers/hwmon/it87.c | 2 +-
>> drivers/hwmon/w83627ehf.c | 2 +-
>> 3 files changed, 3 insertions(+), 3 deletions(-)
>>
>
> Looks good to me :)
>
> Regards,
>
> Hans
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [lm-sensors] [PATCH] hwmon: Fix various typos
2008-12-09 15:37 [lm-sensors] [PATCH] hwmon: Fix various typos Jean Delvare
2008-12-09 19:00 ` Hans de Goede
2008-12-09 20:01 ` David Hubbard
@ 2008-12-09 20:33 ` Jean Delvare
2 siblings, 0 replies; 4+ messages in thread
From: Jean Delvare @ 2008-12-09 20:33 UTC (permalink / raw)
To: lm-sensors
Hi David,
On Tue, 9 Dec 2008 13:01:03 -0700, David Hubbard wrote:
> ack both patches (ACPI resources and typo fixes)
>
> Signed-off-by: David Hubbard <david.c.hubbard@gmail.com>
Actually these are Acked-by, as the patch didn't transit through you.
But thanks anyway :)
> P.S. I have found a bug in the way the init code in w83627ehf puts the
> base address into the data structure, so it ends up accessing the
> device at 0x290 when it should be 0x295. I'll send out a patch in a
> few days.
OK, I'll test and review it when you do.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-12-09 20:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-09 15:37 [lm-sensors] [PATCH] hwmon: Fix various typos Jean Delvare
2008-12-09 19:00 ` Hans de Goede
2008-12-09 20:01 ` David Hubbard
2008-12-09 20:33 ` Jean Delvare
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.