From: "Jan Beulich" <jbeulich@novell.com>
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: Yunhong Jiang <yunhong.jiang@intel.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH][RFC] Support S3 for MSI interrupt in latest kernel dom0
Date: Wed, 17 Dec 2008 15:31:06 +0000 [thread overview]
Message-ID: <4949294A.76E4.0078.0@novell.com> (raw)
In-Reply-To: <C56EC9A6.20575%keir.fraser@eu.citrix.com>
>>> Keir Fraser <keir.fraser@eu.citrix.com> 17.12.08 16:22 >>>
>Well, maybe it's okay then. I don't think Yunhong's patch was a good
>argument for it -- looking again it appears to have plenty of not really
>related chunks contained in it.
I don't think it's really okay as-is: As he indicated, there may be side
effects of the changes during other than resume from S3 (in particular
the IRQ_GUEST check around the newly added call to ->startup()), and
I was hoping you might have a suggestion on how to better distinguish
that particular case. In the worst case, Xen has to set another flag in
each MSI irq_desc when it resumes from S3, and do the startup as well
as the clearing of the flag when map_domain_pirq runs first for that
particular vector.
Jan
next prev parent reply other threads:[~2008-12-17 15:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-17 12:11 [PATCH][RFC] Support S3 for MSI interrupt in latest kernel dom0 Jiang, Yunhong
2008-12-17 12:27 ` Keir Fraser
2008-12-17 14:47 ` Jan Beulich
2008-12-17 15:06 ` Keir Fraser
2008-12-17 15:19 ` Jan Beulich
2008-12-17 15:22 ` Keir Fraser
2008-12-17 15:31 ` Jan Beulich [this message]
2008-12-17 15:53 ` Keir Fraser
2008-12-18 2:24 ` Jiang, Yunhong
2008-12-18 7:33 ` Jan Beulich
2008-12-19 10:10 ` Jiang, Yunhong
2008-12-19 10:29 ` Jan Beulich
2008-12-19 10:39 ` Jiang, Yunhong
2008-12-19 10:50 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4949294A.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=keir.fraser@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
--cc=yunhong.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.