From: Ankit Jain <me@ankitjain.org>
To: Felix Blyakher <felixb@sgi.com>
Cc: mfasheh@suse.com, joel.becker@oracle.com,
linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
xfs-masters@oss.sgi.com, Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com,
ocfs2-devel@oss.oracle.com
Subject: Re: [PATCH][RFC] fs: Add new pre-allocation ioctls to vfs for compatibility with legacy xfs ioctls
Date: Thu, 18 Dec 2008 15:24:43 +0530 [thread overview]
Message-ID: <494A1DE3.5090203@ankitjain.org> (raw)
In-Reply-To: <9D2593C9-08EB-486C-AAF5-E83A1EAEE9B9@sgi.com>
Felix Blyakher wrote:
>
>> This patch adds ioctls to vfs for compatibility with legacy XFS
>> pre-allocation ioctls (XFS_IOC_*RESVP*). The implementation
>> effectively invokes sys_fallocate for the new ioctls.
>
> I don't think we can use sys_fallocate for XFS_IOC_UNRESVSP*
> commands, which suppose to release currently allocated file
> blocks.
> See more comments below.
My bad :( I'll drop the *UNRESV* completely from the new ioctl and
post an updated patch.
-Ankit
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Ankit Jain <me@ankitjain.org>
To: Felix Blyakher <felixb@sgi.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, mfasheh@suse.com,
joel.becker@oracle.com, ocfs2-devel@oss.oracle.com,
linux-kernel@vger.kernel.org, xfs-masters@oss.sgi.com,
xfs@oss.sgi.com
Subject: [Ocfs2-devel] [PATCH][RFC] fs: Add new pre-allocation ioctls to vfs for compatibility with legacy xfs ioctls
Date: Thu, 18 Dec 2008 09:55:26 -0000 [thread overview]
Message-ID: <494A1DE3.5090203@ankitjain.org> (raw)
In-Reply-To: <9D2593C9-08EB-486C-AAF5-E83A1EAEE9B9@sgi.com>
Felix Blyakher wrote:
>
>> This patch adds ioctls to vfs for compatibility with legacy XFS
>> pre-allocation ioctls (XFS_IOC_*RESVP*). The implementation
>> effectively invokes sys_fallocate for the new ioctls.
>
> I don't think we can use sys_fallocate for XFS_IOC_UNRESVSP*
> commands, which suppose to release currently allocated file
> blocks.
> See more comments below.
My bad :( I'll drop the *UNRESV* completely from the new ioctl and
post an updated patch.
-Ankit
WARNING: multiple messages have this Message-ID (diff)
From: Ankit Jain <me@ankitjain.org>
To: Felix Blyakher <felixb@sgi.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, mfasheh@suse.com,
joel.becker@oracle.com, ocfs2-devel@oss.oracle.com,
linux-kernel@vger.kernel.org, xfs-masters@oss.sgi.com,
xfs@oss.sgi.com
Subject: Re: [PATCH][RFC] fs: Add new pre-allocation ioctls to vfs for compatibility with legacy xfs ioctls
Date: Thu, 18 Dec 2008 15:24:43 +0530 [thread overview]
Message-ID: <494A1DE3.5090203@ankitjain.org> (raw)
In-Reply-To: <9D2593C9-08EB-486C-AAF5-E83A1EAEE9B9@sgi.com>
Felix Blyakher wrote:
>
>> This patch adds ioctls to vfs for compatibility with legacy XFS
>> pre-allocation ioctls (XFS_IOC_*RESVP*). The implementation
>> effectively invokes sys_fallocate for the new ioctls.
>
> I don't think we can use sys_fallocate for XFS_IOC_UNRESVSP*
> commands, which suppose to release currently allocated file
> blocks.
> See more comments below.
My bad :( I'll drop the *UNRESV* completely from the new ioctl and
post an updated patch.
-Ankit
next prev parent reply other threads:[~2008-12-18 9:55 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-15 8:04 [PATCH][RFC] fs: Add new pre-allocation ioctls to vfs for compatibility with legacy xfs ioctls Ankit Jain
2008-12-15 8:04 ` Ankit Jain
2008-12-15 8:04 ` [Ocfs2-devel] " Ankit Jain
2008-12-17 20:28 ` Mark Fasheh
2008-12-17 20:28 ` Mark Fasheh
2008-12-17 20:28 ` [Ocfs2-devel] " Mark Fasheh
2008-12-17 21:06 ` [xfs-masters] " Eric Sandeen
2008-12-17 21:06 ` [Ocfs2-devel] " Eric Sandeen
2008-12-17 21:06 ` Eric Sandeen
2008-12-17 21:15 ` Mark Fasheh
2008-12-17 21:16 ` [Ocfs2-devel] " Mark Fasheh
2008-12-17 21:15 ` Mark Fasheh
2008-12-18 9:50 ` Ankit Jain
2008-12-18 9:51 ` [Ocfs2-devel] " Ankit Jain
2008-12-18 9:50 ` Ankit Jain
2008-12-18 9:44 ` Ankit Jain
2008-12-18 9:44 ` Ankit Jain
2008-12-18 9:44 ` [Ocfs2-devel] " Ankit Jain
2008-12-18 21:01 ` Ankit Jain
2008-12-18 21:01 ` Ankit Jain
2008-12-18 21:01 ` [Ocfs2-devel] " Ankit Jain
2008-12-18 6:49 ` Felix Blyakher
2008-12-18 6:52 ` [Ocfs2-devel] " Felix Blyakher
2008-12-18 6:49 ` Felix Blyakher
2008-12-18 9:54 ` Ankit Jain [this message]
2008-12-18 9:55 ` [Ocfs2-devel] " Ankit Jain
2008-12-18 9:54 ` Ankit Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=494A1DE3.5090203@ankitjain.org \
--to=me@ankitjain.org \
--cc=felixb@sgi.com \
--cc=hch@infradead.org \
--cc=joel.becker@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=viro@zeniv.linux.org.uk \
--cc=xfs-masters@oss.sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.