From: Ankit Jain <me@ankitjain.org>
To: Mark Fasheh <mfasheh@suse.com>
Cc: linux-kernel@vger.kernel.org, joel.becker@oracle.com,
Christoph Hellwig <hch@infradead.org>,
xfs-masters@oss.sgi.com, Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com,
ocfs2-devel@oss.oracle.com
Subject: Re: [PATCH][RFC] fs: Add new pre-allocation ioctls to vfs for compatibility with legacy xfs ioctls
Date: Fri, 19 Dec 2008 02:31:05 +0530 [thread overview]
Message-ID: <494ABA11.2050205@ankitjain.org> (raw)
In-Reply-To: <20081217202815.GE8791@wotan.suse.de>
Mark Fasheh wrote:
> On Mon, Dec 15, 2008 at 01:34:24PM +0530, Ankit Jain wrote:
>> 2. Should the corresponding ioctls be removed from ocfs2?
>
> Well, a small amount of the code in fs/ocfs2/ioctl.c can certainly go away.
> Shouldn't we be talking about doing the same for xfs too?
Reading the code a bit, my understanding is that as compat_ioctl is also
supported and that just delegates to ioctl (ocfs2_ioctl), so we can't
remove the *_RESVSP* handling.
Same goes for xfs also.
Does that sound fair or did I not understand it correctly?
-Ankit
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Ankit Jain <me@ankitjain.org>
To: Mark Fasheh <mfasheh@suse.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, joel.becker@oracle.com,
ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org,
xfs-masters@oss.sgi.com, xfs@oss.sgi.com
Subject: [Ocfs2-devel] [PATCH][RFC] fs: Add new pre-allocation ioctls to vfs for compatibility with legacy xfs ioctls
Date: Fri, 19 Dec 2008 02:31:05 +0530 [thread overview]
Message-ID: <494ABA11.2050205@ankitjain.org> (raw)
In-Reply-To: <20081217202815.GE8791@wotan.suse.de>
Mark Fasheh wrote:
> On Mon, Dec 15, 2008 at 01:34:24PM +0530, Ankit Jain wrote:
>> 2. Should the corresponding ioctls be removed from ocfs2?
>
> Well, a small amount of the code in fs/ocfs2/ioctl.c can certainly go away.
> Shouldn't we be talking about doing the same for xfs too?
Reading the code a bit, my understanding is that as compat_ioctl is also
supported and that just delegates to ioctl (ocfs2_ioctl), so we can't
remove the *_RESVSP* handling.
Same goes for xfs also.
Does that sound fair or did I not understand it correctly?
-Ankit
WARNING: multiple messages have this Message-ID (diff)
From: Ankit Jain <me@ankitjain.org>
To: Mark Fasheh <mfasheh@suse.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, joel.becker@oracle.com,
ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org,
xfs-masters@oss.sgi.com, xfs@oss.sgi.com
Subject: Re: [PATCH][RFC] fs: Add new pre-allocation ioctls to vfs for compatibility with legacy xfs ioctls
Date: Fri, 19 Dec 2008 02:31:05 +0530 [thread overview]
Message-ID: <494ABA11.2050205@ankitjain.org> (raw)
In-Reply-To: <20081217202815.GE8791@wotan.suse.de>
Mark Fasheh wrote:
> On Mon, Dec 15, 2008 at 01:34:24PM +0530, Ankit Jain wrote:
>> 2. Should the corresponding ioctls be removed from ocfs2?
>
> Well, a small amount of the code in fs/ocfs2/ioctl.c can certainly go away.
> Shouldn't we be talking about doing the same for xfs too?
Reading the code a bit, my understanding is that as compat_ioctl is also
supported and that just delegates to ioctl (ocfs2_ioctl), so we can't
remove the *_RESVSP* handling.
Same goes for xfs also.
Does that sound fair or did I not understand it correctly?
-Ankit
next prev parent reply other threads:[~2008-12-18 21:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-15 8:04 [PATCH][RFC] fs: Add new pre-allocation ioctls to vfs for compatibility with legacy xfs ioctls Ankit Jain
2008-12-15 8:04 ` Ankit Jain
2008-12-15 8:04 ` [Ocfs2-devel] " Ankit Jain
2008-12-17 20:28 ` Mark Fasheh
2008-12-17 20:28 ` Mark Fasheh
2008-12-17 20:28 ` [Ocfs2-devel] " Mark Fasheh
2008-12-17 21:06 ` [xfs-masters] " Eric Sandeen
2008-12-17 21:06 ` [Ocfs2-devel] " Eric Sandeen
2008-12-17 21:06 ` Eric Sandeen
2008-12-17 21:15 ` Mark Fasheh
2008-12-17 21:16 ` [Ocfs2-devel] " Mark Fasheh
2008-12-17 21:15 ` Mark Fasheh
2008-12-18 9:50 ` Ankit Jain
2008-12-18 9:51 ` [Ocfs2-devel] " Ankit Jain
2008-12-18 9:50 ` Ankit Jain
2008-12-18 9:44 ` Ankit Jain
2008-12-18 9:44 ` Ankit Jain
2008-12-18 9:44 ` [Ocfs2-devel] " Ankit Jain
2008-12-18 21:01 ` Ankit Jain [this message]
2008-12-18 21:01 ` Ankit Jain
2008-12-18 21:01 ` [Ocfs2-devel] " Ankit Jain
2008-12-18 6:49 ` Felix Blyakher
2008-12-18 6:52 ` [Ocfs2-devel] " Felix Blyakher
2008-12-18 6:49 ` Felix Blyakher
2008-12-18 9:54 ` Ankit Jain
2008-12-18 9:55 ` [Ocfs2-devel] " Ankit Jain
2008-12-18 9:54 ` Ankit Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=494ABA11.2050205@ankitjain.org \
--to=me@ankitjain.org \
--cc=hch@infradead.org \
--cc=joel.becker@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=viro@zeniv.linux.org.uk \
--cc=xfs-masters@oss.sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.