From: Tilman Schmidt <tilman@imap.cc>
To: Julia Lawall <julia@diku.dk>
Cc: hjlipp@web.de, gigaset307x-common@lists.sourceforge.net,
gregkh@suse.de, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/13] drivers/isdn/gigaset: use USB API functions rather
Date: Mon, 29 Dec 2008 11:46:30 +0000 [thread overview]
Message-ID: <4958B896.3030801@imap.cc> (raw)
In-Reply-To: <Pine.LNX.4.64.0812291119340.9555@pc-004.diku.dk>
[-- Attachment #1: Type: text/plain, Size: 1560 bytes --]
On Mon, 29 Dec 2008 11:19:55 +0100 (CET), Julia Lawall wrote:
> This set of patches introduces calls to the following set of functions:
>
> usb_endpoint_dir_in(epd)
> usb_endpoint_dir_out(epd)
> usb_endpoint_is_bulk_in(epd)
> usb_endpoint_is_bulk_out(epd)
> usb_endpoint_is_int_in(epd)
> usb_endpoint_is_int_out(epd)
> usb_endpoint_num(epd)
> usb_endpoint_type(epd)
> usb_endpoint_xfer_bulk(epd)
> usb_endpoint_xfer_control(epd)
> usb_endpoint_xfer_int(epd)
> usb_endpoint_xfer_isoc(epd)
[...]
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Tilman Schmidt <tilman@imap.cc>
Thanks,
Tilman
> ---
> drivers/isdn/gigaset/usb-gigaset.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/isdn/gigaset/usb-gigaset.c b/drivers/isdn/gigaset/usb-gigaset.c
> index e847c6e..16399fb 100644
> --- a/drivers/isdn/gigaset/usb-gigaset.c
> +++ b/drivers/isdn/gigaset/usb-gigaset.c
> @@ -783,7 +783,7 @@ static int gigaset_probe(struct usb_interface *interface,
> /* Fill the interrupt urb and send it to the core */
> usb_fill_int_urb(ucs->read_urb, udev,
> usb_rcvintpipe(udev,
> - endpoint->bEndpointAddress & 0x0f),
> + usb_endpoint_num(endpoint)),
> cs->inbuf[0].rcvbuf, buffer_size,
> gigaset_read_int_callback,
> cs->inbuf + 0, endpoint->bInterval);
--
Tilman Schmidt E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 254 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Tilman Schmidt <tilman@imap.cc>
To: Julia Lawall <julia@diku.dk>
Cc: hjlipp@web.de, gigaset307x-common@lists.sourceforge.net,
gregkh@suse.de, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/13] drivers/isdn/gigaset: use USB API functions rather than constants
Date: Mon, 29 Dec 2008 12:46:30 +0100 [thread overview]
Message-ID: <4958B896.3030801@imap.cc> (raw)
In-Reply-To: <Pine.LNX.4.64.0812291119340.9555@pc-004.diku.dk>
[-- Attachment #1: Type: text/plain, Size: 1560 bytes --]
On Mon, 29 Dec 2008 11:19:55 +0100 (CET), Julia Lawall wrote:
> This set of patches introduces calls to the following set of functions:
>
> usb_endpoint_dir_in(epd)
> usb_endpoint_dir_out(epd)
> usb_endpoint_is_bulk_in(epd)
> usb_endpoint_is_bulk_out(epd)
> usb_endpoint_is_int_in(epd)
> usb_endpoint_is_int_out(epd)
> usb_endpoint_num(epd)
> usb_endpoint_type(epd)
> usb_endpoint_xfer_bulk(epd)
> usb_endpoint_xfer_control(epd)
> usb_endpoint_xfer_int(epd)
> usb_endpoint_xfer_isoc(epd)
[...]
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Tilman Schmidt <tilman@imap.cc>
Thanks,
Tilman
> ---
> drivers/isdn/gigaset/usb-gigaset.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/isdn/gigaset/usb-gigaset.c b/drivers/isdn/gigaset/usb-gigaset.c
> index e847c6e..16399fb 100644
> --- a/drivers/isdn/gigaset/usb-gigaset.c
> +++ b/drivers/isdn/gigaset/usb-gigaset.c
> @@ -783,7 +783,7 @@ static int gigaset_probe(struct usb_interface *interface,
> /* Fill the interrupt urb and send it to the core */
> usb_fill_int_urb(ucs->read_urb, udev,
> usb_rcvintpipe(udev,
> - endpoint->bEndpointAddress & 0x0f),
> + usb_endpoint_num(endpoint)),
> cs->inbuf[0].rcvbuf, buffer_size,
> gigaset_read_int_callback,
> cs->inbuf + 0, endpoint->bInterval);
--
Tilman Schmidt E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 254 bytes --]
next prev parent reply other threads:[~2008-12-29 11:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-29 10:19 [PATCH 3/13] drivers/isdn/gigaset: use USB API functions rather than Julia Lawall
2008-12-29 10:19 ` [PATCH 3/13] drivers/isdn/gigaset: use USB API functions rather than constants Julia Lawall
2008-12-29 11:46 ` Tilman Schmidt [this message]
2008-12-29 11:46 ` Tilman Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4958B896.3030801@imap.cc \
--to=tilman@imap.cc \
--cc=gigaset307x-common@lists.sourceforge.net \
--cc=gregkh@suse.de \
--cc=hjlipp@web.de \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.