* [PATCH 3/13] drivers/isdn/gigaset: use USB API functions rather than
@ 2008-12-29 10:19 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2008-12-29 10:19 UTC (permalink / raw)
To: hjlipp, tilman, gigaset307x-common, gregkh, linux-kernel,
kernel-janitors
From: Julia Lawall <julia@diku.dk>
This set of patches introduces calls to the following set of functions:
usb_endpoint_dir_in(epd)
usb_endpoint_dir_out(epd)
usb_endpoint_is_bulk_in(epd)
usb_endpoint_is_bulk_out(epd)
usb_endpoint_is_int_in(epd)
usb_endpoint_is_int_out(epd)
usb_endpoint_num(epd)
usb_endpoint_type(epd)
usb_endpoint_xfer_bulk(epd)
usb_endpoint_xfer_control(epd)
usb_endpoint_xfer_int(epd)
usb_endpoint_xfer_isoc(epd)
In some cases, introducing one of these functions is not possible, and it
just replaces an explicit integer value by one of the following constants:
USB_ENDPOINT_XFER_BULK
USB_ENDPOINT_XFER_CONTROL
USB_ENDPOINT_XFER_INT
USB_ENDPOINT_XFER_ISOC
An extract of the semantic patch that makes these changes is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@r1@ struct usb_endpoint_descriptor *epd; @@
- ((epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\)) =
- \(USB_ENDPOINT_XFER_CONTROL\|0\))
+ usb_endpoint_xfer_control(epd)
@r5@ struct usb_endpoint_descriptor *epd; @@
- ((epd->bEndpointAddress & \(USB_ENDPOINT_DIR_MASK\|0x80\)) =
- \(USB_DIR_IN\|0x80\))
+ usb_endpoint_dir_in(epd)
@inc@
@@
#include <linux/usb.h>
@depends on !inc && (r1||r5)@
@@
+ #include <linux/usb.h>
#include <linux/usb/...>
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/isdn/gigaset/usb-gigaset.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/gigaset/usb-gigaset.c b/drivers/isdn/gigaset/usb-gigaset.c
index e847c6e..16399fb 100644
--- a/drivers/isdn/gigaset/usb-gigaset.c
+++ b/drivers/isdn/gigaset/usb-gigaset.c
@@ -783,7 +783,7 @@ static int gigaset_probe(struct usb_interface *interface,
/* Fill the interrupt urb and send it to the core */
usb_fill_int_urb(ucs->read_urb, udev,
usb_rcvintpipe(udev,
- endpoint->bEndpointAddress & 0x0f),
+ usb_endpoint_num(endpoint)),
cs->inbuf[0].rcvbuf, buffer_size,
gigaset_read_int_callback,
cs->inbuf + 0, endpoint->bInterval);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 3/13] drivers/isdn/gigaset: use USB API functions rather than constants
@ 2008-12-29 10:19 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2008-12-29 10:19 UTC (permalink / raw)
To: hjlipp, tilman, gigaset307x-common, gregkh, linux-kernel,
kernel-janitors
From: Julia Lawall <julia@diku.dk>
This set of patches introduces calls to the following set of functions:
usb_endpoint_dir_in(epd)
usb_endpoint_dir_out(epd)
usb_endpoint_is_bulk_in(epd)
usb_endpoint_is_bulk_out(epd)
usb_endpoint_is_int_in(epd)
usb_endpoint_is_int_out(epd)
usb_endpoint_num(epd)
usb_endpoint_type(epd)
usb_endpoint_xfer_bulk(epd)
usb_endpoint_xfer_control(epd)
usb_endpoint_xfer_int(epd)
usb_endpoint_xfer_isoc(epd)
In some cases, introducing one of these functions is not possible, and it
just replaces an explicit integer value by one of the following constants:
USB_ENDPOINT_XFER_BULK
USB_ENDPOINT_XFER_CONTROL
USB_ENDPOINT_XFER_INT
USB_ENDPOINT_XFER_ISOC
An extract of the semantic patch that makes these changes is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@r1@ struct usb_endpoint_descriptor *epd; @@
- ((epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\)) ==
- \(USB_ENDPOINT_XFER_CONTROL\|0\))
+ usb_endpoint_xfer_control(epd)
@r5@ struct usb_endpoint_descriptor *epd; @@
- ((epd->bEndpointAddress & \(USB_ENDPOINT_DIR_MASK\|0x80\)) ==
- \(USB_DIR_IN\|0x80\))
+ usb_endpoint_dir_in(epd)
@inc@
@@
#include <linux/usb.h>
@depends on !inc && (r1||r5)@
@@
+ #include <linux/usb.h>
#include <linux/usb/...>
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/isdn/gigaset/usb-gigaset.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/gigaset/usb-gigaset.c b/drivers/isdn/gigaset/usb-gigaset.c
index e847c6e..16399fb 100644
--- a/drivers/isdn/gigaset/usb-gigaset.c
+++ b/drivers/isdn/gigaset/usb-gigaset.c
@@ -783,7 +783,7 @@ static int gigaset_probe(struct usb_interface *interface,
/* Fill the interrupt urb and send it to the core */
usb_fill_int_urb(ucs->read_urb, udev,
usb_rcvintpipe(udev,
- endpoint->bEndpointAddress & 0x0f),
+ usb_endpoint_num(endpoint)),
cs->inbuf[0].rcvbuf, buffer_size,
gigaset_read_int_callback,
cs->inbuf + 0, endpoint->bInterval);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 3/13] drivers/isdn/gigaset: use USB API functions rather
2008-12-29 10:19 ` [PATCH 3/13] drivers/isdn/gigaset: use USB API functions rather than constants Julia Lawall
@ 2008-12-29 11:46 ` Tilman Schmidt
-1 siblings, 0 replies; 4+ messages in thread
From: Tilman Schmidt @ 2008-12-29 11:46 UTC (permalink / raw)
To: Julia Lawall
Cc: hjlipp, gigaset307x-common, gregkh, linux-kernel, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1560 bytes --]
On Mon, 29 Dec 2008 11:19:55 +0100 (CET), Julia Lawall wrote:
> This set of patches introduces calls to the following set of functions:
>
> usb_endpoint_dir_in(epd)
> usb_endpoint_dir_out(epd)
> usb_endpoint_is_bulk_in(epd)
> usb_endpoint_is_bulk_out(epd)
> usb_endpoint_is_int_in(epd)
> usb_endpoint_is_int_out(epd)
> usb_endpoint_num(epd)
> usb_endpoint_type(epd)
> usb_endpoint_xfer_bulk(epd)
> usb_endpoint_xfer_control(epd)
> usb_endpoint_xfer_int(epd)
> usb_endpoint_xfer_isoc(epd)
[...]
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Tilman Schmidt <tilman@imap.cc>
Thanks,
Tilman
> ---
> drivers/isdn/gigaset/usb-gigaset.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/isdn/gigaset/usb-gigaset.c b/drivers/isdn/gigaset/usb-gigaset.c
> index e847c6e..16399fb 100644
> --- a/drivers/isdn/gigaset/usb-gigaset.c
> +++ b/drivers/isdn/gigaset/usb-gigaset.c
> @@ -783,7 +783,7 @@ static int gigaset_probe(struct usb_interface *interface,
> /* Fill the interrupt urb and send it to the core */
> usb_fill_int_urb(ucs->read_urb, udev,
> usb_rcvintpipe(udev,
> - endpoint->bEndpointAddress & 0x0f),
> + usb_endpoint_num(endpoint)),
> cs->inbuf[0].rcvbuf, buffer_size,
> gigaset_read_int_callback,
> cs->inbuf + 0, endpoint->bInterval);
--
Tilman Schmidt E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 254 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 3/13] drivers/isdn/gigaset: use USB API functions rather than constants
@ 2008-12-29 11:46 ` Tilman Schmidt
0 siblings, 0 replies; 4+ messages in thread
From: Tilman Schmidt @ 2008-12-29 11:46 UTC (permalink / raw)
To: Julia Lawall
Cc: hjlipp, gigaset307x-common, gregkh, linux-kernel, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1560 bytes --]
On Mon, 29 Dec 2008 11:19:55 +0100 (CET), Julia Lawall wrote:
> This set of patches introduces calls to the following set of functions:
>
> usb_endpoint_dir_in(epd)
> usb_endpoint_dir_out(epd)
> usb_endpoint_is_bulk_in(epd)
> usb_endpoint_is_bulk_out(epd)
> usb_endpoint_is_int_in(epd)
> usb_endpoint_is_int_out(epd)
> usb_endpoint_num(epd)
> usb_endpoint_type(epd)
> usb_endpoint_xfer_bulk(epd)
> usb_endpoint_xfer_control(epd)
> usb_endpoint_xfer_int(epd)
> usb_endpoint_xfer_isoc(epd)
[...]
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Tilman Schmidt <tilman@imap.cc>
Thanks,
Tilman
> ---
> drivers/isdn/gigaset/usb-gigaset.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/isdn/gigaset/usb-gigaset.c b/drivers/isdn/gigaset/usb-gigaset.c
> index e847c6e..16399fb 100644
> --- a/drivers/isdn/gigaset/usb-gigaset.c
> +++ b/drivers/isdn/gigaset/usb-gigaset.c
> @@ -783,7 +783,7 @@ static int gigaset_probe(struct usb_interface *interface,
> /* Fill the interrupt urb and send it to the core */
> usb_fill_int_urb(ucs->read_urb, udev,
> usb_rcvintpipe(udev,
> - endpoint->bEndpointAddress & 0x0f),
> + usb_endpoint_num(endpoint)),
> cs->inbuf[0].rcvbuf, buffer_size,
> gigaset_read_int_callback,
> cs->inbuf + 0, endpoint->bInterval);
--
Tilman Schmidt E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 254 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-12-29 11:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-29 10:19 [PATCH 3/13] drivers/isdn/gigaset: use USB API functions rather than Julia Lawall
2008-12-29 10:19 ` [PATCH 3/13] drivers/isdn/gigaset: use USB API functions rather than constants Julia Lawall
2008-12-29 11:46 ` [PATCH 3/13] drivers/isdn/gigaset: use USB API functions rather Tilman Schmidt
2008-12-29 11:46 ` [PATCH 3/13] drivers/isdn/gigaset: use USB API functions rather than constants Tilman Schmidt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.