All of lore.kernel.org
 help / color / mirror / Atom feed
From: suijingfeng <suijingfeng@loongson.cn>
To: Bjorn Helgaas <helgaas@kernel.org>,
	Sui Jingfeng <sui.jingfeng@linux.dev>
Cc: linux-fbdev@vger.kernel.org, Cornelia Huck <cohuck@redhat.com>,
	Karol Herbst <kherbst@redhat.com>,
	linux-pci@vger.kernel.org,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	dri-devel@lists.freedesktop.org,
	YiPeng Chai <YiPeng.Chai@amd.com>,
	Mario Limonciello <mario.limonciello@amd.com>,
	Likun Gao <Likun.Gao@amd.com>, David Airlie <airlied@gmail.com>,
	Ville Syrjala <ville.syrjala@linux.intel.com>,
	Yi Liu <yi.l.liu@intel.com>,
	kvm@vger.kernel.org, amd-gfx@lists.freedesktop.org,
	Jason Gunthorpe <jgg@ziepe.ca>, Ben Skeggs <bskeggs@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>,
	Lijo Lazar <lijo.lazar@amd.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Jani Nikula <jani.nikula@intel.com>,
	Bokun Zhang <Bokun.Zhang@amd.com>,
	intel-gfx@lists.freedesktop.org,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Abhishek Sahu <abhsahu@nvidia.com>,
	Maxime Ripard <mripard@kernel.org>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	Yishai Hadas <yishaih@nvidia.com>,
	Pan Xinhui <Xinhui.Pan@amd.com>,
	linux-kernel@vger.kernel.org, Daniel Vetter <daniel@ffwll.ch>,
	Alex Deucher <alexander.deucher@amd.com>,
	Christian Konig <christian.koenig@amd.com>,
	Hawking Zhang <Hawking.Zhang@amd.com>
Subject: Re: [PATCH v3 4/9] PCI/VGA: Improve the default VGA device selection
Date: Mon, 24 Jul 2023 19:56:35 +0800	[thread overview]
Message-ID: <49618cce-8c3f-7f25-20b1-eecfc3c70cd0@loongson.cn> (raw)
In-Reply-To: <20230719193233.GA511659@bhelgaas>

Hi,


I was too hurry reply to you. I'm may miss the point for part of your 
reviews, Sorry.


On 2023/7/20 03:32, Bjorn Helgaas wrote:
> CONFIG_DRM_AST is a tristate.  We're talking about identifying the
> boot-time console device.

Yes, my patch will only works *after* the module gets loaded successfully.

But generally, vgaarb will select a default boot device before my patch taking into effect.

I means that vgaarb will select a default boot device by calling vga_arbiter_add_pci_device() function.


In practice, I still not notice any obvious problems.

I'm lack the knowledge about the boot-time console,

what is the potential problems with such a condition?


>   So if CONFIG_DRM_AST=m, I guess we don't
> get the benefit of the new callback unless the module gets loaded?

Yes, my approach will not works until the device driver kernel module 
gets loaded successfully.

So what's the problem with such a situation, do you see something weird ?


WARNING: multiple messages have this Message-ID (diff)
From: suijingfeng <suijingfeng@loongson.cn>
To: Bjorn Helgaas <helgaas@kernel.org>,
	Sui Jingfeng <sui.jingfeng@linux.dev>
Cc: linux-fbdev@vger.kernel.org, Cornelia Huck <cohuck@redhat.com>,
	Karol Herbst <kherbst@redhat.com>,
	linux-pci@vger.kernel.org, dri-devel@lists.freedesktop.org,
	YiPeng Chai <YiPeng.Chai@amd.com>,
	Mario Limonciello <mario.limonciello@amd.com>,
	Likun Gao <Likun.Gao@amd.com>, David Airlie <airlied@gmail.com>,
	Yi Liu <yi.l.liu@intel.com>,
	kvm@vger.kernel.org, amd-gfx@lists.freedesktop.org,
	Jason Gunthorpe <jgg@ziepe.ca>, Ben Skeggs <bskeggs@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>,
	Lijo Lazar <lijo.lazar@amd.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Jani Nikula <jani.nikula@intel.com>,
	Bokun Zhang <Bokun.Zhang@amd.com>,
	intel-gfx@lists.freedesktop.org,
	Abhishek Sahu <abhsahu@nvidia.com>,
	Maxime Ripard <mripard@kernel.org>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Yishai Hadas <yishaih@nvidia.com>,
	Pan Xinhui <Xinhui.Pan@amd.com>,
	linux-kernel@vger.kernel.org, Daniel Vetter <daniel@ffwll.ch>,
	Alex Deucher <alexander.deucher@amd.com>,
	Christian Konig <christian.koenig@amd.com>,
	Hawking Zhang <Hawking.Zhang@amd.com>
Subject: Re: [Intel-gfx] [PATCH v3 4/9] PCI/VGA: Improve the default VGA device selection
Date: Mon, 24 Jul 2023 19:56:35 +0800	[thread overview]
Message-ID: <49618cce-8c3f-7f25-20b1-eecfc3c70cd0@loongson.cn> (raw)
In-Reply-To: <20230719193233.GA511659@bhelgaas>

Hi,


I was too hurry reply to you. I'm may miss the point for part of your 
reviews, Sorry.


On 2023/7/20 03:32, Bjorn Helgaas wrote:
> CONFIG_DRM_AST is a tristate.  We're talking about identifying the
> boot-time console device.

Yes, my patch will only works *after* the module gets loaded successfully.

But generally, vgaarb will select a default boot device before my patch taking into effect.

I means that vgaarb will select a default boot device by calling vga_arbiter_add_pci_device() function.


In practice, I still not notice any obvious problems.

I'm lack the knowledge about the boot-time console,

what is the potential problems with such a condition?


>   So if CONFIG_DRM_AST=m, I guess we don't
> get the benefit of the new callback unless the module gets loaded?

Yes, my approach will not works until the device driver kernel module 
gets loaded successfully.

So what's the problem with such a situation, do you see something weird ?


WARNING: multiple messages have this Message-ID (diff)
From: suijingfeng <suijingfeng@loongson.cn>
To: Bjorn Helgaas <helgaas@kernel.org>,
	Sui Jingfeng <sui.jingfeng@linux.dev>
Cc: David Airlie <airlied@gmail.com>,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org,
	kvm@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-fbdev@vger.kernel.org,
	Alex Deucher <alexander.deucher@amd.com>,
	Christian Konig <christian.koenig@amd.com>,
	Pan Xinhui <Xinhui.Pan@amd.com>, Daniel Vetter <daniel@ffwll.ch>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	Ben Skeggs <bskeggs@redhat.com>,
	Karol Herbst <kherbst@redhat.com>, Lyude Paul <lyude@redhat.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Hawking Zhang <Hawking.Zhang@amd.com>,
	Mario Limonciello <mario.limonciello@amd.com>,
	Lijo Lazar <lijo.lazar@amd.com>,
	YiPeng Chai <YiPeng.Chai@amd.com>,
	Bokun Zhang <Bokun.Zhang@amd.com>, Likun Gao <Likun.Gao@amd.com>,
	Ville Syrjala <ville.syrjala@linux.intel.com>,
	Jason Gunthorpe <jgg@ziepe.ca>, Kevin Tian <kevin.tian@intel.com>,
	Cornelia Huck <cohuck@redhat.com>,
	Yishai Hadas <yishaih@nvidia.com>,
	Abhishek Sahu <abhsahu@nvidia.com>, Yi Liu <yi.l.liu@intel.com>,
	Jani Nikula <jani.nikula@intel.com>
Subject: Re: [PATCH v3 4/9] PCI/VGA: Improve the default VGA device selection
Date: Mon, 24 Jul 2023 19:56:35 +0800	[thread overview]
Message-ID: <49618cce-8c3f-7f25-20b1-eecfc3c70cd0@loongson.cn> (raw)
In-Reply-To: <20230719193233.GA511659@bhelgaas>

Hi,


I was too hurry reply to you. I'm may miss the point for part of your 
reviews, Sorry.


On 2023/7/20 03:32, Bjorn Helgaas wrote:
> CONFIG_DRM_AST is a tristate.  We're talking about identifying the
> boot-time console device.

Yes, my patch will only works *after* the module gets loaded successfully.

But generally, vgaarb will select a default boot device before my patch taking into effect.

I means that vgaarb will select a default boot device by calling vga_arbiter_add_pci_device() function.


In practice, I still not notice any obvious problems.

I'm lack the knowledge about the boot-time console,

what is the potential problems with such a condition?


>   So if CONFIG_DRM_AST=m, I guess we don't
> get the benefit of the new callback unless the module gets loaded?

Yes, my approach will not works until the device driver kernel module 
gets loaded successfully.

So what's the problem with such a situation, do you see something weird ?


WARNING: multiple messages have this Message-ID (diff)
From: suijingfeng <suijingfeng@loongson.cn>
To: Bjorn Helgaas <helgaas@kernel.org>,
	Sui Jingfeng <sui.jingfeng@linux.dev>
Cc: linux-fbdev@vger.kernel.org, Cornelia Huck <cohuck@redhat.com>,
	Karol Herbst <kherbst@redhat.com>,
	linux-pci@vger.kernel.org, dri-devel@lists.freedesktop.org,
	YiPeng Chai <YiPeng.Chai@amd.com>,
	Mario Limonciello <mario.limonciello@amd.com>,
	Likun Gao <Likun.Gao@amd.com>, Yi Liu <yi.l.liu@intel.com>,
	kvm@vger.kernel.org, amd-gfx@lists.freedesktop.org,
	Jason Gunthorpe <jgg@ziepe.ca>, Ben Skeggs <bskeggs@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>,
	Lijo Lazar <lijo.lazar@amd.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Jani Nikula <jani.nikula@intel.com>,
	Bokun Zhang <Bokun.Zhang@amd.com>,
	intel-gfx@lists.freedesktop.org,
	Alex Williamson <alex.williamson@redhat.com>,
	Abhishek Sahu <abhsahu@nvidia.com>,
	Maxime Ripard <mripard@kernel.org>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	Yishai Hadas <yishaih@nvidia.com>,
	Pan Xinhui <Xinhui.Pan@amd.com>,
	linux-kernel@vger.kernel.org,
	Alex Deucher <alexander.deucher@amd.com>,
	Christian Konig <christian.koenig@amd.com>,
	Hawking Zhang <Hawking.Zhang@amd.com>
Subject: Re: [PATCH v3 4/9] PCI/VGA: Improve the default VGA device selection
Date: Mon, 24 Jul 2023 19:56:35 +0800	[thread overview]
Message-ID: <49618cce-8c3f-7f25-20b1-eecfc3c70cd0@loongson.cn> (raw)
In-Reply-To: <20230719193233.GA511659@bhelgaas>

Hi,


I was too hurry reply to you. I'm may miss the point for part of your 
reviews, Sorry.


On 2023/7/20 03:32, Bjorn Helgaas wrote:
> CONFIG_DRM_AST is a tristate.  We're talking about identifying the
> boot-time console device.

Yes, my patch will only works *after* the module gets loaded successfully.

But generally, vgaarb will select a default boot device before my patch taking into effect.

I means that vgaarb will select a default boot device by calling vga_arbiter_add_pci_device() function.


In practice, I still not notice any obvious problems.

I'm lack the knowledge about the boot-time console,

what is the potential problems with such a condition?


>   So if CONFIG_DRM_AST=m, I guess we don't
> get the benefit of the new callback unless the module gets loaded?

Yes, my approach will not works until the device driver kernel module 
gets loaded successfully.

So what's the problem with such a situation, do you see something weird ?


  parent reply	other threads:[~2023-07-24 11:56 UTC|newest]

Thread overview: 104+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-11 16:43 [PATCH v3 0/9] PCI/VGA: Improve the default VGA device selection Sui Jingfeng
2023-07-11 16:43 ` Sui Jingfeng
2023-07-11 16:43 ` [Intel-gfx] " Sui Jingfeng
2023-07-11 16:43 ` [PATCH v3 1/9] video/aperture: Add a helper to detect if an aperture contains firmware FB Sui Jingfeng
2023-07-11 16:43   ` Sui Jingfeng
2023-07-11 16:43   ` [Intel-gfx] " Sui Jingfeng
2023-07-19 20:43   ` Bjorn Helgaas
2023-07-19 20:43     ` Bjorn Helgaas
2023-07-19 20:43     ` Bjorn Helgaas
2023-07-19 20:43     ` [Intel-gfx] " Bjorn Helgaas
2023-07-19 21:18     ` suijingfeng
2023-07-19 21:18       ` suijingfeng
2023-07-19 21:18       ` suijingfeng
2023-07-19 21:18       ` [Intel-gfx] " suijingfeng
2023-07-11 16:43 ` [PATCH v3 2/9] video/aperture: Add a helper for determining if an unmoved aperture contain FB Sui Jingfeng
2023-07-11 16:43   ` Sui Jingfeng
2023-07-11 16:43   ` [Intel-gfx] " Sui Jingfeng
2023-07-11 16:43 ` [PATCH v3 3/9] PCI/VGA: Switch to aperture_contain_firmware_fb_nonreloc() Sui Jingfeng
2023-07-11 16:43   ` Sui Jingfeng
2023-07-11 16:43   ` [Intel-gfx] " Sui Jingfeng
2023-07-19 20:43   ` Bjorn Helgaas
2023-07-19 20:43     ` Bjorn Helgaas
2023-07-19 20:43     ` Bjorn Helgaas
2023-07-19 22:04     ` suijingfeng
2023-07-19 22:04       ` suijingfeng
2023-07-19 22:04       ` suijingfeng
2023-07-11 16:43 ` [PATCH v3 4/9] PCI/VGA: Improve the default VGA device selection Sui Jingfeng
2023-07-11 16:43   ` Sui Jingfeng
2023-07-11 16:43   ` Sui Jingfeng
2023-07-11 16:43   ` [Intel-gfx] " Sui Jingfeng
2023-07-17 14:07   ` suijingfeng
2023-07-17 14:07     ` suijingfeng
2023-07-17 14:07     ` suijingfeng
2023-07-17 14:07     ` [Intel-gfx] " suijingfeng
2023-07-19 19:32   ` Bjorn Helgaas
2023-07-19 19:32     ` Bjorn Helgaas
2023-07-19 19:32     ` Bjorn Helgaas
2023-07-19 19:32     ` [Intel-gfx] " Bjorn Helgaas
2023-07-19 22:32     ` suijingfeng
2023-07-19 22:32       ` suijingfeng
2023-07-19 22:32       ` suijingfeng
2023-07-19 22:32       ` [Intel-gfx] " suijingfeng
2023-07-19 22:44       ` Sui Jingfeng
2023-07-19 22:44         ` Sui Jingfeng
2023-07-19 22:44         ` Sui Jingfeng
2023-07-19 22:44         ` [Intel-gfx] " Sui Jingfeng
2023-07-19 22:51     ` suijingfeng
2023-07-19 22:51       ` suijingfeng
2023-07-19 22:51       ` suijingfeng
2023-07-19 22:51       ` [Intel-gfx] " suijingfeng
2023-07-24 11:56     ` suijingfeng [this message]
2023-07-24 11:56       ` suijingfeng
2023-07-24 11:56       ` suijingfeng
2023-07-24 11:56       ` [Intel-gfx] " suijingfeng
2023-07-24 12:16     ` suijingfeng
2023-07-24 12:16       ` suijingfeng
2023-07-24 12:16       ` suijingfeng
2023-07-24 12:16       ` [Intel-gfx] " suijingfeng
2023-07-25 21:30       ` Bjorn Helgaas
2023-07-25 21:30         ` Bjorn Helgaas
2023-07-25 21:30         ` Bjorn Helgaas
2023-07-25 21:30         ` [Intel-gfx] " Bjorn Helgaas
2023-07-24 12:28     ` suijingfeng
2023-07-24 12:28       ` suijingfeng
2023-07-24 12:28       ` suijingfeng
2023-07-24 12:28       ` [Intel-gfx] " suijingfeng
2023-07-11 16:43 ` [PATCH v3 5/9] drm/amdgpu: Implement the is_primary_gpu callback of vga_client_register() Sui Jingfeng
2023-07-11 16:43   ` Sui Jingfeng
2023-07-11 16:43   ` [Intel-gfx] " Sui Jingfeng
2023-07-11 16:43 ` [PATCH v3 6/9] drm/radeon: Add an implement for the is_primary_gpu function callback Sui Jingfeng
2023-07-11 16:43   ` Sui Jingfeng
2023-07-11 16:43   ` Sui Jingfeng
2023-07-11 16:43   ` [Intel-gfx] " Sui Jingfeng
2023-07-11 16:43 ` [PATCH v3 7/9] drm/i915: Add an implement for the is_primary_gpu hook Sui Jingfeng
2023-07-11 16:43   ` Sui Jingfeng
2023-07-11 16:43   ` Sui Jingfeng
2023-07-11 16:43   ` [Intel-gfx] " Sui Jingfeng
2023-07-11 16:43 ` [PATCH v3 8/9] drm/ast: Register as a vga client to vgaarb by calling vga_client_register() Sui Jingfeng
2023-07-11 16:43   ` Sui Jingfeng
2023-07-11 16:43   ` Sui Jingfeng
2023-07-11 16:43   ` [Intel-gfx] " Sui Jingfeng
2023-07-11 16:43 ` [PATCH v3 9/9] drm/loongson: Add an implement for the is_primary_gpu function callback Sui Jingfeng
2023-07-11 16:43   ` Sui Jingfeng
2023-07-11 16:43   ` [Intel-gfx] " Sui Jingfeng
2023-07-11 18:24 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for PCI/VGA: Improve the default VGA device selection Patchwork
2023-07-19 19:32 ` [PATCH v3 0/9] " Bjorn Helgaas
2023-07-19 19:32   ` Bjorn Helgaas
2023-07-19 19:32   ` Bjorn Helgaas
2023-07-19 19:32   ` [Intel-gfx] " Bjorn Helgaas
2023-07-20  9:17   ` Sui Jingfeng
2023-07-20  9:17     ` Sui Jingfeng
2023-07-20  9:17     ` Sui Jingfeng
2023-07-20  9:17     ` [Intel-gfx] " Sui Jingfeng
2023-07-24 12:47   ` suijingfeng
2023-07-24 12:47     ` suijingfeng
2023-07-24 12:47     ` suijingfeng
2023-07-24 12:47     ` [Intel-gfx] " suijingfeng
2023-07-25 21:32     ` Bjorn Helgaas
2023-07-25 21:32       ` Bjorn Helgaas
2023-07-25 21:32       ` Bjorn Helgaas
2023-07-25 21:32       ` [Intel-gfx] " Bjorn Helgaas
  -- strict thread matches above, loose matches on Subject: below --
2023-07-11 16:31 Sui Jingfeng
2023-07-11 16:31 ` [PATCH v3 4/9] " Sui Jingfeng
2023-07-11 16:31   ` Sui Jingfeng
2023-07-11 16:31   ` Sui Jingfeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49618cce-8c3f-7f25-20b1-eecfc3c70cd0@loongson.cn \
    --to=suijingfeng@loongson.cn \
    --cc=Bokun.Zhang@amd.com \
    --cc=Hawking.Zhang@amd.com \
    --cc=Likun.Gao@amd.com \
    --cc=Xinhui.Pan@amd.com \
    --cc=YiPeng.Chai@amd.com \
    --cc=abhsahu@nvidia.com \
    --cc=airlied@gmail.com \
    --cc=alex.williamson@redhat.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=bhelgaas@google.com \
    --cc=bskeggs@redhat.com \
    --cc=christian.koenig@amd.com \
    --cc=cohuck@redhat.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=helgaas@kernel.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=jani.nikula@linux.intel.com \
    --cc=jgg@ziepe.ca \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=kevin.tian@intel.com \
    --cc=kherbst@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=lijo.lazar@amd.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mario.limonciello@amd.com \
    --cc=mripard@kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=sui.jingfeng@linux.dev \
    --cc=tvrtko.ursulin@linux.intel.com \
    --cc=tzimmermann@suse.de \
    --cc=ville.syrjala@linux.intel.com \
    --cc=yi.l.liu@intel.com \
    --cc=yishaih@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.