[PATCH] Don't use ttyS* serial device name for board specific PNX8XXX UART serial

[PATCH] Don't use ttyS* serial device name for board specific PNX8XXX UART serial

[Ihar Hrachyshka]

I think that's a better solution for the problem I said so please commit
this patch rather previous one...

---

Don't use ttyS[0-1] serial device name for board specific PNX8XXX UART
serial. Rather create ttyPNX[0-1]. Also changed minor number to be
different with sa1100 serial driver one.

Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
---
 drivers/serial/pnx8xxx_uart.c |   11 +++++------
 1 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/serial/pnx8xxx_uart.c b/drivers/serial/pnx8xxx_uart.c
index 22e30d2..96870f1 100644
--- a/drivers/serial/pnx8xxx_uart.c
+++ b/drivers/serial/pnx8xxx_uart.c
@@ -34,9 +34,8 @@
 #include <asm/io.h>
 #include <asm/irq.h>
 
-/* We'll be using StrongARM sa1100 serial port major/minor */
 #define SERIAL_PNX8XXX_MAJOR	204
-#define MINOR_START		5
+#define MINOR_START		96
 
 #define NR_PORTS		2
 
@@ -636,7 +635,7 @@ static struct uart_ops pnx8xxx_pops = {
 /*
  * Setup the PNX8XXX serial ports.
  *
- * Note also that we support "console=ttySx" where "x" is either 0 or 1.
+ * Note also that we support "console=ttyPNXx" where "x" is either 0 or 1.
  */
 static void __init pnx8xxx_init_ports(void)
 {
@@ -728,7 +727,7 @@ pnx8xxx_console_setup(struct console *co, char *options)
 
 static struct uart_driver pnx8xxx_reg;
 static struct console pnx8xxx_console = {
-	.name		= "ttyS",
+	.name		= "ttyPNX",
 	.write		= pnx8xxx_console_write,
 	.device		= uart_console_device,
 	.setup		= pnx8xxx_console_setup,
@@ -752,8 +751,8 @@ console_initcall(pnx8xxx_rs_console_init);
 
 static struct uart_driver pnx8xxx_reg = {
 	.owner			= THIS_MODULE,
-	.driver_name		= "ttyS",
-	.dev_name		= "ttyS",
+	.driver_name		= "ttyPNX",
+	.dev_name		= "ttyPNX",
 	.major			= SERIAL_PNX8XXX_MAJOR,
 	.minor			= MINOR_START,
 	.nr			= NR_PORTS,
-- 
1.5.6.3

Re: [PATCH] Don't use ttyS* serial device name for board specific PNX8XXX UART serial

[Sergei Shtylyov]

Hello.

Ihar Hrachyshka wrote:
> I think that's a better solution for the problem I said so please commit
> this patch rather previous one...
>   

   Such comments are to be placed after --- tearline. Using several such 
tearlines makes it harder to apply your patch...
   And why do you expect the MIPS maintainer to commit a patch to the 
serial driver? Such patches should be addressed to 
linux-serial@vger.kernel.org and (most probably) Alan Cox...

> ---
>
> Don't use ttyS[0-1] serial device name for board specific PNX8XXX UART
> serial. Rather create ttyPNX[0-1]. Also changed minor number to be
> different with sa1100 serial driver one.
>
> Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
>   
[...]
> diff --git a/drivers/serial/pnx8xxx_uart.c b/drivers/serial/pnx8xxx_uart.c
> index 22e30d2..96870f1 100644
> --- a/drivers/serial/pnx8xxx_uart.c
> +++ b/drivers/serial/pnx8xxx_uart.c
> @@ -34,9 +34,8 @@
>  #include <asm/io.h>
>  #include <asm/irq.h>
>  
> -/* We'll be using StrongARM sa1100 serial port major/minor */
>  #define SERIAL_PNX8XXX_MAJOR	204
> -#define MINOR_START		5
> +#define MINOR_START		96
>   

   This major-minor pair is reserved for the Altix serial cards. Have 
you tried registering the minor on http://www.lanana.org

WBR, Sergei

Re: [PATCH] Don't use ttyS* serial device name for board specific PNX8XXX UART serial

[Ihar Hrachyshka]

On Thu, Jan 15, 2009 at 12:04 AM, Sergei Shtylyov
<sshtylyov@ru.mvista.com> wrote:
> Hello.
>
> Ihar Hrachyshka wrote:
>>
>> I think that's a better solution for the problem I said so please commit
>> this patch rather previous one...
>>
>
>  Such comments are to be placed after --- tearline. Using several such
> tearlines makes it harder to apply your patch...
>  And why do you expect the MIPS maintainer to commit a patch to the serial
> driver? Such patches should be addressed to linux-serial@vger.kernel.org and
> (most probably) Alan Cox...

I thought that if it's a driver for mips piece of hardware then I need
to send it to mips guys. Ok, I'll send it to linux-serial.

>
>> ---
>>
>> Don't use ttyS[0-1] serial device name for board specific PNX8XXX UART
>> serial. Rather create ttyPNX[0-1]. Also changed minor number to be
>> different with sa1100 serial driver one.
>>
>> Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
>>
>
> [...]
>>
>> diff --git a/drivers/serial/pnx8xxx_uart.c b/drivers/serial/pnx8xxx_uart.c
>> index 22e30d2..96870f1 100644
>> --- a/drivers/serial/pnx8xxx_uart.c
>> +++ b/drivers/serial/pnx8xxx_uart.c
>> @@ -34,9 +34,8 @@
>>  #include <asm/io.h>
>>  #include <asm/irq.h>
>>  -/* We'll be using StrongARM sa1100 serial port major/minor */
>>  #define SERIAL_PNX8XXX_MAJOR   204
>> -#define MINOR_START            5
>> +#define MINOR_START            96
>>
>
>  This major-minor pair is reserved for the Altix serial cards. Have you
> tried registering the minor on http://www.lanana.org

Thanks for info. I sent the request.

>
> WBR, Sergei
>
>
>

Re: [PATCH] Don't use ttyS* serial device name for board specific PNX8XXX UART serial

[Ihar Hrachyshka]

On Thu, Jan 15, 2009 at 12:04 AM, Sergei Shtylyov
<sshtylyov@ru.mvista.com> wrote:
> Hello.
>
> Ihar Hrachyshka wrote:
>>
>> I think that's a better solution for the problem I said so please commit
>> this patch rather previous one...
>>
>
>  Such comments are to be placed after --- tearline. Using several such
> tearlines makes it harder to apply your patch...
>  And why do you expect the MIPS maintainer to commit a patch to the serial
> driver? Such patches should be addressed to linux-serial@vger.kernel.org and
> (most probably) Alan Cox...

I thought that if it's a driver for mips piece of hardware then I need
to send it to mips guys. Ok, I'll send it to linux-serial.

>
>> ---
>>
>> Don't use ttyS[0-1] serial device name for board specific PNX8XXX UART
>> serial. Rather create ttyPNX[0-1]. Also changed minor number to be
>> different with sa1100 serial driver one.
>>
>> Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
>>
>
> [...]
>>
>> diff --git a/drivers/serial/pnx8xxx_uart.c b/drivers/serial/pnx8xxx_uart.c
>> index 22e30d2..96870f1 100644
>> --- a/drivers/serial/pnx8xxx_uart.c
>> +++ b/drivers/serial/pnx8xxx_uart.c
>> @@ -34,9 +34,8 @@
>>  #include <asm/io.h>
>>  #include <asm/irq.h>
>>  -/* We'll be using StrongARM sa1100 serial port major/minor */
>>  #define SERIAL_PNX8XXX_MAJOR   204
>> -#define MINOR_START            5
>> +#define MINOR_START            96
>>
>
>  This major-minor pair is reserved for the Altix serial cards. Have you
> tried registering the minor on http://www.lanana.org

Thanks for info. I sent the request.

>
> WBR, Sergei
>
>
>

[PATCH] Don't use ttyS* serial device name for board specific PNX8XXX UART serial

[Ihar Hrachyshka]

Don't use ttyS* serial device name for board specific PNX8XXX UART
serial. Rather create ttySA* to reflect that the driver uses device with
major:minor numbers for SA1100 serial driver.

Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
---
 drivers/serial/pnx8xxx_uart.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/serial/pnx8xxx_uart.c b/drivers/serial/pnx8xxx_uart.c
index 22e30d2..6785ee9 100644
--- a/drivers/serial/pnx8xxx_uart.c
+++ b/drivers/serial/pnx8xxx_uart.c
@@ -636,7 +636,7 @@ static struct uart_ops pnx8xxx_pops = {
 /*
  * Setup the PNX8XXX serial ports.
  *
- * Note also that we support "console=ttySx" where "x" is either 0 or 1.
+ * Note also that we support "console=ttySAx" where "x" is either 0 or 1.
  */
 static void __init pnx8xxx_init_ports(void)
 {
@@ -728,7 +728,7 @@ pnx8xxx_console_setup(struct console *co, char *options)
 
 static struct uart_driver pnx8xxx_reg;
 static struct console pnx8xxx_console = {
-	.name		= "ttyS",
+	.name		= "ttySA",
 	.write		= pnx8xxx_console_write,
 	.device		= uart_console_device,
 	.setup		= pnx8xxx_console_setup,
@@ -752,8 +752,8 @@ console_initcall(pnx8xxx_rs_console_init);
 
 static struct uart_driver pnx8xxx_reg = {
 	.owner			= THIS_MODULE,
-	.driver_name		= "ttyS",
-	.dev_name		= "ttyS",
+	.driver_name		= "ttySA",
+	.dev_name		= "ttySA",
 	.major			= SERIAL_PNX8XXX_MAJOR,
 	.minor			= MINOR_START,
 	.nr			= NR_PORTS,
-- 
1.5.6.3