All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bill Davidsen <davidsen@tmr.com>
To: linux-kernel@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [GIT PULL] adaptive spinning mutexes
Date: Fri, 16 Jan 2009 13:37:10 -0500	[thread overview]
Message-ID: <4970D3D6.3040906@tmr.com> (raw)
In-Reply-To: <1232047618.8269.93.camel@think.oraclecorp.com>

Chris Mason wrote:
> On Thu, 2009-01-15 at 10:16 -0800, Linus Torvalds wrote:
>> On Thu, 15 Jan 2009, Ingo Molnar wrote:
>>> btw., i think spin-mutexes have a design advantage here: in a lot of code 
>>> areas it's quite difficult to use spinlocks - cannot allocate memory, 
>>> cannot call any code that can sporadically block (but does not _normally_ 
>>> block), etc.
>>>
>>> With mutexes those atomicity constraints go away - and the performance 
>>> profile should now be quite close to that of spinlocks as well.
>> Umm. Except if you wrote the code nicely and used spinlocks, you wouldn't 
>> hold the lock over all those unnecessary and complex operations.
>>
> 
> While this is true, there are examples of places we should expect
> speedups for this today.
> 
> Concurrent file creation/deletion in a single dir will often find things
> hot in cache and not have to block anywhere (mail spools).
> 
And although not as common, NNTP servers using file per article storage.

> Concurrent O_DIRECT aio writes to the same file, where i_mutex is
> dropped early on.
> 
> pipes should see a huge improvement.
> 
I'd like to see that. Didn't realize how slow pipes really are.

> I'll kick off some runs of my three benchmarks on ext3 for comparison.
> If there are things less synthetic people would like to see, please let
> me know.
> 
> -chris
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


-- 
Bill Davidsen <davidsen@tmr.com>
   "We have more to fear from the bungling of the incompetent than from
the machinations of the wicked."  - from Slashdot

WARNING: multiple messages have this Message-ID (diff)
From: Bill Davidsen <davidsen@tmr.com>
To: linux-kernel@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [GIT PULL] adaptive spinning mutexes
Date: Fri, 16 Jan 2009 13:37:10 -0500	[thread overview]
Message-ID: <4970D3D6.3040906@tmr.com> (raw)
In-Reply-To: <1232047618.8269.93.camel@think.oraclecorp.com>

Chris Mason wrote:
> On Thu, 2009-01-15 at 10:16 -0800, Linus Torvalds wrote:
>> On Thu, 15 Jan 2009, Ingo Molnar wrote:
>>> btw., i think spin-mutexes have a design advantage here: in a lot of code 
>>> areas it's quite difficult to use spinlocks - cannot allocate memory, 
>>> cannot call any code that can sporadically block (but does not _normally_ 
>>> block), etc.
>>>
>>> With mutexes those atomicity constraints go away - and the performance 
>>> profile should now be quite close to that of spinlocks as well.
>> Umm. Except if you wrote the code nicely and used spinlocks, you wouldn't 
>> hold the lock over all those unnecessary and complex operations.
>>
> 
> While this is true, there are examples of places we should expect
> speedups for this today.
> 
> Concurrent file creation/deletion in a single dir will often find things
> hot in cache and not have to block anywhere (mail spools).
> 
And although not as common, NNTP servers using file per article storage.

> Concurrent O_DIRECT aio writes to the same file, where i_mutex is
> dropped early on.
> 
> pipes should see a huge improvement.
> 
I'd like to see that. Didn't realize how slow pipes really are.

> I'll kick off some runs of my three benchmarks on ext3 for comparison.
> If there are things less synthetic people would like to see, please let
> me know.
> 
> -chris
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


-- 
Bill Davidsen <davidsen@tmr.com>
   "We have more to fear from the bungling of the incompetent than from
the machinations of the wicked."  - from Slashdot


  parent reply	other threads:[~2009-01-16 18:37 UTC|newest]

Thread overview: 100+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-12 15:37 [PATCH -v8][RFC] mutex: implement adaptive spinning Peter Zijlstra
2009-01-12 16:04 ` Linus Torvalds
2009-01-12 16:20   ` Linus Torvalds
2009-01-12 16:45     ` Chris Mason
2009-01-12 16:50       ` Peter Zijlstra
2009-01-12 17:14         ` Chris Mason
2009-01-12 17:24           ` Peter Zijlstra
2009-01-12 17:30             ` Chris Mason
2009-01-12 17:16     ` Peter Zijlstra
2009-01-12 17:33       ` Boaz Harrosh
2009-01-12 18:07         ` Peter Zijlstra
2009-01-12 16:13 ` Avi Kivity
2009-01-12 17:13   ` Peter Zijlstra
2009-01-12 17:23     ` Avi Kivity
2009-01-12 17:32     ` Avi Kivity
2009-01-14 16:46       ` Peter Zijlstra
2009-01-14 17:04         ` Nick Piggin
2009-01-14 17:23           ` Avi Kivity
2009-01-15  0:50             ` Nick Piggin
2009-01-13 15:15 ` [PATCH -v9][RFC] " Peter Zijlstra
2009-01-13 16:16   ` Linus Torvalds
2009-01-13 16:21     ` Peter Zijlstra
2009-01-13 16:39       ` Ingo Molnar
2009-01-13 16:40       ` Peter Zijlstra
2009-01-13 16:49         ` Linus Torvalds
2009-01-13 17:21           ` Peter Zijlstra
2009-01-13 18:33             ` Ingo Molnar
2009-01-13 18:40               ` Linus Torvalds
2009-01-13 19:01                 ` Ingo Molnar
2009-01-14  2:58             ` Chris Mason
2009-01-14 11:18               ` Dmitry Adamushko
2009-01-14 16:47                 ` Chris Mason
2009-01-14 17:32                   ` Dmitry Adamushko
2009-01-14 11:21               ` Ingo Molnar
2009-01-14 15:43                 ` Linus Torvalds
2009-01-14 16:23                   ` Chris Mason
2009-01-14 17:06                   ` [PATCH -v11 delta] " Ingo Molnar
2009-01-14 17:00             ` [PATCH -v11][RFC] " Peter Zijlstra
2009-01-14 17:18               ` Nick Piggin
2009-01-14 17:22                 ` Peter Zijlstra
2009-01-15  0:46                   ` Nick Piggin
2009-01-15  7:44                     ` Peter Zijlstra
2009-01-15  7:52                       ` Nick Piggin
2009-01-14 18:33               ` [GIT PULL] adaptive spinning mutexes Ingo Molnar
2009-01-14 18:40                 ` Chris Mason
2009-01-15  9:53                   ` Ingo Molnar
2009-01-14 18:47                 ` Ingo Molnar
2009-01-14 19:28                   ` Ingo Molnar
2009-01-15 17:44                     ` Matthew Wilcox
2009-01-15 18:05                       ` Linus Torvalds
2009-01-15 18:08                         ` Ingo Molnar
2009-01-15 18:16                           ` Linus Torvalds
2009-01-15 19:26                             ` Chris Mason
2009-01-15 20:13                               ` Linus Torvalds
2009-01-15 21:04                                 ` Chris Mason
2009-01-15 22:03                                   ` Ingo Molnar
2009-01-16 13:32                               ` Folkert van Heusden
2009-01-16 13:32                                 ` Folkert van Heusden
2009-01-16 13:32                                 ` Folkert van Heusden
2009-01-16 13:57                                 ` Folkert van Heusden
2009-01-16 13:57                                   ` Folkert van Heusden
2009-01-16 13:57                                   ` Folkert van Heusden
2009-01-16 18:37                               ` Bill Davidsen [this message]
2009-01-16 18:37                                 ` Bill Davidsen
2009-01-16  0:53                             ` Paul E. McKenney
2009-01-16  1:01                               ` Linus Torvalds
2009-01-16  1:34                                 ` Paul E. McKenney
2009-01-16 14:07                                 ` Folkert van Heusden
2009-01-16  3:03                             ` Nick Piggin
2009-01-15 18:06                       ` Ingo Molnar
2009-01-14 18:53                 ` Andrew Morton
2009-01-14 19:00                   ` Ingo Molnar
2009-01-14 19:36                     ` Andrew Morton
2009-01-14 19:50                       ` Peter Zijlstra
2009-01-14 20:21                         ` Andrew Morton
2009-01-14 20:27                         ` Ingo Molnar
2009-01-14 20:44                           ` Andrew Morton
2009-01-14 20:14                       ` Ingo Molnar
2009-01-14 20:30                         ` Andrew Morton
2009-01-14 20:51                           ` Ingo Molnar
2009-01-14 21:06                             ` Andrew Morton
2009-01-14 21:14                               ` Ingo Molnar
2009-01-14 21:35                                 ` Andrew Morton
2009-01-14 23:23                                   ` Ingo Molnar
2009-01-15  0:55                                   ` Nick Piggin
2009-01-14 21:41                                 ` Ingo Molnar
2009-01-14 21:50                                   ` Kay Sievers
2009-01-14 22:34                                     ` Ingo Molnar
2009-01-15 11:45                                       ` Folkert van Heusden
2009-01-15 12:53                                       ` Chris Samuel
2009-01-14 19:23                   ` Peter Zijlstra
2009-01-14 19:33                     ` Ingo Molnar
2009-01-15  8:41             ` [PATCH] mutex: set owner only once on acquisition Johannes Weiner
2009-01-15  8:56               ` Johannes Weiner
2009-01-13 18:12           ` [PATCH -v9][RFC] mutex: implement adaptive spinning Ingo Molnar
2009-01-13 18:21             ` Linus Torvalds
2009-01-13 18:24               ` Ingo Molnar
2009-01-14 11:41 ` [PATCH -v8][RFC] " Folkert van Heusden
2009-01-14 11:42   ` Peter Zijlstra
2009-01-14 11:42   ` Folkert van Heusden

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4970D3D6.3040906@tmr.com \
    --to=davidsen@tmr.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.