[lm-sensors] [PATCH] hwmon: (f71882fg) Hide misleading error message

[lm-sensors] [PATCH] hwmon: (f71882fg) Hide misleading error message

[Jean Delvare]

From: Jean Delvare <khali@linux-fr.org>
Subject: hwmon: (f71882fg) Hide misleading error message

If the F71882FG chip is at address 0x4e, then the probe at 0x2e will
fail with the following message in the logs:
f71882fg: Not a Fintek device

This is misleading because there is a Fintek device, just at a
different address. So I propose to degrade this message to a debug
message.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Hans de Goede <hdegoede@redhat.com>
---
 drivers/hwmon/f71882fg.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.29-rc2.orig/drivers/hwmon/f71882fg.c	2009-01-11 10:57:18.000000000 +0100
+++ linux-2.6.29-rc2/drivers/hwmon/f71882fg.c	2009-01-19 20:11:16.000000000 +0100
@@ -1872,7 +1872,7 @@ static int __init f71882fg_find(int sioa
 
 	devid = superio_inw(sioaddr, SIO_REG_MANID);
 	if (devid != SIO_FINTEK_ID) {
-		printk(KERN_INFO DRVNAME ": Not a Fintek device\n");
+		pr_debug(DRVNAME ": Not a Fintek device\n");
 		goto exit;
 	}
 


-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] hwmon: (f71882fg) Hide misleading error

[Hans de Goede]

Jean Delvare wrote:
> From: Jean Delvare <khali@linux-fr.org>
> Subject: hwmon: (f71882fg) Hide misleading error message
> 
> If the F71882FG chip is at address 0x4e, then the probe at 0x2e will
> fail with the following message in the logs:
> f71882fg: Not a Fintek device
> 
> This is misleading because there is a Fintek device, just at a
> different address. So I propose to degrade this message to a debug
> message.
> 
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Cc: Hans de Goede <hdegoede@redhat.com>

Looks good to me
Acked-by: Hans de Goede <hdegoede@redhat.com>


> ---
>  drivers/hwmon/f71882fg.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-2.6.29-rc2.orig/drivers/hwmon/f71882fg.c	2009-01-11 10:57:18.000000000 +0100
> +++ linux-2.6.29-rc2/drivers/hwmon/f71882fg.c	2009-01-19 20:11:16.000000000 +0100
> @@ -1872,7 +1872,7 @@ static int __init f71882fg_find(int sioa
>  
>  	devid = superio_inw(sioaddr, SIO_REG_MANID);
>  	if (devid != SIO_FINTEK_ID) {
> -		printk(KERN_INFO DRVNAME ": Not a Fintek device\n");
> +		pr_debug(DRVNAME ": Not a Fintek device\n");
>  		goto exit;
>  	}
>  
> 
> 

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors