All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Mierswa <impulze@impulze.org>
To: grub-devel@gnu.org
Subject: [PATCH] Bug in UUID determiniation in fs/fat.c
Date: Wed, 21 Jan 2009 00:31:52 +0100	[thread overview]
Message-ID: <49765EE8.4050007@impulze.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 338 bytes --]

I found that during playing with ls -a. The UUID needs to be
right-shifted 16 times since it's a 32bit value and we need two 16bit
values. :)

-- 
Mierswa, Daniel

If you still don't like it, that's ok: that's why I'm boss. I simply
know better than you do.
               --- Linus Torvalds, comp.os.linux.advocacy, 1996/07/22

[-- Attachment #2: fs_fat_wrong_uuid.patch --]
[-- Type: text/plain, Size: 449 bytes --]

Index: fs/fat.c
===================================================================
--- fs/fat.c	(revision 1952)
+++ fs/fat.c	(working copy)
@@ -841,7 +841,7 @@
   if (data)
     {
       *uuid = grub_malloc (sizeof ("xxxx-xxxx"));
-      grub_sprintf (*uuid, "%04x-%04x", (grub_uint16_t) (data->uuid >> 8),
+      grub_sprintf (*uuid, "%04x-%04x", (grub_uint16_t) (data->uuid >> 16),
 		    (grub_uint16_t) data->uuid);
     }
   else

             reply	other threads:[~2009-01-20 23:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-20 23:31 Daniel Mierswa [this message]
2009-01-26  4:36 ` [PATCH] Bug in UUID determiniation in fs/fat.c Pavel Roskin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49765EE8.4050007@impulze.org \
    --to=impulze@impulze.org \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.