[PATCH] Bug in UUID determiniation in fs/fat.c

[PATCH] Bug in UUID determiniation in fs/fat.c

[Daniel Mierswa]

[-- Attachment #1: Type: text/plain, Size: 338 bytes --]

I found that during playing with ls -a. The UUID needs to be
right-shifted 16 times since it's a 32bit value and we need two 16bit
values. :)

-- 
Mierswa, Daniel

If you still don't like it, that's ok: that's why I'm boss. I simply
know better than you do.
               --- Linus Torvalds, comp.os.linux.advocacy, 1996/07/22

[-- Attachment #2: fs_fat_wrong_uuid.patch --]
[-- Type: text/plain, Size: 449 bytes --]

Index: fs/fat.c
===================================================================
--- fs/fat.c	(revision 1952)
+++ fs/fat.c	(working copy)
@@ -841,7 +841,7 @@
   if (data)
     {
       *uuid = grub_malloc (sizeof ("xxxx-xxxx"));
-      grub_sprintf (*uuid, "%04x-%04x", (grub_uint16_t) (data->uuid >> 8),
+      grub_sprintf (*uuid, "%04x-%04x", (grub_uint16_t) (data->uuid >> 16),
 		    (grub_uint16_t) data->uuid);
     }
   else

Re: [PATCH] Bug in UUID determiniation in fs/fat.c

[Pavel Roskin]

On Wed, 2009-01-21 at 00:31 +0100, Daniel Mierswa wrote:
> I found that during playing with ls -a. The UUID needs to be
> right-shifted 16 times since it's a 32bit value and we need two 16bit
> values. :)

Applied.  Thank you!

-- 
Regards,
Pavel Roskin