Re: [PATCH] ide/libata: fix ata_id_is_cfa()

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Hello.

Alan Cox wrote:

>>When checking for CFA feature set support, ata_id_is_cfa() tests bit 2 in word
>>82 of the identify data instead the word 83.  It also checks the ATA revision
>>in the  word 80 instead of usual validity check for the words 82-83 -- word 83
>>bit 14 set, bit 15 cleared.

> The word 82 validity bit is not sufficient as that bit is itself not

    There's no word 82 validity bits, its validity bits are in word 83.

> defined in ATA < 3. Otherwise the change looks correct.

    Well, then we need to fix every case of using *only* the validity bits in 
ata.h. Go ahead. ;-)

> Alan

WBR, Sergei