From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: bzolnier@gmail.com, jgarzik@pobox.com, linux-ide@vger.kernel.org,
gdu@mns.spb.ru
Subject: Re: [PATCH] ide/libata: fix ata_id_is_cfa()
Date: Fri, 23 Jan 2009 20:27:31 +0300 [thread overview]
Message-ID: <4979FE03.9060806@ru.mvista.com> (raw)
In-Reply-To: <20090123133352.60add80e@lxorguk.ukuu.org.uk>
Alan Cox wrote:
>>When checking for CFA feature set support, ata_id_is_cfa() tests bit 2 in word
>>82 of the identify data instead the word 83. It also checks the ATA revision
>>in the word 80 instead of usual validity check for the words 82-83 -- word 83
>>bit 14 set, bit 15 cleared.
> The word 82 validity bit is not sufficient as that bit is itself not
> defined in ATA < 3. Otherwise the change looks correct.
Besides, I find the necessity of ATA revison check somewhat arguable.
Words 64-127 were reserved since ATA-1 which meant that they shall be set to 0.
> Alan
MBR, Sergei
next prev parent reply other threads:[~2009-01-23 17:27 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-23 13:15 [PATCH] ide/libata: fix ata_id_is_cfa() Sergei Shtylyov
2009-01-23 13:33 ` Alan Cox
2009-01-23 13:53 ` Sergei Shtylyov
2009-01-23 15:43 ` Alan Cox
2009-01-23 16:30 ` Sergei Shtylyov
2009-01-23 16:41 ` Alan Cox
2009-01-23 17:01 ` Sergei Shtylyov
2009-01-23 17:12 ` Mark Lord
2009-01-23 17:18 ` Sergei Shtylyov
2009-01-23 17:27 ` Sergei Shtylyov [this message]
2009-01-23 17:53 ` Alan Cox
2009-01-23 19:13 ` Sergei Shtylyov
2009-01-24 23:06 ` Sergei Shtylyov
2009-01-25 10:50 ` Alan Cox
2009-01-26 11:49 ` Sergei Shtylyov
2009-01-26 12:01 ` Alan Cox
2009-01-26 18:11 ` Sergei Shtylyov
2009-01-26 19:01 ` Alan Cox
2009-01-26 19:25 ` Sergei Shtylyov
2009-01-25 10:52 ` Alan Cox
2009-01-25 19:04 ` Bartlomiej Zolnierkiewicz
2009-01-26 19:32 ` Sergei Shtylyov
2009-01-26 18:47 ` Sergei Shtylyov
2009-01-26 19:08 ` Alan Cox
2009-01-26 19:28 ` Sergei Shtylyov
2009-01-26 19:33 ` Sergei Shtylyov
2009-01-26 19:41 ` Alan Cox
2009-01-26 19:42 ` Alan Cox
2009-01-26 19:56 ` Sergei Shtylyov
2009-01-26 20:01 ` Alan Cox
2009-01-26 20:31 ` Sergei Shtylyov
2009-01-26 20:59 ` Sergei Shtylyov
2009-01-26 21:22 ` Alan Cox
2009-01-26 21:38 ` Sergei Shtylyov
2009-01-26 21:43 ` Sergei Shtylyov
2009-01-26 23:28 ` Sergei Shtylyov
2009-01-26 20:47 ` Sergei Shtylyov
2009-01-26 19:39 ` Alan Cox
2009-01-26 19:31 ` Sergei Shtylyov
2009-01-26 19:35 ` Alan Cox
2009-01-26 19:45 ` Sergei Shtylyov
2009-01-26 19:54 ` Alan Cox
2009-01-26 20:03 ` Sergei Shtylyov
2009-01-26 20:12 ` Jeff Garzik
2009-01-26 20:23 ` Sergei Shtylyov
2009-01-26 20:33 ` Alan Cox
2009-01-26 20:41 ` Sergei Shtylyov
2009-01-26 23:53 ` Sergei Shtylyov
2009-01-26 20:16 ` Sergei Shtylyov
2009-01-27 11:29 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4979FE03.9060806@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=gdu@mns.spb.ru \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.