Re: [PATCH] ide/libata: fix ata_id_is_cfa()

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Hello, I wrote:

>> This is what I would favour:

>> libata: Fix CFA detection & improve version inlines

>> From: Alan Cox <alan@redhat.com>

>> Sergei Shtylyov noticed thae ata_id_is_cfa checked the wrong word for the
>> secondary CFA test and posted a patch set to improve this, but which
>> removed the version checks.

>    And did that completely correctly.

>> This patch keeps the version checks but incorporates the other 
>> suggestions
>> Sergei made including a better ata version check for the usual case where
>> we want to know "is version >= x" rather than "what version do you
>> support".

>    Improvements should be mixed with fixes.

    Should not be, I meant to type.

WBR, Sergei