* [Qemu-devel] [6936] target-mips: optimize gen_compute_branch()
@ 2009-03-29 1:18 Aurelien Jarno
2009-03-29 20:39 ` Stefan Weil
0 siblings, 1 reply; 3+ messages in thread
From: Aurelien Jarno @ 2009-03-29 1:18 UTC (permalink / raw)
To: qemu-devel
Revision: 6936
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6936
Author: aurel32
Date: 2009-03-29 01:18:52 +0000 (Sun, 29 Mar 2009)
Log Message:
-----------
target-mips: optimize gen_compute_branch()
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Modified Paths:
--------------
trunk/target-mips/cpu.h
trunk/target-mips/machine.c
trunk/target-mips/translate.c
Modified: trunk/target-mips/cpu.h
===================================================================
--- trunk/target-mips/cpu.h 2009-03-29 01:18:43 UTC (rev 6935)
+++ trunk/target-mips/cpu.h 2009-03-29 01:18:52 UTC (rev 6936)
@@ -443,7 +443,7 @@
#define MIPS_HFLAG_BL 0x0C00 /* Likely branch */
#define MIPS_HFLAG_BR 0x1000 /* branch to register (can't link TB) */
target_ulong btarget; /* Jump / branch target */
- int bcond; /* Branch condition (if needed) */
+ target_ulong bcond; /* Branch condition (if needed) */
int SYNCI_Step; /* Address step size for SYNCI */
int CCRes; /* Cycle count resolution/divisor */
Modified: trunk/target-mips/machine.c
===================================================================
--- trunk/target-mips/machine.c 2009-03-29 01:18:43 UTC (rev 6935)
+++ trunk/target-mips/machine.c 2009-03-29 01:18:52 UTC (rev 6936)
@@ -91,7 +91,8 @@
qemu_put_sbe32s(f, &env->error_code);
qemu_put_be32s(f, &env->hflags);
qemu_put_betls(f, &env->btarget);
- qemu_put_sbe32s(f, &env->bcond);
+ i = env->bcond;
+ qemu_put_sbe32s(f, &i);
/* Save remaining CP1 registers */
qemu_put_sbe32s(f, &env->CP0_Index);
@@ -240,7 +241,8 @@
qemu_get_sbe32s(f, &env->error_code);
qemu_get_be32s(f, &env->hflags);
qemu_get_betls(f, &env->btarget);
- qemu_get_sbe32s(f, &env->bcond);
+ qemu_get_sbe32s(f, &i);
+ env->bcond = i;
/* Load remaining CP1 registers */
qemu_get_sbe32s(f, &env->CP0_Index);
Modified: trunk/target-mips/translate.c
===================================================================
--- trunk/target-mips/translate.c 2009-03-29 01:18:43 UTC (rev 6935)
+++ trunk/target-mips/translate.c 2009-03-29 01:18:52 UTC (rev 6936)
@@ -430,7 +430,7 @@
static TCGv cpu_gpr[32], cpu_PC;
static TCGv cpu_HI[MIPS_DSP_ACC], cpu_LO[MIPS_DSP_ACC], cpu_ACX[MIPS_DSP_ACC];
static TCGv cpu_dspctrl, btarget;
-static TCGv_i32 bcond;
+static TCGv bcond;
static TCGv_i32 fpu_fpr32[32], fpu_fpr32h[32];
static TCGv_i32 fpu_fcr0, fpu_fcr31;
@@ -2167,7 +2167,7 @@
{
int cond;
TCGv t0 = tcg_temp_local_new();
- TCGv t1 = tcg_temp_local_new();
+ TCGv t1 = tcg_temp_new();
cond = 0;
/* Load needed operands */
@@ -2290,8 +2290,8 @@
target_ulong btgt = -1;
int blink = 0;
int bcond_compute = 0;
- TCGv t0 = tcg_temp_local_new();
- TCGv t1 = tcg_temp_local_new();
+ TCGv t0 = tcg_temp_new();
+ TCGv t1 = tcg_temp_new();
if (ctx->hflags & MIPS_HFLAG_BMASK) {
#ifdef MIPS_DEBUG_DISAS
@@ -2383,13 +2383,11 @@
MIPS_DEBUG("bnever (NOP)");
goto out;
case OPC_BLTZAL: /* 0 < 0 */
- tcg_gen_movi_tl(t0, ctx->pc + 8);
- gen_store_gpr(t0, 31);
+ tcg_gen_movi_tl(cpu_gpr[31], ctx->pc + 8);
MIPS_DEBUG("bnever and link");
goto out;
case OPC_BLTZALL: /* 0 < 0 likely */
- tcg_gen_movi_tl(t0, ctx->pc + 8);
- gen_store_gpr(t0, 31);
+ tcg_gen_movi_tl(cpu_gpr[31], ctx->pc + 8);
/* Skip the instruction in the delay slot */
MIPS_DEBUG("bnever, link and skip");
ctx->pc += 4;
@@ -2427,82 +2425,80 @@
} else {
switch (opc) {
case OPC_BEQ:
- gen_op_eq(t0, t0, t1);
+ gen_op_eq(bcond, t0, t1);
MIPS_DEBUG("beq %s, %s, " TARGET_FMT_lx,
regnames[rs], regnames[rt], btgt);
goto not_likely;
case OPC_BEQL:
- gen_op_eq(t0, t0, t1);
+ gen_op_eq(bcond, t0, t1);
MIPS_DEBUG("beql %s, %s, " TARGET_FMT_lx,
regnames[rs], regnames[rt], btgt);
goto likely;
case OPC_BNE:
- gen_op_ne(t0, t0, t1);
+ gen_op_ne(bcond, t0, t1);
MIPS_DEBUG("bne %s, %s, " TARGET_FMT_lx,
regnames[rs], regnames[rt], btgt);
goto not_likely;
case OPC_BNEL:
- gen_op_ne(t0, t0, t1);
+ gen_op_ne(bcond, t0, t1);
MIPS_DEBUG("bnel %s, %s, " TARGET_FMT_lx,
regnames[rs], regnames[rt], btgt);
goto likely;
case OPC_BGEZ:
- gen_op_gez(t0, t0);
+ gen_op_gez(bcond, t0);
MIPS_DEBUG("bgez %s, " TARGET_FMT_lx, regnames[rs], btgt);
goto not_likely;
case OPC_BGEZL:
- gen_op_gez(t0, t0);
+ gen_op_gez(bcond, t0);
MIPS_DEBUG("bgezl %s, " TARGET_FMT_lx, regnames[rs], btgt);
goto likely;
case OPC_BGEZAL:
- gen_op_gez(t0, t0);
+ gen_op_gez(bcond, t0);
MIPS_DEBUG("bgezal %s, " TARGET_FMT_lx, regnames[rs], btgt);
blink = 31;
goto not_likely;
case OPC_BGEZALL:
- gen_op_gez(t0, t0);
+ gen_op_gez(bcond, t0);
blink = 31;
MIPS_DEBUG("bgezall %s, " TARGET_FMT_lx, regnames[rs], btgt);
goto likely;
case OPC_BGTZ:
- gen_op_gtz(t0, t0);
+ gen_op_gtz(bcond, t0);
MIPS_DEBUG("bgtz %s, " TARGET_FMT_lx, regnames[rs], btgt);
goto not_likely;
case OPC_BGTZL:
- gen_op_gtz(t0, t0);
+ gen_op_gtz(bcond, t0);
MIPS_DEBUG("bgtzl %s, " TARGET_FMT_lx, regnames[rs], btgt);
goto likely;
case OPC_BLEZ:
- gen_op_lez(t0, t0);
+ gen_op_lez(bcond, t0);
MIPS_DEBUG("blez %s, " TARGET_FMT_lx, regnames[rs], btgt);
goto not_likely;
case OPC_BLEZL:
- gen_op_lez(t0, t0);
+ gen_op_lez(bcond, t0);
MIPS_DEBUG("blezl %s, " TARGET_FMT_lx, regnames[rs], btgt);
goto likely;
case OPC_BLTZ:
- gen_op_ltz(t0, t0);
+ gen_op_ltz(bcond, t0);
MIPS_DEBUG("bltz %s, " TARGET_FMT_lx, regnames[rs], btgt);
goto not_likely;
case OPC_BLTZL:
- gen_op_ltz(t0, t0);
+ gen_op_ltz(bcond, t0);
MIPS_DEBUG("bltzl %s, " TARGET_FMT_lx, regnames[rs], btgt);
goto likely;
case OPC_BLTZAL:
- gen_op_ltz(t0, t0);
+ gen_op_ltz(bcond, t0);
blink = 31;
MIPS_DEBUG("bltzal %s, " TARGET_FMT_lx, regnames[rs], btgt);
not_likely:
ctx->hflags |= MIPS_HFLAG_BC;
- tcg_gen_trunc_tl_i32(bcond, t0);
break;
case OPC_BLTZALL:
- gen_op_ltz(t0, t0);
+ gen_op_ltz(bcond, t0);
blink = 31;
MIPS_DEBUG("bltzall %s, " TARGET_FMT_lx, regnames[rs], btgt);
likely:
ctx->hflags |= MIPS_HFLAG_BL;
- tcg_gen_trunc_tl_i32(bcond, t0);
break;
default:
MIPS_INVAL("conditional branch/jump");
@@ -2515,8 +2511,7 @@
ctx->btarget = btgt;
if (blink > 0) {
- tcg_gen_movi_tl(t0, ctx->pc + 8);
- gen_store_gpr(t0, blink);
+ tcg_gen_movi_tl(cpu_gpr[blink], ctx->pc + 8);
}
out:
@@ -5537,10 +5532,10 @@
get_fp_cond(t0);
tcg_gen_andi_i32(t0, t0, 0x1 << cc);
tcg_gen_brcondi_i32(TCG_COND_EQ, t0, 0, l1);
- tcg_gen_movi_i32(bcond, 0);
+ tcg_gen_movi_tl(bcond, 0);
tcg_gen_br(l2);
gen_set_label(l1);
- tcg_gen_movi_i32(bcond, 1);
+ tcg_gen_movi_tl(bcond, 1);
gen_set_label(l2);
}
opn = "bc1f";
@@ -5553,10 +5548,10 @@
get_fp_cond(t0);
tcg_gen_andi_i32(t0, t0, 0x1 << cc);
tcg_gen_brcondi_i32(TCG_COND_EQ, t0, 0, l1);
- tcg_gen_movi_i32(bcond, 0);
+ tcg_gen_movi_tl(bcond, 0);
tcg_gen_br(l2);
gen_set_label(l1);
- tcg_gen_movi_i32(bcond, 1);
+ tcg_gen_movi_tl(bcond, 1);
gen_set_label(l2);
}
opn = "bc1fl";
@@ -5569,10 +5564,10 @@
get_fp_cond(t0);
tcg_gen_andi_i32(t0, t0, 0x1 << cc);
tcg_gen_brcondi_i32(TCG_COND_NE, t0, 0, l1);
- tcg_gen_movi_i32(bcond, 0);
+ tcg_gen_movi_tl(bcond, 0);
tcg_gen_br(l2);
gen_set_label(l1);
- tcg_gen_movi_i32(bcond, 1);
+ tcg_gen_movi_tl(bcond, 1);
gen_set_label(l2);
}
opn = "bc1t";
@@ -5585,10 +5580,10 @@
get_fp_cond(t0);
tcg_gen_andi_i32(t0, t0, 0x1 << cc);
tcg_gen_brcondi_i32(TCG_COND_NE, t0, 0, l1);
- tcg_gen_movi_i32(bcond, 0);
+ tcg_gen_movi_tl(bcond, 0);
tcg_gen_br(l2);
gen_set_label(l1);
- tcg_gen_movi_i32(bcond, 1);
+ tcg_gen_movi_tl(bcond, 1);
gen_set_label(l2);
}
opn = "bc1tl";
@@ -5603,10 +5598,10 @@
get_fp_cond(t0);
tcg_gen_andi_i32(t0, t0, 0x3 << cc);
tcg_gen_brcondi_i32(TCG_COND_EQ, t0, 0, l1);
- tcg_gen_movi_i32(bcond, 0);
+ tcg_gen_movi_tl(bcond, 0);
tcg_gen_br(l2);
gen_set_label(l1);
- tcg_gen_movi_i32(bcond, 1);
+ tcg_gen_movi_tl(bcond, 1);
gen_set_label(l2);
}
opn = "bc1any2f";
@@ -5619,10 +5614,10 @@
get_fp_cond(t0);
tcg_gen_andi_i32(t0, t0, 0x3 << cc);
tcg_gen_brcondi_i32(TCG_COND_NE, t0, 0, l1);
- tcg_gen_movi_i32(bcond, 0);
+ tcg_gen_movi_tl(bcond, 0);
tcg_gen_br(l2);
gen_set_label(l1);
- tcg_gen_movi_i32(bcond, 1);
+ tcg_gen_movi_tl(bcond, 1);
gen_set_label(l2);
}
opn = "bc1any2t";
@@ -5635,10 +5630,10 @@
get_fp_cond(t0);
tcg_gen_andi_i32(t0, t0, 0xf << cc);
tcg_gen_brcondi_i32(TCG_COND_EQ, t0, 0, l1);
- tcg_gen_movi_i32(bcond, 0);
+ tcg_gen_movi_tl(bcond, 0);
tcg_gen_br(l2);
gen_set_label(l1);
- tcg_gen_movi_i32(bcond, 1);
+ tcg_gen_movi_tl(bcond, 1);
gen_set_label(l2);
}
opn = "bc1any4f";
@@ -5651,10 +5646,10 @@
get_fp_cond(t0);
tcg_gen_andi_i32(t0, t0, 0xf << cc);
tcg_gen_brcondi_i32(TCG_COND_NE, t0, 0, l1);
- tcg_gen_movi_i32(bcond, 0);
+ tcg_gen_movi_tl(bcond, 0);
tcg_gen_br(l2);
gen_set_label(l1);
- tcg_gen_movi_i32(bcond, 1);
+ tcg_gen_movi_tl(bcond, 1);
gen_set_label(l2);
}
opn = "bc1any4t";
@@ -7585,7 +7580,7 @@
int l1 = gen_new_label();
MIPS_DEBUG("blikely condition (" TARGET_FMT_lx ")", ctx->pc + 4);
- tcg_gen_brcondi_i32(TCG_COND_NE, bcond, 0, l1);
+ tcg_gen_brcondi_tl(TCG_COND_NE, bcond, 0, l1);
{
TCGv_i32 r_tmp = tcg_temp_new_i32();
@@ -8147,7 +8142,7 @@
{
int l1 = gen_new_label();
- tcg_gen_brcondi_i32(TCG_COND_NE, bcond, 0, l1);
+ tcg_gen_brcondi_tl(TCG_COND_NE, bcond, 0, l1);
gen_goto_tb(ctx, 1, ctx->pc + 4);
gen_set_label(l1);
gen_goto_tb(ctx, 0, ctx->btarget);
@@ -8440,8 +8435,8 @@
cpu_dspctrl = tcg_global_mem_new(TCG_AREG0,
offsetof(CPUState, active_tc.DSPControl),
"DSPControl");
- bcond = tcg_global_mem_new_i32(TCG_AREG0,
- offsetof(CPUState, bcond), "bcond");
+ bcond = tcg_global_mem_new(TCG_AREG0,
+ offsetof(CPUState, bcond), "bcond");
btarget = tcg_global_mem_new(TCG_AREG0,
offsetof(CPUState, btarget), "btarget");
for (i = 0; i < 32; i++)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [6936] target-mips: optimize gen_compute_branch()
2009-03-29 1:18 [Qemu-devel] [6936] target-mips: optimize gen_compute_branch() Aurelien Jarno
@ 2009-03-29 20:39 ` Stefan Weil
2009-03-29 22:11 ` Aurelien Jarno
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Weil @ 2009-03-29 20:39 UTC (permalink / raw)
To: qemu-devel, Aurelien Jarno
Aurelien Jarno schrieb:
> Revision: 6936
> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6936
> Author: aurel32
> Date: 2009-03-29 01:18:52 +0000 (Sun, 29 Mar 2009)
> Log Message:
> -----------
> target-mips: optimize gen_compute_branch()
>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
>
> Modified Paths:
> --------------
> trunk/target-mips/cpu.h
> trunk/target-mips/machine.c
> trunk/target-mips/translate.c
>
> Modified: trunk/target-mips/cpu.h
> ===================================================================
> --- trunk/target-mips/cpu.h 2009-03-29 01:18:43 UTC (rev 6935)
> +++ trunk/target-mips/cpu.h 2009-03-29 01:18:52 UTC (rev 6936)
> @@ -443,7 +443,7 @@
> #define MIPS_HFLAG_BL 0x0C00 /* Likely branch */
> #define MIPS_HFLAG_BR 0x1000 /* branch to register (can't link TB) */
> target_ulong btarget; /* Jump / branch target */
> - int bcond; /* Branch condition (if needed) */
> + target_ulong bcond; /* Branch condition (if needed) */
>
> int SYNCI_Step; /* Address step size for SYNCI */
> int CCRes; /* Cycle count resolution/divisor */
>
> Modified: trunk/target-mips/machine.c
> ===================================================================
> --- trunk/target-mips/machine.c 2009-03-29 01:18:43 UTC (rev 6935)
> +++ trunk/target-mips/machine.c 2009-03-29 01:18:52 UTC (rev 6936)
> @@ -91,7 +91,8 @@
> qemu_put_sbe32s(f, &env->error_code);
> qemu_put_be32s(f, &env->hflags);
> qemu_put_betls(f, &env->btarget);
> - qemu_put_sbe32s(f, &env->bcond);
> + i = env->bcond;
> + qemu_put_sbe32s(f, &i);
>
bcond is now target_ulong (32 or 64 bit target), i is int.
Are the upper 32 bits of bcond not needed?
>
> /* Save remaining CP1 registers */
> qemu_put_sbe32s(f, &env->CP0_Index);
> @@ -240,7 +241,8 @@
> qemu_get_sbe32s(f, &env->error_code);
> qemu_get_be32s(f, &env->hflags);
> qemu_get_betls(f, &env->btarget);
> - qemu_get_sbe32s(f, &env->bcond);
> + qemu_get_sbe32s(f, &i);
> + env->bcond = i;
>
See above.
>
> /* Load remaining CP1 registers */
> qemu_get_sbe32s(f, &env->CP0_Index);
>
>
Regards
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [6936] target-mips: optimize gen_compute_branch()
2009-03-29 20:39 ` Stefan Weil
@ 2009-03-29 22:11 ` Aurelien Jarno
0 siblings, 0 replies; 3+ messages in thread
From: Aurelien Jarno @ 2009-03-29 22:11 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-devel
On Sun, Mar 29, 2009 at 10:39:58PM +0200, Stefan Weil wrote:
> Aurelien Jarno schrieb:
> > Revision: 6936
> > http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6936
> > Author: aurel32
> > Date: 2009-03-29 01:18:52 +0000 (Sun, 29 Mar 2009)
> > Log Message:
> > -----------
> > target-mips: optimize gen_compute_branch()
> >
> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> >
> > Modified Paths:
> > --------------
> > trunk/target-mips/cpu.h
> > trunk/target-mips/machine.c
> > trunk/target-mips/translate.c
> >
> > Modified: trunk/target-mips/cpu.h
> > ===================================================================
> > --- trunk/target-mips/cpu.h 2009-03-29 01:18:43 UTC (rev 6935)
> > +++ trunk/target-mips/cpu.h 2009-03-29 01:18:52 UTC (rev 6936)
> > @@ -443,7 +443,7 @@
> > #define MIPS_HFLAG_BL 0x0C00 /* Likely branch */
> > #define MIPS_HFLAG_BR 0x1000 /* branch to register (can't link TB) */
> > target_ulong btarget; /* Jump / branch target */
> > - int bcond; /* Branch condition (if needed) */
> > + target_ulong bcond; /* Branch condition (if needed) */
> >
> > int SYNCI_Step; /* Address step size for SYNCI */
> > int CCRes; /* Cycle count resolution/divisor */
> >
> > Modified: trunk/target-mips/machine.c
> > ===================================================================
> > --- trunk/target-mips/machine.c 2009-03-29 01:18:43 UTC (rev 6935)
> > +++ trunk/target-mips/machine.c 2009-03-29 01:18:52 UTC (rev 6936)
> > @@ -91,7 +91,8 @@
> > qemu_put_sbe32s(f, &env->error_code);
> > qemu_put_be32s(f, &env->hflags);
> > qemu_put_betls(f, &env->btarget);
> > - qemu_put_sbe32s(f, &env->bcond);
> > + i = env->bcond;
> > + qemu_put_sbe32s(f, &i);
> >
>
> bcond is now target_ulong (32 or 64 bit target), i is int.
> Are the upper 32 bits of bcond not needed?
No they are not used as this variable only contains 0 or 1, so saving
only the lower 32 bits is fine.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-03-29 22:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-29 1:18 [Qemu-devel] [6936] target-mips: optimize gen_compute_branch() Aurelien Jarno
2009-03-29 20:39 ` Stefan Weil
2009-03-29 22:11 ` Aurelien Jarno
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.